Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Missing Type Annotations #8

Merged
merged 6 commits into from
Jan 27, 2023
Merged

Add Missing Type Annotations #8

merged 6 commits into from
Jan 27, 2023

Conversation

tcfranks
Copy link
Contributor

resolves #4
submitted for review / comment

tekktrik
tekktrik requested changes Jan 20, 2023
View reviewed changes
Copy link
Member

@tekktrik tekktrik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looks like there's a few things I found not caused by any of your commits but related to this update, so I've mentioned them too.

adafruit_pcf8591/analog_in.py Outdated Show resolved Hide resolved
adafruit_pcf8591/analog_in.py Outdated Show resolved Hide resolved
adafruit_pcf8591/analog_out.py Outdated Show resolved Hide resolved
adafruit_pcf8591/analog_out.py Outdated Show resolved Hide resolved
adafruit_pcf8591/pcf8591.py Show resolved Hide resolved
tekktrik
tekktrik requested changes Jan 20, 2023
View reviewed changes
Copy link
Member

@tekktrik tekktrik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Just a couple more things I noticed.

adafruit_pcf8591/analog_out.py Show resolved Hide resolved
adafruit_pcf8591/pcf8591.py Outdated Show resolved Hide resolved
@tekktrik tekktrik self-requested a review January 20, 2023 18:29
tekktrik
tekktrik requested changes Jan 23, 2023
View reviewed changes
adafruit_pcf8591/analog_out.py Show resolved Hide resolved
adafruit_pcf8591/pcf8591.py Outdated Show resolved Hide resolved
@tekktrik tekktrik self-requested a review January 23, 2023 22:05
tekktrik
tekktrik requested changes Jan 24, 2023
View reviewed changes
adafruit_pcf8591/analog_out.py Outdated Show resolved Hide resolved
@tekktrik
Copy link
Member

Thanks!

@tekktrik tekktrik merged commit 05ef267 into adafruit:main Jan 27, 2023
adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Jan 28, 2023
@adafruit-adabot
Automated update by Adabot (adafruit/adabot@88e01fd)
667b6eb 
Updating https://github.com/adafruit/Adafruit_CircuitPython_LSM303DLH_Mag to 1.1.18 from 1.1.17:
  > Merge pull request adafruit/Adafruit_CircuitPython_LSM303DLH_Mag#20 from jposada202020/type_annotations

Updating https://github.com/adafruit/Adafruit_CircuitPython_LSM9DS1 to 2.1.19 from 2.1.18:
  > Merge pull request adafruit/Adafruit_CircuitPython_LSM9DS1#36 from tcfranks/main
  > Add upload url to release action
  > Add .venv to .gitignore

Updating https://github.com/adafruit/Adafruit_CircuitPython_PCF8591 to 1.0.14 from 1.0.13:
  > Merge pull request adafruit/Adafruit_CircuitPython_PCF8591#8 from tcfranks/main
  > Add upload url to release action
  > Add .venv to .gitignore

Updating https://github.com/adafruit/Adafruit_CircuitPython_LED_Animation to 2.6.6 from 2.6.4:
  > Merge pull request adafruit/Adafruit_CircuitPython_LED_Animation#110 from tlyu/comet-doc

Updating https://github.com/adafruit/Adafruit_CircuitPython_Bundle/circuitpython_library_list.md to NA from NA:
  > Updated download stats for the libraries
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tekktrik tekktrik tekktrik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing Type Annotations
2 participants
@tcfranks @tekktrik