Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

comet: add doc for background_color #110

Merged
merged 1 commit into from
Jan 25, 2023
Merged

Conversation

tlyu
Copy link
Contributor

@tlyu tlyu commented Jan 25, 2023

Add missing documentation for the recently-added background_color parameter to Comet.

Copy link
Contributor

@jposada202020 jposada202020 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @tlyu :). Could you add that the parameter defaults to Black to better reflect the library behavior? Thanks :)

@tlyu
Copy link
Contributor Author

tlyu commented Jan 25, 2023

Could you add that the parameter defaults to Black to better reflect the library behavior?

Done!

Add missing documentation for the recently-added `background_color`
parameter to `Comet`.

Signed-off-by: Taylor Yu <[email protected]>
Copy link
Contributor

@jposada202020 jposada202020 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank You!

@jposada202020 jposada202020 merged commit b8538c6 into adafruit:main Jan 25, 2023
adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Jan 28, 2023
Updating https://github.com/adafruit/Adafruit_CircuitPython_LSM303DLH_Mag to 1.1.18 from 1.1.17:
  > Merge pull request adafruit/Adafruit_CircuitPython_LSM303DLH_Mag#20 from jposada202020/type_annotations

Updating https://github.com/adafruit/Adafruit_CircuitPython_LSM9DS1 to 2.1.19 from 2.1.18:
  > Merge pull request adafruit/Adafruit_CircuitPython_LSM9DS1#36 from tcfranks/main
  > Add upload url to release action
  > Add .venv to .gitignore

Updating https://github.com/adafruit/Adafruit_CircuitPython_PCF8591 to 1.0.14 from 1.0.13:
  > Merge pull request adafruit/Adafruit_CircuitPython_PCF8591#8 from tcfranks/main
  > Add upload url to release action
  > Add .venv to .gitignore

Updating https://github.com/adafruit/Adafruit_CircuitPython_LED_Animation to 2.6.6 from 2.6.4:
  > Merge pull request adafruit/Adafruit_CircuitPython_LED_Animation#110 from tlyu/comet-doc

Updating https://github.com/adafruit/Adafruit_CircuitPython_Bundle/circuitpython_library_list.md to NA from NA:
  > Updated download stats for the libraries
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants