New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Missing Type Annotations #36

Merged

tekktrik merged 2 commits into adafruit:main from tcfranks:main

Jan 27, 2023

Contributor

tcfranks commented Jan 23, 2023

resolves #31
submitted for review / comment


          Add Missing Type Annotations

54bfcc7

tekktrik requested changes

View reviewed changes

Member

tekktrik left a comment

Excellent! Also, good job finding those docstring fixes! One tiny update but otherwise looks great!

adafruit_lsm9ds1.py Outdated Show resolved Hide resolved


          change return type per reviewer comments

a6534db

tekktrik approved these changes

View reviewed changes

Member

tekktrik left a comment

Thanks!

tekktrik merged commit 0b40160 into adafruit:main

adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request


          Automated update by Adabot (adafruit/adabot@88e01fd)

667b6eb

Updating https://github.com/adafruit/Adafruit_CircuitPython_LSM303DLH_Mag to 1.1.18 from 1.1.17:
  > Merge pull request adafruit/Adafruit_CircuitPython_LSM303DLH_Mag#20 from jposada202020/type_annotations

Updating https://github.com/adafruit/Adafruit_CircuitPython_LSM9DS1 to 2.1.19 from 2.1.18:
  > Merge pull request adafruit/Adafruit_CircuitPython_LSM9DS1#36 from tcfranks/main
  > Add upload url to release action
  > Add .venv to .gitignore

Updating https://github.com/adafruit/Adafruit_CircuitPython_PCF8591 to 1.0.14 from 1.0.13:
  > Merge pull request adafruit/Adafruit_CircuitPython_PCF8591#8 from tcfranks/main
  > Add upload url to release action
  > Add .venv to .gitignore

Updating https://github.com/adafruit/Adafruit_CircuitPython_LED_Animation to 2.6.6 from 2.6.4:
  > Merge pull request adafruit/Adafruit_CircuitPython_LED_Animation#110 from tlyu/comet-doc

Updating https://github.com/adafruit/Adafruit_CircuitPython_Bundle/circuitpython_library_list.md to NA from NA:
  > Updated download stats for the libraries

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet