-
Notifications
You must be signed in to change notification settings - Fork 175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Core] Update NDB_Page constructor to include LorisInstance object #7414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Blocked by #7412 |
driusan
added
State: Blocked
PR or issue awaiting an external event such as the merge or another PR to proceed
Cleanup
PR or issue introducing/requiring at least one clean-up operation
labels
Mar 29, 2021
driusan
force-pushed
the
OnlySlightBetterPageConstructor
branch
2 times, most recently
from
March 29, 2021 19:09
5c8c063
to
0736a96
Compare
driusan
force-pushed
the
OnlySlightBetterPageConstructor
branch
from
April 20, 2021 18:41
0736a96
to
51db7b4
Compare
driusan
removed
the
State: Blocked
PR or issue awaiting an external event such as the merge or another PR to proceed
label
Apr 20, 2021
driusan
force-pushed
the
OnlySlightBetterPageConstructor
branch
from
April 22, 2021 18:59
9a54416
to
c3e86e1
Compare
kongtiaowang
approved these changes
Apr 28, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, and passing test
kongtiaowang
added
the
Passed manual tests
PR has been successfully tested by at least one peer
label
Apr 28, 2021
laemtl
pushed a commit
to laemtl/Loris
that referenced
this pull request
Jun 7, 2021
…ces#7414) This updates the NDB_Page constructor to include a LorisInstance object. The LorisInstance object represents the properties of the LorisInstance itself (such as the database connection) and can replace many factory/singleton calls, but is seldom used in LORIS because it's difficult to get a copy of the object. (It needs to be indirectly accessed from a PSR7 request attribute). After moving it to the constructor, it can now be accessed directly from any NDB_Page class or subclass in a simple class property.
AlexandraLivadas
pushed a commit
to AlexandraLivadas/Loris
that referenced
this pull request
Jun 29, 2021
…ces#7414) This updates the NDB_Page constructor to include a LorisInstance object. The LorisInstance object represents the properties of the LorisInstance itself (such as the database connection) and can replace many factory/singleton calls, but is seldom used in LORIS because it's difficult to get a copy of the object. (It needs to be indirectly accessed from a PSR7 request attribute). After moving it to the constructor, it can now be accessed directly from any NDB_Page class or subclass in a simple class property.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Cleanup
PR or issue introducing/requiring at least one clean-up operation
Passed manual tests
PR has been successfully tested by at least one peer
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the NDB_Page constructor to include a LorisInstance object. The LorisInstance object represents the properties of the LorisInstance itself (such as the database connection) and can replace many factory/singleton calls, but is seldom used in LORIS because it's difficult to get a copy of the object. (It needs to be indirectly accessed from a PSR7 request attribute). After moving it to the constructor, it can now be accessed directly from any NDB_Page class or subclass in a simple class property.
I was originally planning to clean up the NDB_Page constructor more by removing unnecessary parameters (why does every page get a CommentID parameter? Why is there both CommentID and identifier? Why does the class need to be told its own name? etc) but simply adding one argument and propagating it to all the places that needed to be updated was already a fairly large PR. This also makes some other cleanup possible, such as moving other statics like
\Module::factory
to$loris->getModule()
but, once again, that would increase the size of this PR more than I'd like.