[data_release] Refactor Module #7412
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
driusan
added
Blocking
kongtiaowang
added
the
Passed manual tests
AlexandraLivadas
pushed a commit
to AlexandraLivadas/Loris
that referenced
this pull request
Jun 29, 2021
This refactors the data release module to get rid of the scripts in the ajax directory, and replace them with real LORIS endpoints that return JSON data. The uploading and downloading is also refactored to use the FilesUploadHandler and FilesDownloadHandler classes instead of custom written PHP validation in the ajax scripts themselves.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This refactors the data release module to get rid of the scripts in the
ajaxdirectory, and replace them with real LORIS endpoints that return JSON data.The uploading and downloading is also refactored to use the
FilesUploadHandlerandFilesDownloadHandlerclasses instead of custom written PHP validation in the ajax scripts themselves.Testing Instructions
The frontend behaviour should be unchanged, so the normal module's test plan should (hopefully?) test all the behaviour..