Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add additional Foundry test coverage #322

Merged
merged 60 commits into from
May 10, 2023
Merged

Add additional Foundry test coverage #322

merged 60 commits into from
May 10, 2023

Conversation

ghost
Copy link

@ghost ghost commented Apr 26, 2023

Will close #319 once complete.

kartojal and others added 28 commits February 14, 2023 16:00
@kartojal
chore: add Foundry initial test environment mocks
fd73e2d
@kartojal
chore: remove mint at test
7aa567d
@kartojal
chore: add tests and borrow fuzz to GhoVariableDebtToken
63e8085
@kartojal
chore: add initial test engine for gho borrow
05df7e1
@kartojal
chore: add percent calc function
d43701c
@miguelmtzinf @kartojal
fix: Remove discount lock period mechanism (#293)
55aa0ca 
* fix: remove discount lock period from GhoDebtToken

* test: Update tests for new rebalance behaviour
@miguelmtzinf @kartojal
fix: Optimize gho debt balanceof (#297)
ecdbc72
@miguelmtzinf @kartojal
fix: Simplify GhoToken.addFacilitator function (#295)
b6ad733 
* fix: Remove Facilitator struct from addFacilitator function

* test: Adjusts test for new addFacilitator parameters

* fix: Make facilitatorLabel calldata-like parameter
@foodaka @kartojal
feat: Add helper contract to manage risk params of GHO reserve (#291)
1dc6f09 
* setup modifier

* setup gho manager and tests

* remove atoken changes

* use interfaces

* adds test for ghomanager as pooladmin
@miguelmtzinf @kartojal
fix: Remove updateLockDiscountPeriod calls from GhoManager (#298)
e878746
@kartojal
chore: initial repay engine
1cdea12
@kartojal
chore: add makefile with coverage html report and ignore mocks, add r…
a789362 
…ebalance discount tests and onbehalf borrow
@kartojal
chore: add 100% coverage for GhoVariableDebtToken contract
28ffe9a
@kartojal
chore: add GhoAToken.sol tests
68d9989
@Zer0dot
fix: Stop prettier formatting dependencies and cache
6bc762b
@Zer0dot
feat: Initial flashminter setup
f1e960b
@Zer0dot
misc: Slight optimisation
4ceddc3
@Zer0dot
test: Add Gho FlashMinter unit tests
cd82952
@Zer0dot
test: Add flash minter unit tests
402271b
fix: Resolve VSCode import callback issue with forge-std/ds-test
dd0314f
test: Add GhoAToken tests for transfer and self-rescue reverts
501c89c
fix: exclude foundry-test for hardhat coverage tests
8e25323
test: Add initial GhoToken unit tests
6c2dbc2
fix: remove stkAave mocks, replace with BGD repo and update impacted …
3e94649 
…tests
Merge branch 'main' into chore/foundry-test-suite
89d1195
fix: resolved error in testUpdateDiscountTokenToZero test
c17e3ba
fix: increase node testrunner heap alloc to avoid OOM
0457b93
fix: setup stkAave behind proxy
66f3f14
@height
Copy link

height bot commented Apr 26, 2023

Link Height tasks by mentioning a task ID in the pull request title or commit messages, or description and comments with the keyword link (e.g. "Link T-123").

💡Tip: You can also use "Close T-X" to automatically close a task when the pull request is merged.

Zer0dot
Zer0dot reviewed May 4, 2023
View reviewed changes
src/contracts/test/TestEmptyDiscountRateStrategy.t.sol Outdated
emptyStrategy = new EmptyDiscountRateStrategy();
}

function testFuzzConstructor(uint256 debtBalance, uint256 discountTokenBalance) public {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be named differently right? Maybe testFuzzRateAlwaysZero or something

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed in subsequent commit

Zer0dot
Zer0dot reviewed May 4, 2023
View reviewed changes
src/contracts/test/TestGhoInterestRateStrategy.t.sol Outdated
import './TestGhoBase.t.sol';

contract TestGhoInterestRateStrategy is TestGhoBase {
function testFuzzConstructor(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here with the naming

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed in subsequent commit

Zer0dot
Zer0dot approved these changes May 5, 2023
View reviewed changes
Copy link
Contributor

@Zer0dot Zer0dot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No further comments here!

Base automatically changed from chore/foundry-test-suite to main May 10, 2023 08:32
@miguelmtzinf miguelmtzinf changed the base branch from main to audit/sigma-prime May 10, 2023 08:45
@miguelmtzinf miguelmtzinf changed the base branch from audit/sigma-prime to main May 10, 2023 08:45
@miguelmtzinf miguelmtzinf mentioned this pull request May 10, 2023
Merged
@miguelmtzinf miguelmtzinf merged commit 31eccec into main May 10, 2023
@miguelmtzinf
Copy link
Contributor

Great stuff @cedephrase @Zer0dot !!

@miguelmtzinf miguelmtzinf deleted the feat/319-additional-foundry-test-coverage branch May 10, 2023 17:48
@miguelmtzinf miguelmtzinf mentioned this pull request Feb 20, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@foodaka foodaka Awaiting requested review from foodaka foodaka is a code owner

@The-3D The-3D Awaiting requested review from The-3D

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add/complete Foundry test coverage
4 participants
@miguelmtzinf @Zer0dot @kartojal @foodaka