-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Optimize gho debt balanceof #297
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miguelmtzinf
requested review from
foodaka,
kartojal,
Zer0dot and
The-3D
as code owners
February 20, 2023 11:28
|
Zer0dot
approved these changes
Feb 20, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
kartojal
approved these changes
Feb 20, 2023
kartojal
pushed a commit
that referenced
this pull request
Feb 22, 2023
miguelmtzinf
added a commit
that referenced
this pull request
May 10, 2023
* chore: add Foundry initial test environment mocks * chore: remove mint at test * chore: add tests and borrow fuzz to GhoVariableDebtToken * chore: add initial test engine for gho borrow * chore: add percent calc function * fix: Remove discount lock period mechanism (#293) * fix: remove discount lock period from GhoDebtToken * test: Update tests for new rebalance behaviour * fix: Optimize gho debt balanceof (#297) * fix: Simplify GhoToken.addFacilitator function (#295) * fix: Remove Facilitator struct from addFacilitator function * test: Adjusts test for new addFacilitator parameters * fix: Make facilitatorLabel calldata-like parameter * feat: Add helper contract to manage risk params of GHO reserve (#291) * setup modifier * setup gho manager and tests * remove atoken changes * use interfaces * adds test for ghomanager as pooladmin * fix: Remove updateLockDiscountPeriod calls from GhoManager (#298) * chore: initial repay engine * chore: add makefile with coverage html report and ignore mocks, add rebalance discount tests and onbehalf borrow * chore: add 100% coverage for GhoVariableDebtToken contract * chore: add GhoAToken.sol tests * fix: Stop prettier formatting dependencies and cache * feat: Initial flashminter setup * misc: Slight optimisation * test: Add Gho FlashMinter unit tests * test: Add flash minter unit tests * fix: Resolve VSCode import callback issue with forge-std/ds-test * test: Add GhoAToken tests for transfer and self-rescue reverts * fix: exclude foundry-test for hardhat coverage tests * test: Add initial GhoToken unit tests * fix: remove stkAave mocks, replace with BGD repo and update impacted tests * fix: resolved error in testUpdateDiscountTokenToZero test * fix: increase node testrunner heap alloc to avoid OOM --------- Co-authored-by: miguelmtz <[email protected]> Co-authored-by: Mark Hinschberger <[email protected]> Co-authored-by: Zer0dot <[email protected]> Co-authored-by: cedephrase <[email protected]>
miguelmtzinf
added a commit
that referenced
this pull request
May 10, 2023
* chore: add Foundry initial test environment mocks * chore: remove mint at test * chore: add tests and borrow fuzz to GhoVariableDebtToken * chore: add initial test engine for gho borrow * chore: add percent calc function * fix: Remove discount lock period mechanism (#293) * fix: remove discount lock period from GhoDebtToken * test: Update tests for new rebalance behaviour * fix: Optimize gho debt balanceof (#297) * fix: Simplify GhoToken.addFacilitator function (#295) * fix: Remove Facilitator struct from addFacilitator function * test: Adjusts test for new addFacilitator parameters * fix: Make facilitatorLabel calldata-like parameter * feat: Add helper contract to manage risk params of GHO reserve (#291) * setup modifier * setup gho manager and tests * remove atoken changes * use interfaces * adds test for ghomanager as pooladmin * fix: Remove updateLockDiscountPeriod calls from GhoManager (#298) * chore: initial repay engine * chore: add makefile with coverage html report and ignore mocks, add rebalance discount tests and onbehalf borrow * chore: add 100% coverage for GhoVariableDebtToken contract * chore: add GhoAToken.sol tests * fix: Stop prettier formatting dependencies and cache * feat: Initial flashminter setup * misc: Slight optimisation * test: Add Gho FlashMinter unit tests * test: Add flash minter unit tests * fix: Resolve VSCode import callback issue with forge-std/ds-test * test: Add GhoAToken tests for transfer and self-rescue reverts * fix: exclude foundry-test for hardhat coverage tests * test: Add initial GhoToken unit tests * fix: remove stkAave mocks, replace with BGD repo and update impacted tests * fix: resolved error in testUpdateDiscountTokenToZero test * fix: increase node testrunner heap alloc to avoid OOM * fix: setup stkAave behind proxy * test: add GhoOracle unit tests * test: add GhoDiscountRateStrategy unit/fuzz tests * test: add GhoInterestRateStrategy fuzz test * test: add GhoManager unit tests, mocked PoolConfigurator * fix: remove unnecessary stopPranks that fail in latest forge * test: added nonce/domain sep unit tests for GhoAToken * test: add GhoStableDebtToken unit tests * feat: add combined coverage from hardhat/foundry * fix: refactor initial foundry tests * fix: move MockFlashBorrower to common location * feat: add EmptyDiscountRateStrategy fuzz test * feat: add UiGhoDataProvider unit tests * feat: complete GhoToken unit tests * feat: complete GhoVariableDebtToken unit tests * feat: add last unit test for GhoVariableDebtToken * fix: update ordering in constant/event test files * fix: remove unnecessary prank on proxy init * fix: naming of fuzz tests to be more descriptive * fix: re-remove old tests that got re-merged * fix: Remove hardhat unitTests folder * fix: Fix constants value of tests * test: Add couple of test cases * test: Rename test titles * fix: Rename EmptyDiscountRateStrategy to ZeroDiscountRateStrategy * fix: Remove unneeded import * feat: add genhtml back to combined coverage * fix: add error messages on test reverts * fix: Fix package scripts * fix: Fix deploy script of GhoStableDebtToken --------- Co-authored-by: David Racero <[email protected]> Co-authored-by: miguelmtz <[email protected]> Co-authored-by: Mark Hinschberger <[email protected]> Co-authored-by: Zer0dot <[email protected]> Co-authored-by: miguelmtzinf <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #296