Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove discount lock period mechanism #293

Merged
merged 2 commits into from
Feb 20, 2023
Merged

Remove discount lock period mechanism #293

merged 2 commits into from
Feb 20, 2023

Conversation

miguelmtzinf
Copy link
Contributor

Closes #268

@height
Copy link

height bot commented Feb 17, 2023

Link Height tasks by mentioning a task ID in the pull request title or commit messages, or description and comments with the keyword link (e.g. "Link T-123").

💡Tip: You can also use "Close T-X" to automatically close a task when the pull request is merged.

Zer0dot
Zer0dot approved these changes Feb 17, 2023
View reviewed changes
Copy link
Contributor

@Zer0dot Zer0dot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@miguelmtzinf miguelmtzinf merged commit 81bb51b into main Feb 20, 2023
@miguelmtzinf miguelmtzinf deleted the fix/268-discount-lock-period-removal branch February 20, 2023 16:59
@miguelmtzinf miguelmtzinf mentioned this pull request Feb 20, 2023
Merged
kartojal pushed a commit that referenced this pull request Feb 22, 2023
@miguelmtzinf @kartojal
fix: Remove discount lock period mechanism (#293)
55aa0ca 
* fix: remove discount lock period from GhoDebtToken

* test: Update tests for new rebalance behaviour
miguelmtzinf added a commit that referenced this pull request May 10, 2023
@kartojal @miguelmtzinf
@foodaka @Zer0dot
chore: add Foundry initial test environment mocks (#289)
639031f 
* chore: add Foundry initial test environment mocks

* chore: remove mint at test

* chore: add tests and borrow fuzz to GhoVariableDebtToken

* chore: add initial test engine for gho borrow

* chore: add percent calc function

* fix: Remove discount lock period mechanism (#293)

* fix: remove discount lock period from GhoDebtToken

* test: Update tests for new rebalance behaviour

* fix: Optimize gho debt balanceof (#297)

* fix: Simplify GhoToken.addFacilitator function (#295)

* fix: Remove Facilitator struct from addFacilitator function

* test: Adjusts test for new addFacilitator parameters

* fix: Make facilitatorLabel calldata-like parameter

* feat: Add helper contract to manage risk params of GHO reserve (#291)

* setup modifier

* setup gho manager and tests

* remove atoken changes

* use interfaces

* adds test for ghomanager as pooladmin

* fix: Remove updateLockDiscountPeriod calls from GhoManager (#298)

* chore: initial repay engine

* chore: add makefile with coverage html report and ignore mocks, add rebalance discount tests and onbehalf borrow

* chore: add 100% coverage for GhoVariableDebtToken contract

* chore: add GhoAToken.sol tests

* fix: Stop prettier formatting dependencies and cache

* feat: Initial flashminter setup

* misc: Slight optimisation

* test: Add Gho FlashMinter unit tests

* test: Add flash minter unit tests

* fix: Resolve VSCode import callback issue with forge-std/ds-test

* test: Add GhoAToken tests for transfer and self-rescue reverts

* fix: exclude foundry-test for hardhat coverage tests

* test: Add initial GhoToken unit tests

* fix: remove stkAave mocks, replace with BGD repo and update impacted tests

* fix: resolved error in testUpdateDiscountTokenToZero test

* fix: increase node testrunner heap alloc to avoid OOM

---------

Co-authored-by: miguelmtz <[email protected]>
Co-authored-by: Mark Hinschberger <[email protected]>
Co-authored-by: Zer0dot <[email protected]>
Co-authored-by: cedephrase <[email protected]>
miguelmtzinf added a commit that referenced this pull request May 10, 2023
@kartojal @miguelmtzinf
@foodaka @Zer0dot
test: Add additional Foundry test coverage (#322)
31eccec 
* chore: add Foundry initial test environment mocks

* chore: remove mint at test

* chore: add tests and borrow fuzz to GhoVariableDebtToken

* chore: add initial test engine for gho borrow

* chore: add percent calc function

* fix: Remove discount lock period mechanism (#293)

* fix: remove discount lock period from GhoDebtToken

* test: Update tests for new rebalance behaviour

* fix: Optimize gho debt balanceof (#297)

* fix: Simplify GhoToken.addFacilitator function (#295)

* fix: Remove Facilitator struct from addFacilitator function

* test: Adjusts test for new addFacilitator parameters

* fix: Make facilitatorLabel calldata-like parameter

* feat: Add helper contract to manage risk params of GHO reserve (#291)

* setup modifier

* setup gho manager and tests

* remove atoken changes

* use interfaces

* adds test for ghomanager as pooladmin

* fix: Remove updateLockDiscountPeriod calls from GhoManager (#298)

* chore: initial repay engine

* chore: add makefile with coverage html report and ignore mocks, add rebalance discount tests and onbehalf borrow

* chore: add 100% coverage for GhoVariableDebtToken contract

* chore: add GhoAToken.sol tests

* fix: Stop prettier formatting dependencies and cache

* feat: Initial flashminter setup

* misc: Slight optimisation

* test: Add Gho FlashMinter unit tests

* test: Add flash minter unit tests

* fix: Resolve VSCode import callback issue with forge-std/ds-test

* test: Add GhoAToken tests for transfer and self-rescue reverts

* fix: exclude foundry-test for hardhat coverage tests

* test: Add initial GhoToken unit tests

* fix: remove stkAave mocks, replace with BGD repo and update impacted tests

* fix: resolved error in testUpdateDiscountTokenToZero test

* fix: increase node testrunner heap alloc to avoid OOM

* fix: setup stkAave behind proxy

* test: add GhoOracle unit tests

* test: add GhoDiscountRateStrategy unit/fuzz tests

* test: add GhoInterestRateStrategy fuzz test

* test: add GhoManager unit tests, mocked PoolConfigurator

* fix: remove unnecessary stopPranks that fail in latest forge

* test: added nonce/domain sep unit tests for GhoAToken

* test: add GhoStableDebtToken unit tests

* feat: add combined coverage from hardhat/foundry

* fix: refactor initial foundry tests

* fix: move MockFlashBorrower to common location

* feat: add EmptyDiscountRateStrategy fuzz test

* feat: add UiGhoDataProvider unit tests

* feat: complete GhoToken unit tests

* feat: complete GhoVariableDebtToken unit tests

* feat: add last unit test for GhoVariableDebtToken

* fix: update ordering in constant/event test files

* fix: remove unnecessary prank on proxy init

* fix: naming of fuzz tests to be more descriptive

* fix: re-remove old tests that got re-merged

* fix: Remove hardhat unitTests folder

* fix: Fix constants value of tests

* test: Add couple of test cases

* test: Rename test titles

* fix: Rename EmptyDiscountRateStrategy to ZeroDiscountRateStrategy

* fix: Remove unneeded import

* feat: add genhtml back to combined coverage

* fix: add error messages on test reverts

* fix: Fix package scripts

* fix: Fix deploy script of GhoStableDebtToken

---------

Co-authored-by: David Racero <[email protected]>
Co-authored-by: miguelmtz <[email protected]>
Co-authored-by: Mark Hinschberger <[email protected]>
Co-authored-by: Zer0dot <[email protected]>
Co-authored-by: miguelmtzinf <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Zer0dot Zer0dot Zer0dot approved these changes

@kartojal kartojal kartojal approved these changes

@foodaka foodaka Awaiting requested review from foodaka foodaka is a code owner

@The-3D The-3D Awaiting requested review from The-3D

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The discount lock-period of user can be bypassed by executing balance-changing actions
3 participants
@miguelmtzinf @Zer0dot @kartojal