fix(ui): show tool name in approval prompt - #9216
Conversation
The standalone tool confirmation dialog said 'Do you allow this tool call?' without identifying which tool. The toolName was available in the data but never rendered. Now the prompt shows the formatted tool name so users know what they're approving. Fixes #8072 Signed-off-by: Douwe Osinga <douwe@squareup.com>
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: bff52a0637
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| id: 'toolConfirmation.allowToolCallWithName', | ||
| defaultMessage: 'Allow {toolName}?', | ||
| }, | ||
| gooseWouldLikeToCall: { | ||
| id: 'toolConfirmation.gooseWouldLikeToCall', | ||
| defaultMessage: 'Goose would like to call the above tool. Allow?', | ||
| gooseWouldLikeToCallWithName: { | ||
| id: 'toolConfirmation.gooseWouldLikeToCallWithName', |
There was a problem hiding this comment.
Changing these react-intl IDs introduces a localization regression for non-English users: zh-CN currently defines translations for toolConfirmation.allowToolCall and toolConfirmation.gooseWouldLikeToCall, but not for the new ...WithName IDs, so the confirmation header falls back to English in Chinese locale. This commit should either keep the existing IDs (and update message text shape compatibly) or add the new IDs to locale catalogs before switching.
Useful? React with 👍 / 👎.
Signed-off-by: Douwe Osinga <douwe@squareup.com>
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 87fd0e8c59
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| id: 'toolConfirmation.allowToolCallWithName', | ||
| defaultMessage: 'Allow {toolName}?', | ||
| }, | ||
| gooseWouldLikeToCall: { | ||
| id: 'toolConfirmation.gooseWouldLikeToCall', | ||
| defaultMessage: 'Goose would like to call the above tool. Allow?', | ||
| gooseWouldLikeToCallWithName: { | ||
| id: 'toolConfirmation.gooseWouldLikeToCallWithName', |
There was a problem hiding this comment.
Switching to new IDs (toolConfirmation.allowToolCallWithName / ...gooseWouldLikeToCallWithName) introduces a localization regression because only en.json defines those keys, while zh-CN.json still contains only the old IDs (toolConfirmation.allowToolCall and toolConfirmation.gooseWouldLikeToCall). In non-English locales, this causes the confirmation header to fall back to English instead of the translated strings whenever this prompt is shown.
Useful? React with 👍 / 👎.
…d keys Signed-off-by: Douwe Osinga <douwe@squareup.com>
* main: (102 commits) Dynamically refresh skill instructions each turn (#9217) Build non-vulkan linux variants using ubuntu 22.04 (#9211) fix(ui): show tool name in approval prompt (#9216) feat: add Atomic Chat as declarative OpenAI-compatible provider (#9210) chore: bump package.json versions from 0.19.1 to 0.20.0 (#9218) feat: support GOOSE_OAUTH_CALLBACK_PORT for stable OAuth redirect_uri (#9209) [RFC] feat(oauth): proactive token refresh to avoid re-auth on every session (#8386) fix: resolve Azure CLI on Windows by using az.cmd (#9215) fix: handle non-interactive terminal in goose configure on Windows (#9214) Better parsing of pasted html as markdown so agents understand (#9190) fix: persist accumulated cost in session DB to survive reload (#9191) fix(publish-npm): build binary from current SHA + add compat check (#9212) feat(desktop): add goose://new-session deep link to open fresh chat (#9196) Add PR previews using cloudflare pages (#9208) fix: prevent tool-use marker leakage in toolshim output (#8310) Prompt injection mitigation: update pattern-based detection (#9198) remove goose2 related skills (#9189) Switch GH pages deploy to actions/artifact workflow (#9025) fix(summon): re-apply canonical limits when delegate overrides model (#9183) Split code signing from build (#8587) ...
Signed-off-by: Douwe Osinga <douwe@squareup.com> Co-authored-by: Douwe Osinga <douwe@squareup.com>
3 participants
The standalone tool confirmation dialog said "Do you allow this tool call?" without identifying which tool. The
toolNamewas available in the data but never rendered.Now the prompt shows the formatted tool name (e.g. "Goose would like to call Shell. Allow?") so users know what they're approving.
When there's a custom prompt, it shows "Allow Shell?" instead of the generic "Do you allow this tool call?".
Fixes #8072