fix: persist accumulated cost in session DB to survive reload - #9191
Merged
Conversation
Compute cost at the time tokens are generated (when we know which model produced them), accumulate it in a new accumulated_cost column on the sessions table, and expose it via TokenState to the frontend. The frontend CostTracker now uses the backend-persisted cost directly, which correctly accounts for model switches. The ephemeral client-side useCostTracking hook (which lost state on reload) is removed. Fixes #6141 Signed-off-by: Douwe Osinga <douwe@squareup.com>
jamadeo
reviewed
May 14, 2026
| const total = inputCost + outputCost; | ||
|
|
||
| return total; | ||
| return inputCost + outputCost; |
Member
There was a problem hiding this comment.
shouldn't we move this part to goosed too? and get rid of all calculation on the client?
DOsinga
force-pushed
the
fix/persist-accumulated-cost
branch
from
May 14, 2026 16:06
d658151 to
7bb8e38
Compare
Address review feedback: the client-side fallback calculation was dead code since the backend and frontend use the same pricing data. Simplify calculateCost to just return the backend accumulated cost. Signed-off-by: Douwe Osinga <douwe@squareup.com>
DOsinga
force-pushed
the
fix/persist-accumulated-cost
branch
from
May 14, 2026 16:24
7bb8e38 to
c212334
Compare
jamadeo
approved these changes
May 14, 2026
lifeizhou-ap
added a commit
that referenced
this pull request
May 15, 2026
* main: (102 commits) Dynamically refresh skill instructions each turn (#9217) Build non-vulkan linux variants using ubuntu 22.04 (#9211) fix(ui): show tool name in approval prompt (#9216) feat: add Atomic Chat as declarative OpenAI-compatible provider (#9210) chore: bump package.json versions from 0.19.1 to 0.20.0 (#9218) feat: support GOOSE_OAUTH_CALLBACK_PORT for stable OAuth redirect_uri (#9209) [RFC] feat(oauth): proactive token refresh to avoid re-auth on every session (#8386) fix: resolve Azure CLI on Windows by using az.cmd (#9215) fix: handle non-interactive terminal in goose configure on Windows (#9214) Better parsing of pasted html as markdown so agents understand (#9190) fix: persist accumulated cost in session DB to survive reload (#9191) fix(publish-npm): build binary from current SHA + add compat check (#9212) feat(desktop): add goose://new-session deep link to open fresh chat (#9196) Add PR previews using cloudflare pages (#9208) fix: prevent tool-use marker leakage in toolshim output (#8310) Prompt injection mitigation: update pattern-based detection (#9198) remove goose2 related skills (#9189) Switch GH pages deploy to actions/artifact workflow (#9025) fix(summon): re-apply canonical limits when delegate overrides model (#9183) Split code signing from build (#8587) ...
shafqatevo
pushed a commit
to shafqatevo/goose
that referenced
this pull request
Aug 7, 2026
…oose#9191) Signed-off-by: Douwe Osinga <douwe@squareup.com> Co-authored-by: Douwe Osinga <douwe@squareup.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #6141
When users switch models mid-session, the cost tracking was computed client-side in an ephemeral React hook (
useCostTracking). On session reload (page refresh), this in-memory state was lost and cost was incorrectly recalculated using the current model's pricing against all accumulated tokens.Fix
Compute cost at the time tokens are generated (when we know which model produced them), persist it in a new
accumulated_costcolumn on the sessions table, and expose it viaTokenStateto the frontend.Backend:
accumulated_cost(f64) column to sessions table (schema v13)update_session_metrics, compute the cost for each usage chunk using the canonical model pricing for the model that generated those tokens, and accumulate itaccumulated_costinTokenStateSSE eventsFrontend:
CostTrackernow uses the backend-persistedaccumulatedCostdirectlyuseCostTrackinghook that lost state on reloadType of Change
Testing