fix(publish-npm): build binary from current SHA + add compat check - #9212
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 11393011ae
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
1139301 to
04e05a7
Compare
Signed-off-by: Alex Hancock <alexhancock@block.xyz>
04e05a7 to
1b53698
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1b53698cfb
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| build: | ||
| name: Build npm packages | ||
| runs-on: ubuntu-latest | ||
| needs: [build-cli] |
There was a problem hiding this comment.
This change makes build depend on the reusable build-cli workflow, and that reusable workflow includes a Windows CUDA matrix entry (variant: cuda) with no continue-on-error; however, this publish flow only consumes the non-CUDA artifact (goose-x86_64-pc-windows-msvc) when populating ui/goose-binary. The result is that a CUDA-only failure (toolchain/install flake) will fail build-cli and block npm publishing even though none of the published npm packages use the CUDA artifact.
Useful? React with 👍 / 👎.
* main: (102 commits) Dynamically refresh skill instructions each turn (#9217) Build non-vulkan linux variants using ubuntu 22.04 (#9211) fix(ui): show tool name in approval prompt (#9216) feat: add Atomic Chat as declarative OpenAI-compatible provider (#9210) chore: bump package.json versions from 0.19.1 to 0.20.0 (#9218) feat: support GOOSE_OAUTH_CALLBACK_PORT for stable OAuth redirect_uri (#9209) [RFC] feat(oauth): proactive token refresh to avoid re-auth on every session (#8386) fix: resolve Azure CLI on Windows by using az.cmd (#9215) fix: handle non-interactive terminal in goose configure on Windows (#9214) Better parsing of pasted html as markdown so agents understand (#9190) fix: persist accumulated cost in session DB to survive reload (#9191) fix(publish-npm): build binary from current SHA + add compat check (#9212) feat(desktop): add goose://new-session deep link to open fresh chat (#9196) Add PR previews using cloudflare pages (#9208) fix: prevent tool-use marker leakage in toolshim output (#8310) Prompt injection mitigation: update pattern-based detection (#9198) remove goose2 related skills (#9189) Switch GH pages deploy to actions/artifact workflow (#9025) fix(summon): re-apply canonical limits when delegate overrides model (#9183) Split code signing from build (#8587) ...
…aif-goose#9212) Signed-off-by: Alex Hancock <alexhancock@block.xyz>
2 participants
Summary
publish-npm.ymlbuilt the TUI/SDK from the current SHA but downloaded the Rust binary from an arbitrary release tag. When those drifted, the published bundle launched into a Zod "Setup error" (e.g.0.19.1shipped a client expectingProviderInventoryEntryDto.categoryagainst av1.33.1binary that predates the field).This PR makes
publish-npmbuild the binary from the same checkout viabuild-cli.yml, and adds a compat smoke test that boots the fresh binary and Zod-validates every read-only ACP response before publish.Testing
GOOSE_BINARY=… pnpm --filter @aaif/goose-sdk run check:compat.publish-npmwithdry-run: trueafter merge.Related Issues
N/A