feat: open-plugins generalization + skills by alexhancock · Pull Request #9112 · aaif-goose/goose

alexhancock · 2026-05-08T18:48:42Z

Summary

Adding an adapted version of @jamadeo's changes from plugins: add open plugins (just skills for now) #9063
Our open-plugins setup now supports skills and hooks in plugins

Testing

TODO

Related Issues

N/A

Screenshots/Demos (for UX changes)

TODO

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: fea1c7c20d

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector · 2026-05-11T13:18:57Z

+    if let Ok(test_root) = std::env::var("GOOSE_PATH_ROOT") {
+        return Some(
+            PathBuf::from(test_root)
+                .join(".config")
+                .join("goose")


Load plugin settings from the shared config path

user_settings_path now hard-codes ~/.config/goose/settings.json (and <GOOSE_PATH_ROOT>/.config/goose/settings.json) instead of using the app’s canonical config resolver (Paths::config_dir() / Paths::in_config_dir). This breaks settings lookup in environments that rely on GOOSE_PATH_ROOT (which maps config to <root>/config) and on non-Linux platforms where Goose config is not under ~/.config, so enabledPlugins/disabledPlugins are silently ignored.

Useful? React with 👍 / 👎.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: e07bd601ff

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector · 2026-05-11T16:55:30Z

+    for entry in fs::read_dir(skill_root)? {
+        let entry = entry?;
+        let path = entry.path();
+        if path.is_dir() {
+            collect_skill_candidate(plugin_dir, &path, skills)?;


Recurse through nested skill directories before namespacing

collect_skill_candidates only inspects skill_root and its immediate child directories, so SKILL.md files nested deeper (for example skills/lang/rust/SKILL.md) are skipped during install. Those deeper skills are still discoverable at runtime because skill loading walks directories recursively in crates/goose/src/skills/mod.rs, which means they are loaded without rewrite_skill_name applying the plugin namespace and may collide with non-plugin skill names. This also makes PluginInstall.skills incomplete for plugins that organize skills hierarchically.

Useful? React with 👍 / 👎.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: d9c4adff44

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector · 2026-05-12T15:31:19Z

+            let default_skills_dir = plugin_dir.join("skills");
+            if default_skills_dir.is_dir() {
+                skill_dirs.push(default_skills_dir);
+            }
+            skill_dirs.extend(formats::open_plugins::installed_skill_dirs(&plugin_dir));


Respect Open Plugins exclusive skills setting

Do not always include plugins/<name>/skills in global skill discovery. The new Open Plugins manifest parsing supports skills.exclusive=true and custom skill roots, but this unconditional push still scans the default skills/ directory, so plugins that intentionally opt out can have unintended or un-namespaced skills loaded (and potentially collide with namespaced ones). This is observable whenever a plugin ships both a legacy skills/ tree and an exclusive custom path.

Useful? React with 👍 / 👎.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: a8e4c5ced8

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector · 2026-05-19T18:30:27Z

+    let has_component = has_component_marker(checkout_dir);

-    if !has_manifest && !has_hooks {
+    if !has_manifest && !has_component {
        return Err(FormatNotSupported.into());


Restrict Open Plugins marker detection before install

try_install_from_manifest_at_root now claims Open Plugins format whenever commands/ or agents/ exists, even without an Open Plugins manifest. Because install_from_checkout_at_root tries Open Plugins first and only falls back on FormatNotSupported, any other Open-only validation error here prevents the Gemini installer from running. A valid Gemini extension that includes commands/ can therefore fail goose plugins install (for example when inferred Open Plugin name validation fails), which is a regression from the previous format detection behavior.

Useful? React with 👍 / 👎.

Co-authored-by: Jack Amadeo <jackamadeo@block.xyz>

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 7e017fc725

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector · 2026-05-19T19:11:19Z

+    if !has_manifest && !has_component {
        return Err(FormatNotSupported.into());


Reject manifest-only repos without plugin components

try_install_from_manifest_at_root now treats any repo with an Open Plugins manifest as installable even when it has no plugin components, because the guard only checks !has_manifest && !has_component and install_from_manifest no longer enforces skills/hooks presence. In this case goose plugins install succeeds but installs an inert plugin, which is a regression from fail-fast behavior and makes accidental installs of non-plugin repos with a plugin.json much harder to detect.

Useful? React with 👍 / 👎.

* main: (70 commits) Feat/summon subagent instructions (#9325) feat: open-plugins generalization + skills (#9112) feat(hooks): PreToolUse denial (#9304) Add support for optional api_key configuration for declarative openai-engine providers (#9202) fix(cli): use plain '> ' prompt instead of goose emoji (#9305) flag for login shell PATH (#9313) Remove popular chat topics from new chat screen (#9307) fix: stop killing goosed when a window closes (#9302) Remove vendored Windows binaries (#9318) Add Linux musl CLI builds (#9240) feat(acp): paginate session list (#9199) docs: reorganize (#9310) Structured per-provider config block, non-destructive provider switching (#8977) feat(cli): add `goose review` local code review command (#9114) feat(tui): diff viewer (#9260) fix(otel): emit trace_output as span attribute instead of event (#9255) docs: add guide for connecting goose Desktop to a remote goosed server (#9275) fix(config): check file fallback when keyring has no entry (#9279) fix(desktop): ScheduleModal error message styling (#9278) fix(ui): align sidebar hamburger in macOS fullscreen (#9257) ...

* main: (38 commits) [Prompt injection mitigation] Update pattern-based detection to reduce FPs (#9350) feat: add Harbor eval runner (#9138) chore(release): bump version to 1.35.0 (minor) (#9150) Include request URL in provider error messages (#9232) fix(databricks): ensure parallel tool image responses don't interleave tool results (#9241) Surface resolved Databricks model metadata (#9206) Add unified thinking effort control across all providers (#9242) Add Linux desktop Vulkan packages (#9323) chore: update canonical model registry (#9331) feat: slash commands (built-in, skill, recipe) in acp server (#9238) feat: add /goal command for agent self-evaluation before finishing (#9069) Feat/summon subagent instructions (#9325) feat: open-plugins generalization + skills (#9112) feat(hooks): PreToolUse denial (#9304) Add support for optional api_key configuration for declarative openai-engine providers (#9202) fix(cli): use plain '> ' prompt instead of goose emoji (#9305) flag for login shell PATH (#9313) Remove popular chat topics from new chat screen (#9307) fix: stop killing goosed when a window closes (#9302) Remove vendored Windows binaries (#9318) ...

Co-authored-by: Jack Amadeo <jackamadeo@block.xyz>

alexhancock requested a review from jamadeo May 8, 2026 18:48

alexhancock mentioned this pull request May 8, 2026

feat: lifecycle hooks system #8842

Closed

alexhancock force-pushed the alexhancock/hooks-and-skills branch from 7c988d6 to fea1c7c Compare May 8, 2026 18:58

alexhancock marked this pull request as ready for review May 11, 2026 13:14

alexhancock force-pushed the alexhancock/hooks branch from 6626ed7 to efed233 Compare May 11, 2026 13:18

alexhancock force-pushed the alexhancock/hooks-and-skills branch from fea1c7c to bcb1880 Compare May 11, 2026 13:18

chatgpt-codex-connector Bot reviewed May 11, 2026

View reviewed changes

Base automatically changed from alexhancock/hooks to main May 11, 2026 16:16

alexhancock force-pushed the alexhancock/hooks-and-skills branch from bcb1880 to e07bd60 Compare May 11, 2026 16:51

chatgpt-codex-connector Bot reviewed May 11, 2026

View reviewed changes

alexhancock force-pushed the alexhancock/hooks-and-skills branch from e07bd60 to d9c4adf Compare May 12, 2026 15:23

chatgpt-codex-connector Bot reviewed May 12, 2026

View reviewed changes

jamadeo approved these changes May 12, 2026

View reviewed changes

DOsinga added the needs_human label to set when a robot looks at a PR and can't handle it label May 12, 2026

DOsinga mentioned this pull request May 14, 2026

🧭 UX Proposal: Make Agents / Workflows / Marketplace First-Class (Clean Minimal Navigation + Prompt Bar) #6850

Closed

alexhancock force-pushed the alexhancock/hooks-and-skills branch from d9c4adf to a8e4c5c Compare May 19, 2026 18:26

chatgpt-codex-connector Bot reviewed May 19, 2026

View reviewed changes

feat: open-plugins generalization + skills

7e017fc

Co-authored-by: Jack Amadeo <jackamadeo@block.xyz>

alexhancock force-pushed the alexhancock/hooks-and-skills branch from a8e4c5c to 7e017fc Compare May 19, 2026 19:07

chatgpt-codex-connector Bot reviewed May 19, 2026

View reviewed changes

alexhancock added this pull request to the merge queue May 19, 2026

Merged via the queue into main with commit 20a832a May 19, 2026
23 checks passed

alexhancock deleted the alexhancock/hooks-and-skills branch May 19, 2026 21:16

github-actions Bot mentioned this pull request May 20, 2026

chore(release): release version 1.35.0 #9346

Closed

BrewTestBot mentioned this pull request Jul 2, 2026

block-goose-cli 1.40.0 Homebrew/homebrew-core#290949

Merged

shafqatevo pushed a commit to shafqatevo/goose that referenced this pull request Aug 7, 2026

feat: open-plugins generalization + skills (aaif-goose#9112)

d708138

Co-authored-by: Jack Amadeo <jackamadeo@block.xyz>

BrewTestBot mentioned this pull request Aug 12, 2026

block-goose-cli 1.46.0 Homebrew/homebrew-core#298471

Merged

Navigation Menu

Uh oh!

feat: open-plugins generalization + skills - #9112

feat: open-plugins generalization + skills#9112
alexhancock merged 1 commit into
mainfrom
alexhancock/hooks-and-skills

alexhancock commented May 8, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Uh oh!

chatgpt-codex-connector Bot May 11, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Uh oh!

chatgpt-codex-connector Bot May 11, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Uh oh!

chatgpt-codex-connector Bot May 12, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Uh oh!

chatgpt-codex-connector Bot May 19, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Uh oh!

chatgpt-codex-connector Bot May 19, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

		if !has_manifest && !has_component {
		return Err(FormatNotSupported.into());

Uh oh!

Conversation

alexhancock commented May 8, 2026

Summary

Testing

Related Issues

Screenshots/Demos (for UX changes)

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot May 11, 2026

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot May 11, 2026

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot May 12, 2026

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot May 19, 2026

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot May 19, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants