fix(desktop): ScheduleModal error message styling - #9278
Merged
Conversation
The ScheduleModal had the error messages styled with danger border, background and text. This meant that the messages were not able to be seen due to the red-on-red. This has been addressed by removing the danger background style so that only the text is styled. Additionally, the schedule name and source fields have been marked up in a similar way to the CreateRecipe modal. Required fields have an explicit asterix `*` to give a visual indicator that they are required. Signed-off-by: SteveO <steve.officer@gmail.com>
steveofficer
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the desktop Schedule modal UI to improve error readability and align required-field labeling with other modals (e.g., the recipe creation flow).
Changes:
- Removes the “danger” background styling from Schedule modal error messages to avoid red-on-red unreadable text.
- Adds explicit required-field asterisks to the Schedule name and Source labels for clearer UX consistency.
Comment on lines
+242
to
+244
| <label className={modalLabelClassName}> | ||
| {intl.formatMessage(i18n.sourceLabel)} <span className="text-red-500">*</span> | ||
| </label> |
steveofficer
changed the title
michaelneale
added a commit
that referenced
this pull request
May 19, 2026
* origin/main: (160 commits) Add Linux musl CLI builds (#9240) feat(acp): paginate session list (#9199) docs: reorganize (#9310) Structured per-provider config block, non-destructive provider switching (#8977) feat(cli): add `goose review` local code review command (#9114) feat(tui): diff viewer (#9260) fix(otel): emit trace_output as span attribute instead of event (#9255) docs: add guide for connecting goose Desktop to a remote goosed server (#9275) fix(config): check file fallback when keyring has no entry (#9279) fix(desktop): ScheduleModal error message styling (#9278) fix(ui): align sidebar hamburger in macOS fullscreen (#9257) Add documentation for new provider SaladCloud AI Gateway (#9253) fix: use current_exe() instead of PATH lookup when spawning goose (#9236) fix(extension_manager): set TCP_USER_TIMEOUT on streamable HTTP clients (#9207) fix: activate custom provider after adding via configure (#9213) Flush OTLP traces reliably on exit with configurable timeout (#9228) fix: reduce excessive MISSING_TRANSLATION warnings for fallback locales (#9294) feat(acp): pass session cwd param to acp providers (#9229) fix(desktop): eliminate cross-window deep link contamination (#9273) fix: improve Telegram gateway error reporting and connection reliability (#9223) ... Signed-off-by: Michael Neale <michael.neale@gmail.com> # Conflicts: # crates/goose/src/agents/agent.rs # crates/goose/tests/agent.rs
lifeizhou-ap
added a commit
that referenced
this pull request
May 20, 2026
* main: (70 commits) Feat/summon subagent instructions (#9325) feat: open-plugins generalization + skills (#9112) feat(hooks): PreToolUse denial (#9304) Add support for optional api_key configuration for declarative openai-engine providers (#9202) fix(cli): use plain '> ' prompt instead of goose emoji (#9305) flag for login shell PATH (#9313) Remove popular chat topics from new chat screen (#9307) fix: stop killing goosed when a window closes (#9302) Remove vendored Windows binaries (#9318) Add Linux musl CLI builds (#9240) feat(acp): paginate session list (#9199) docs: reorganize (#9310) Structured per-provider config block, non-destructive provider switching (#8977) feat(cli): add `goose review` local code review command (#9114) feat(tui): diff viewer (#9260) fix(otel): emit trace_output as span attribute instead of event (#9255) docs: add guide for connecting goose Desktop to a remote goosed server (#9275) fix(config): check file fallback when keyring has no entry (#9279) fix(desktop): ScheduleModal error message styling (#9278) fix(ui): align sidebar hamburger in macOS fullscreen (#9257) ...
shafqatevo
pushed a commit
to shafqatevo/goose
that referenced
this pull request
Aug 7, 2026
Signed-off-by: SteveO <steve.officer@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The ScheduleModal had the error messages styled with danger border, background and text. This meant that the messages were not able to be seen due to the red-on-red.
This has been addressed by removing the danger background style so that only the text is styled.
Additionally, the schedule name and source fields have been marked up in a similar way to the CreateRecipe modal. Required fields have an explicit asterix
*to give a visual indicator that they are required.Testing
This has been manually tested.
Related Issues
Relates to #ISSUE_ID
Discussion: LINK (if any)
Screenshots/Demos (for UX changes)
Before:
No visual indicator
Unreadable error text
After:
Visual indicator added to labels
Error message styling fixed
