Skip to content

chore: update canonical model registry - #9331

Merged
michaelneale merged 2 commits into
aaif-goose:mainfrom
baxen:baxen/update-canonical-models-gemini-35
May 20, 2026
Merged

chore: update canonical model registry#9331
michaelneale merged 2 commits into
aaif-goose:mainfrom
baxen:baxen/update-canonical-models-gemini-35

Conversation

@baxen

@baxen baxen commented May 19, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Regenerate canonical model registry from models.dev
  • Update provider metadata snapshot
  • Includes newly available Gemini entries such as google/gemini-3.5-flash

Validation

  • source bin/activate-hermit && just build-canonical-models
  • cargo fmt
  • jq empty crates/goose/src/providers/canonical/data/canonical_models.json
  • jq empty crates/goose/src/providers/canonical/data/provider_metadata.json

@baxen
chore: update canonical model registry
18ea91e 
Signed-off-by: Bradley Axen <baxen@squareup.com>
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented May 19, 2026

Copy link
Copy Markdown

💡 Codex Review

https://github.com/aaif-goose/goose/blob/18ea91e72f76d2a07fcf499d5309dcf506819f7e/crates/goose/src/providers/canonical/data/canonical_models.json#L12826
P2 Badge Preserve canonical entry for advertised Bedrock Sonnet 4 model

BEDROCK_KNOWN_MODELS still includes us.anthropic.claude-sonnet-4-20250514-v1:0 (crates/goose/src/providers/bedrock.rs), but this update replaces that canonical ID with newer Sonnet variants in canonical_models.json. For aws_bedrock, map_to_canonical_model first does exact provider/model lookup, so this known model now resolves to no canonical record and ModelConfig::with_canonical_limits cannot apply the model’s canonical limits/capabilities for that user-selected model. This is a regression from the previous snapshot where this exact Bedrock ID existed.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

DOsinga
DOsinga approved these changes May 19, 2026
View reviewed changes

@DOsinga DOsinga left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is supposed to run when we do a new release automatically but no harm in merging it before. also we should do a release

@baxen
Fix canonical model tests after registry update
6cdd8a2 
Signed-off-by: Bradley Axen <baxen@squareup.com>
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented May 20, 2026

Copy link
Copy Markdown

💡 Codex Review

https://github.com/aaif-goose/goose/blob/6cdd8a28ab508858a3a3c99acd074be0f9481055/crates/goose/src/providers/canonical/data/canonical_models.json#L5126
P2 Badge Preserve legacy AIHubMix DeepSeek model IDs

Renaming aihubmix/deepseek-v4-flash and aihubmix/deepseek-v4-pro to aihubmix/deep-deepseek-* removes the exact IDs that existing configs were using in the previous registry snapshot, but no alias entries were kept. With the current lookup flow, old names no longer resolve to AIHubMix entries and can fall back to the generic deepseek/* records, which changes provider-specific metadata (notably pricing) for the same configured model string. Keep backward-compatible aliases (or duplicate entries) for the old IDs to avoid silent behavior changes for existing users.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@michaelneale
michaelneale added this pull request to the merge queue May 20, 2026
Merged via the queue into aaif-goose:main with commit 7a53017 May 20, 2026
22 checks passed
@github-actions github-actions Bot mentioned this pull request May 20, 2026
Closed
lifeizhou-ap added a commit that referenced this pull request May 22, 2026
@lifeizhou-ap
Merge branch 'main' into lifei/acp-session-ui-desktop
52265c7 
* main: (38 commits)
  [Prompt injection mitigation] Update pattern-based detection to reduce FPs (#9350)
  feat: add Harbor eval runner (#9138)
  chore(release): bump version to 1.35.0 (minor) (#9150)
  Include request URL in provider error messages (#9232)
  fix(databricks): ensure parallel tool image responses don't interleave tool results (#9241)
  Surface resolved Databricks model metadata (#9206)
  Add unified thinking effort control across all providers (#9242)
  Add Linux desktop Vulkan packages (#9323)
  chore: update canonical model registry (#9331)
  feat: slash commands (built-in, skill, recipe) in acp server (#9238)
  feat: add /goal command for agent self-evaluation before finishing (#9069)
  Feat/summon subagent instructions (#9325)
  feat: open-plugins generalization + skills (#9112)
  feat(hooks): PreToolUse denial (#9304)
  Add support for optional api_key configuration for declarative openai-engine providers (#9202)
  fix(cli): use plain '> ' prompt instead of goose emoji (#9305)
  flag for login shell PATH (#9313)
  Remove popular chat topics from new chat screen (#9307)
  fix: stop killing goosed when a window closes (#9302)
  Remove vendored Windows binaries (#9318)
  ...
shafqatevo pushed a commit to shafqatevo/goose that referenced this pull request Aug 7, 2026
@baxen
chore: update canonical model registry (aaif-goose#9331)
d4d75d9 
Signed-off-by: Bradley Axen <baxen@squareup.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DOsinga DOsinga DOsinga approved these changes
@jamadeo jamadeo jamadeo approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@baxen @DOsinga @jamadeo @michaelneale