fix: convert quoted numeric config values to numbers if needed - #8844
Merged
Conversation
DOsinga
approved these changes
May 12, 2026
DOsinga
left a comment
DOsinga
left a comment
Collaborator
There was a problem hiding this comment.
Clean fix, good tests. Thanks!
One thing: your commit is missing a Signed-off-by line. Please amend with git commit --amend --signoff and force-push so the DCO requirement is satisfied.
Signed-off-by: Philipp Henkel <philipp.henkel@gmail.com>
philipphenkel
force-pushed
the
numeric-config
branch
from
May 12, 2026 05:40
1a18189 to
0c969d8
Compare
Contributor
Author
@DOsinga Thanks for the review! I’ve added the sign-off. |
lifeizhou-ap
added a commit
that referenced
this pull request
May 14, 2026
* main: (66 commits) Switch GH pages deploy to actions/artifact workflow (#9025) fix(summon): re-apply canonical limits when delegate overrides model (#9183) Split code signing from build (#8587) refactor(logging): consolidate logging setup into shared helper in goose crate (#8817) fix(cli): report cumulative total_tokens in stream-json/json output (#8910) plugins: add open plugins (just skills for now) (#9063) fix(providers): refresh GCP metadata server token on expiration (#8929) chore(deps): bump the cargo-minor-and-patch group across 1 directory with 14 updates (#9178) chore(deps): bump bzip2 from 0.5.2 to 0.6.1 (#8964) chore(deps): bump tauri from 2.10.3 to 2.11.1 in /ui/goose2/src-tauri (#9066) chore(deps): bump hono from 4.12.14 to 4.12.18 in /evals/open-model-gym/mcp-harness (#9073) localize hardcoded strings in provider settings UI (#8931) chore(deps): bump @babel/plugin-transform-modules-systemjs from 7.28.5 to 7.29.4 in /documentation (#9122) move settings into app shell (#9047) Add Location column to CLI skills table (#8785) (feat): add routstr as a declarative provider (#9175) Add FuturMix provider (#8840) fix: convert quoted numeric config values to numbers if needed (#8844) fix(ui): keep SSE reconnect loop alive on long disconnects (#8717) (#8846) fix(openai): apply request_params to outgoing API payload (#9151) ...
shafqatevo
pushed a commit
to shafqatevo/goose
that referenced
this pull request
Aug 7, 2026
…goose#8844) Signed-off-by: Philipp Henkel <philipp.henkel@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix typed config reads so provider timeout values stored as strings can be used as numbers.
Provider config values are currently stored in
config.yamlas strings, which means entries like:failed to convert to u64 when provider code read them as numeric values. This now works for provider timeout configs such as OPENAI_TIMEOUT, OLLAMA_TIMEOUT, and
LITELLM_TIMEOUT.
Context
A follow-up in #8437 reported that timeout values written with quotes in config.yaml were ignored unless the quotes were removed manually:
#8437 (comment)
Problem exist in version 1.32.0
Changes
Testing
Ollama provider specific test. Set timeout to 6000 via goose desktop app.
OLLAMA_TIMEOUT: '6000' is written to the config .yaml. It has quotes around it, causing it to be ignored before this fix. With this fix the timeout value is respected.
Related Issues
Relates to #8437
problem report