fix(openai): apply request_params to outgoing API payload - #9151
Merged
DOsinga merged 3 commits intoMay 13, 2026
Conversation
request_params was defined in ModelConfig but never read in create_request(). Caused settings like DeepSeek thinking mode disable to be silently ignored. Fixes aaif-goose#9083, related to aaif-goose#9041
Signed-off-by: Douwe Osinga <douwe@squareup.com>
DOsinga
approved these changes
May 12, 2026
DOsinga
left a comment
Collaborator
There was a problem hiding this comment.
LGTM — the fix correctly merges request_params into the OpenAI format payload, matching the existing pattern in databricks.rs. Dropped the test and merged main.
One thing: your original commit is missing the DCO sign-off. Please amend it with git commit --amend -s and force-push so the DCO check passes.
lifeizhou-ap
added a commit
that referenced
this pull request
May 14, 2026
* main: (66 commits) Switch GH pages deploy to actions/artifact workflow (#9025) fix(summon): re-apply canonical limits when delegate overrides model (#9183) Split code signing from build (#8587) refactor(logging): consolidate logging setup into shared helper in goose crate (#8817) fix(cli): report cumulative total_tokens in stream-json/json output (#8910) plugins: add open plugins (just skills for now) (#9063) fix(providers): refresh GCP metadata server token on expiration (#8929) chore(deps): bump the cargo-minor-and-patch group across 1 directory with 14 updates (#9178) chore(deps): bump bzip2 from 0.5.2 to 0.6.1 (#8964) chore(deps): bump tauri from 2.10.3 to 2.11.1 in /ui/goose2/src-tauri (#9066) chore(deps): bump hono from 4.12.14 to 4.12.18 in /evals/open-model-gym/mcp-harness (#9073) localize hardcoded strings in provider settings UI (#8931) chore(deps): bump @babel/plugin-transform-modules-systemjs from 7.28.5 to 7.29.4 in /documentation (#9122) move settings into app shell (#9047) Add Location column to CLI skills table (#8785) (feat): add routstr as a declarative provider (#9175) Add FuturMix provider (#8840) fix: convert quoted numeric config values to numbers if needed (#8844) fix(ui): keep SSE reconnect loop alive on long disconnects (#8717) (#8846) fix(openai): apply request_params to outgoing API payload (#9151) ...
DOsinga
pushed a commit
that referenced
this pull request
May 14, 2026
Resolve conflicts: - declarative_providers.rs: keep both opencode_go and vercel_ai_gateway tests, plus legacy provider ID validation tests from main - openai.rs: keep merge_reasoning_text/OpenAiFormatOptions from PR, deserialize_null_default_string from main, both streaming state vars, unrestricted request_params forwarding from #9151, and both test functions Signed-off-by: Douwe Osinga <douwe@squareup.com>
shafqatevo
pushed a commit
to shafqatevo/goose
that referenced
this pull request
Aug 7, 2026
…#9151) Signed-off-by: Douwe Osinga <douwe@squareup.com> Co-authored-by: turbowindx <turbowindx@users.noreply.github.com> Co-authored-by: Douwe Osinga <douwe@squareup.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
request_paramsis defined inModelConfigand documented as supportingprovider-specific parameters (e.g.
thinking,extra_bodyfields), butcreate_request()informats/openai.rsnever reads it. Any params setin config are silently discarded before the request is sent.
This breaks use cases like disabling DeepSeek V4 thinking mode: