fix: mention configurable timeout env vars in Ollama stream stall error - #9246
Merged
Conversation
The stall error message now tells users about OLLAMA_STREAM_TIMEOUT, GOOSE_STREAM_TIMEOUT, and OLLAMA_TIMEOUT so they know how to increase the timeout without searching docs. Fixes #8437 Signed-off-by: Douwe Osinga <douwe@squareup.com>
jamadeo
approved these changes
May 22, 2026
jamadeo
enabled auto-merge
May 22, 2026 16:27
shafqatevo
pushed a commit
to shafqatevo/goose
that referenced
this pull request
Aug 7, 2026
…or (aaif-goose#9246) Signed-off-by: Douwe Osinga <douwe@squareup.com> Co-authored-by: Douwe Osinga <douwe@squareup.com> Co-authored-by: Jack Amadeo <jackamadeo@squareup.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The stall error message now tells users about
OLLAMA_STREAM_TIMEOUT,GOOSE_STREAM_TIMEOUT, andOLLAMA_TIMEOUTso they know how to increase the timeout without searching docs.Fixes #8437
The core issue (hardcoded 30s timeout, quoted config values ignored) was already fixed by #8493 and #8844. This PR improves the error message to complete the fix.