fix: enforce review check tool policy - #11128
Merged
Merged
Conversation
Contributor
|
Documentation preview deployed: https://pr-11128.goose-pr-previews-poc.pages.dev |
DOsinga
approved these changes
Aug 11, 2026
DOsinga
left a comment
DOsinga
left a comment
Collaborator
There was a problem hiding this comment.
The fail-closed handling looks good. The legacy path now rejects selected checks with any explicit tool policy, including an empty list, while preserving unrestricted and dry-run behavior. The tests cover the important cases, the CLI and guide document the restriction, and all applicable checks pass. Approved.
michaelneale
added a commit
that referenced
this pull request
Aug 11, 2026
* origin/main: chore(release): bump version to 1.46.0 (minor) (#10920) fix: secure Copilot API endpoint transport (#11129) fix(providers): map kimi_code provider name and pass correct provider to create_request (#11130) fix(cli): honor provider overrides on session resume (#10810) fix: enforce review check tool policy (#11128) chore(deps-dev): bump vite from 7.3.1 to 8.2.1 in /ui (#10977) chore(deps): bump jsonschema from 0.46.10 to 0.49.4 (#10857) chore(deps): bump sigstore-verify from 0.10.0 to 0.11.0 (#10856) chore(deps): bump lopdf from 0.42.0 to 0.44.0 (#10854) chore(deps): bump ctor from 0.2.9 to 0.6.3 (#10852) chore(deps-dev): bump @types/node from 20.19.37 to 26.1.2 in /ui (#10979) chore(deps-dev): bump @electron/fuses from 1.8.0 to 2.1.3 in /ui (#10978) chore(deps-dev): bump electron from 41.10.3 to 43.3.0 in /ui (#10974) fix(permissions): match extension owners exactly (#10455) fix: normalize critical command patterns (#10989) fix: keep LiteLLM default local (#10996) fix: encode GCP Vertex URL path segments (#10998) fix: make Open Plugins installs transactional (#10999) # Conflicts: # Cargo.lock # ui/desktop/package.json # ui/pnpm-lock.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
goose review --no-orchestratewhen any selected check declares a per-checktoolspolicySecurity impact
The legacy single-prompt review path advertised per-check tool allowlists but delegated checks through Summon with the parent session's full developer toolset in Auto mode. Repository-controlled check content or reviewed diffs could therefore obtain capabilities outside the declared check policy. This change fails closed before constructing the full-tool session while preserving dry-run and the safe orchestrated paths.
Closes project-loupe/audit-goose#742 after post-merge verification.
Verification
cargo fmt --all -- --checkcargo test -p goose-cli commands::review::handler::testscargo build -p goose-clicargo clippy -p goose-cli --all-targets -- -D warningsgit diff --checkCoverage verifies unrestricted checks remain allowed and both nonempty and explicit-empty tool policies are rejected with safe rerun guidance.
This finding was discovered by Project Loupe.