fix: keep LiteLLM default local - #10996
Conversation
|
Thanks for identifying and addressing this LiteLLM default-host mismatch. The security boundary and regression test are useful context. Goose uses an issue-first workflow for external contributions: proposed work should begin with an issue in the Goose repository and reach the project’s Could you please convert this proposal into a Goose issue describing the problem and desired behavior? Useful details to carry over include the mismatch between the provider metadata and runtime fallback, the risk of sending credentials or conversation data to an unselected remote host, the requirement to preserve explicitly configured proxy hosts, and a no-network verification plan for both missing and explicit host configuration. These details can inform the discussion without treating the current implementation as an already agreed design. Once the issue has been reviewed and reaches |
* origin/main: chore(release): bump version to 1.46.0 (minor) (#10920) fix: secure Copilot API endpoint transport (#11129) fix(providers): map kimi_code provider name and pass correct provider to create_request (#11130) fix(cli): honor provider overrides on session resume (#10810) fix: enforce review check tool policy (#11128) chore(deps-dev): bump vite from 7.3.1 to 8.2.1 in /ui (#10977) chore(deps): bump jsonschema from 0.46.10 to 0.49.4 (#10857) chore(deps): bump sigstore-verify from 0.10.0 to 0.11.0 (#10856) chore(deps): bump lopdf from 0.42.0 to 0.44.0 (#10854) chore(deps): bump ctor from 0.2.9 to 0.6.3 (#10852) chore(deps-dev): bump @types/node from 20.19.37 to 26.1.2 in /ui (#10979) chore(deps-dev): bump @electron/fuses from 1.8.0 to 2.1.3 in /ui (#10978) chore(deps-dev): bump electron from 41.10.3 to 43.3.0 in /ui (#10974) fix(permissions): match extension owners exactly (#10455) fix: normalize critical command patterns (#10989) fix: keep LiteLLM default local (#10996) fix: encode GCP Vertex URL path segments (#10998) fix: make Open Plugins installs transactional (#10999) # Conflicts: # Cargo.lock # ui/desktop/package.json # ui/pnpm-lock.yaml
Summary
Addresses https://github.com/project-loupe/audit-goose/issues/82.
Security boundary
Selecting LiteLLM without an explicit host must not send bearer credentials, model inventory, or conversation data to a remote service the operator did not choose. The advertised local proxy remains the runtime default.
Verification
bin/cargo fmtbin/cargo test -p goose --test litellm_default_hostbin/cargo build -p goosebin/cargo clippy --all-targets -- -D warningsThis finding was discovered by Project Loupe.