fix: encode GCP Vertex URL path segments - #10998
Merged
Merged
Conversation
DOsinga
approved these changes
Aug 8, 2026
DOsinga
left a comment
DOsinga
left a comment
Collaborator
There was a problem hiding this comment.
This fixes the issue at the URL-construction boundary by encoding each dynamic value as a distinct path segment, while preserving the existing Claude, Gemini, and MaaS endpoint shapes. The regression tests cover traversal, separators, pre-encoded input, query/fragment characters, and MaaS publisher derivation. I found no blocking issues.
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Aug 8, 2026
michaelneale
added a commit
that referenced
this pull request
Aug 11, 2026
* origin/main: chore(release): bump version to 1.46.0 (minor) (#10920) fix: secure Copilot API endpoint transport (#11129) fix(providers): map kimi_code provider name and pass correct provider to create_request (#11130) fix(cli): honor provider overrides on session resume (#10810) fix: enforce review check tool policy (#11128) chore(deps-dev): bump vite from 7.3.1 to 8.2.1 in /ui (#10977) chore(deps): bump jsonschema from 0.46.10 to 0.49.4 (#10857) chore(deps): bump sigstore-verify from 0.10.0 to 0.11.0 (#10856) chore(deps): bump lopdf from 0.42.0 to 0.44.0 (#10854) chore(deps): bump ctor from 0.2.9 to 0.6.3 (#10852) chore(deps-dev): bump @types/node from 20.19.37 to 26.1.2 in /ui (#10979) chore(deps-dev): bump @electron/fuses from 1.8.0 to 2.1.3 in /ui (#10978) chore(deps-dev): bump electron from 41.10.3 to 43.3.0 in /ui (#10974) fix(permissions): match extension owners exactly (#10455) fix: normalize critical command patterns (#10989) fix: keep LiteLLM default local (#10996) fix: encode GCP Vertex URL path segments (#10998) fix: make Open Plugins installs transactional (#10999) # Conflicts: # Cargo.lock # ui/desktop/package.json # ui/pnpm-lock.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Addresses https://github.com/project-loupe/audit-goose/issues/74.
Security boundary
A recipe-selected model name is data within one Vertex model path segment. It must not restructure an authenticated prediction URL or redirect the conversation payload to another project endpoint.
Verification
bin/cargo fmtbin/cargo test -p goose test_build_vertex_url(6 passed)bin/cargo build -p goosebin/cargo clippy --all-targets -- -D warningsgit diff --checkThis finding was discovered by Project Loupe.