Skip to content

Make provider smoke tests faster and more reliable - #10605

Merged
alexhancock merged 3 commits into
mainfrom
codex/provider-smoke-reliability
Jul 21, 2026
Merged

Make provider smoke tests faster and more reliable#10605
alexhancock merged 3 commits into
mainfrom
codex/provider-smoke-reliability

Conversation

@DOsinga

@DOsinga DOsinga commented Jul 21, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • force provider smoke-test subprocesses to use GOOSE_MODE=auto so headless runs do not inherit an approval mode
  • run provider/model cases concurrently with a maximum concurrency of four
  • surface Claude Code CLI result errors instead of reporting an empty model response

Validation

  • pnpm --dir ui/desktop run typecheck
  • pnpm --dir ui/desktop exec prettier --check vitest.integration.config.ts tests/integration/test_providers_lib.ts
  • cargo clippy -p goose --all-targets -- -D warnings
  • normal and code-execution provider smoke suites run locally; expected live-provider failures remain visible rather than being changed by this PR

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: f0bd3d22c4

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread ui/desktop/tests/integration/test_providers_lib.ts Outdated

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 45885b0f85

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread crates/goose/src/providers/claude_code.rs Outdated
@alexhancock
alexhancock merged commit 3065c97 into main Jul 21, 2026
26 checks passed
@alexhancock
alexhancock deleted the codex/provider-smoke-reliability branch July 21, 2026 19:30
michaelneale added a commit that referenced this pull request Jul 22, 2026
* origin/main:
  fix(ui): clear stale pending ACP connection after terminal recovery failure (#10552)
  Make provider smoke tests faster and more reliable (#10605)
  fix(acp): confirm pending steer message on queuedSteer notification (#10532)
  chore(deps): bump body-parser from 1.20.5 to 1.20.6 in /documentation (#10601)
  chore(deps): bump webpack-dev-server from 5.2.5 to 5.2.6 in /documentation (#10593)
  feat(compaction): structured summary output with template rendering (#10471)
  feat(skills): allow disabling built-in skills (#10600)
  fix: apply hermit env directly in node shims so a fish login shell doesn't break MCP startup (#10028)
  chore(release): bump version to 1.44.0 (minor) (#10597)
  fix(extensions): preserve command arguments through forms (#10527)
  fix(permissions): enforce manual approval for code mode (#10528)
  fix(apps): confine app file operations (#10481)
  fix(local-inference): preserve featured model size on delete and backfill missing sizes (#10422)
  refactor(acp): extract tool call handling from server (#10574)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants