refactor(acp): extract tool call handling from server - #10574
Merged
Conversation
lifeizhou-ap
changed the title
michaelneale
approved these changes
Jul 21, 2026
michaelneale
left a comment
michaelneale
left a comment
Collaborator
There was a problem hiding this comment.
I assume ok - a lot more comments (I guess that is a claude model at work) which I think add to it, but may want to check it isn't totally repeating the code, but that seems pretty standard these days!
Collaborator
Author
Yes, i moved the original comments in this refactoring. This is the first step of the refactoring, and would like to merge first to avoid a large PR. More work have been planned to enhance and structure this original vide coded code! |
michaelneale
added a commit
that referenced
this pull request
Jul 22, 2026
* origin/main: fix(ui): clear stale pending ACP connection after terminal recovery failure (#10552) Make provider smoke tests faster and more reliable (#10605) fix(acp): confirm pending steer message on queuedSteer notification (#10532) chore(deps): bump body-parser from 1.20.5 to 1.20.6 in /documentation (#10601) chore(deps): bump webpack-dev-server from 5.2.5 to 5.2.6 in /documentation (#10593) feat(compaction): structured summary output with template rendering (#10471) feat(skills): allow disabling built-in skills (#10600) fix: apply hermit env directly in node shims so a fish login shell doesn't break MCP startup (#10028) chore(release): bump version to 1.44.0 (minor) (#10597) fix(extensions): preserve command arguments through forms (#10527) fix(permissions): enforce manual approval for code mode (#10528) fix(apps): confine app file operations (#10481) fix(local-inference): preserve featured model size on delete and backfill missing sizes (#10422) refactor(acp): extract tool call handling from server (#10574)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR is pure refactoring, no major behaviour change
Changes
ToolCallNotifierto centralize initial tool-call and update notifications across live sessions, replay, and filesystem tools.Testing
CI