fix(local-inference): preserve featured model size on delete and backfill missing sizes - #10422
Merged
michaelneale merged 1 commit intoJul 21, 2026
Conversation
…fill missing sizes
The-Best-Codes
self-requested a review
July 14, 2026 15:37
Comment on lines
+55
to
+57
|
|
||
| [dev-dependencies] | ||
| env-lock.workspace = true |
Collaborator
There was a problem hiding this comment.
Is this new dependency necesarry?
Contributor
Author
There was a problem hiding this comment.
Yes, the two new tests set GOOSE_PATH_ROOT to a tempdir so delete_model/sync_with_featured don't write to the real goose data dir, and env_lock::lock_env serializes the env-var mutation across parallel tests (plain std::env::set_var would race). It's dev-dependencies only, and env-lock is already a workspace dependency used with this same pattern in other crates (e.g. goose/src/config/declarative_providers.rs tests), so this just reuses the existing convention rather than adding anything new to the tree.
Collaborator
|
@The-Best-Codes I think ok with me if with you? the new dep is dev time only |
Collaborator
|
@michaelneale Yep okay with me! |
The-Best-Codes
approved these changes
Jul 21, 2026
michaelneale
added a commit
that referenced
this pull request
Jul 22, 2026
* origin/main: fix(ui): clear stale pending ACP connection after terminal recovery failure (#10552) Make provider smoke tests faster and more reliable (#10605) fix(acp): confirm pending steer message on queuedSteer notification (#10532) chore(deps): bump body-parser from 1.20.5 to 1.20.6 in /documentation (#10601) chore(deps): bump webpack-dev-server from 5.2.5 to 5.2.6 in /documentation (#10593) feat(compaction): structured summary output with template rendering (#10471) feat(skills): allow disabling built-in skills (#10600) fix: apply hermit env directly in node shims so a fish login shell doesn't break MCP startup (#10028) chore(release): bump version to 1.44.0 (minor) (#10597) fix(extensions): preserve command arguments through forms (#10527) fix(permissions): enforce manual approval for code mode (#10528) fix(apps): confine app file operations (#10481) fix(local-inference): preserve featured model size on delete and backfill missing sizes (#10422) refactor(acp): extract tool call handling from server (#10574)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
delete_modelno longer zeroessize_bytesfor featured models — the known size persists so the UI still shows it and recommendations still work after a delete. Only the on-disk files, storage path, and shard files are reset.sync_with_featurednow backfillssize_bytesfor an existing entry when it is0and a resolved size is available. It never overwrites a non-zero size and never touches user settings or storage type.ensure_featured_models_currentresolves size metadata for featured models that havesize_bytes == 0and are not downloaded (needs_size).recommend_local_modelusesfile_size()(which falls back to on-disk size) instead of the rawsize_bytesfield.Why
Deleting a featured model previously wiped its size, hiding it in the UI and excluding it from
recommend_local_model(which filters onsize_bytes > 0). Featured entries added before their size resolved were also never backfilled. See #10421.Tests
Added
env-lockas a dev-dependency and two unit tests inlocal_model_registry.rs:delete_featured_model_preserves_size_bytessync_with_featured_backfills_size_without_touching_settingsChecklist
cargo fmtcargo clippy --all-targets -- -D warningscargo test -p goose-local-inferenceCloses #10421