fix: sync generated chat title in header - #10578
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2690640346
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if (shouldShowNewChatTitle(session)) { | ||
| return DEFAULT_CHAT_TITLE; | ||
| } | ||
| return session.name; |
There was a problem hiding this comment.
When ACP omits SessionInfo.title (now normalized to name: '' in sessionInfoToSession), this helper returns an empty string for a non-recipe, non-renamed session. SessionActionsHeader renders that value directly in the top-center title button, so those sessions show a blank header instead of “New Chat” or an untitled placeholder; the old message-count heuristic hid this case. A fallback for an empty session.name would preserve the generated-title fix without blanking untitled sessions.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
sessions should never be untitled
* main: (28 commits) chore(deps): bump postcss from 8.5.10 to 8.5.23 in /documentation (#10721) chore(deps-dev): bump js-yaml from 4.2.0 to 4.3.0 in /documentation (#10735) chore(deps): bump fast-uri from 3.1.2 to 3.1.4 in /documentation (#10647) chore(deps): bump svgo from 3.3.3 to 3.3.4 in /documentation (#10646) chore(deps): bump docker/login-action from 4.4.0 to 4.5.1 (#10670) chore(deps): bump ossf/scorecard-action from 2.4.3 to 2.4.4 (#10671) chore(deps): bump pypa/gh-action-pypi-publish from 1.14.0 to 1.14.1 (#10674) fix(providers): update DeepSeek model names to v4 API (#10729) fix(acp): forward Claude Code model picker selection to the adapter (#10675) fix(acp): forward Pi model selection to the adapter (#10707) fix(config): preserve enabled flag when migrating platform extensions (#10690) fix(acp): pass session working_dir to on_call_tool (#10689) fix(security): preserve adversary tool arguments (#10529) fix(local-inference): keep XML snippets inside JSON as data (#10606) fix: sync generated chat title in header (#10578) feat: tab completion and switch provider for `model` (#10585) fix(telegram): prompt for tool approval in gateway sessions (#10613) fix: keep CLI provider prompts out of process arguments (#10547) fix(providers): ignore stale inventory for static model lists (#10591) fix(ui): Refine dark theme message surfaces for consistent, compliant dark mode UX. (#10693) ...
4 participants
Summary
New Chatin session mappingmessage_countheuristic for showingNew ChatgetSessionDisplayNameTest plan
Sidebar sync worksand confirming the top-center title updated too