fix: keep CLI provider prompts out of process arguments - #10547
Merged
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: fc79305e4e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Collaborator
Author
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: fc79305e4e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
michaelneale
approved these changes
Jul 22, 2026
alexhancock
approved these changes
Jul 27, 2026
lifeizhou-ap
added a commit
that referenced
this pull request
Jul 28, 2026
* main: (28 commits) chore(deps): bump postcss from 8.5.10 to 8.5.23 in /documentation (#10721) chore(deps-dev): bump js-yaml from 4.2.0 to 4.3.0 in /documentation (#10735) chore(deps): bump fast-uri from 3.1.2 to 3.1.4 in /documentation (#10647) chore(deps): bump svgo from 3.3.3 to 3.3.4 in /documentation (#10646) chore(deps): bump docker/login-action from 4.4.0 to 4.5.1 (#10670) chore(deps): bump ossf/scorecard-action from 2.4.3 to 2.4.4 (#10671) chore(deps): bump pypa/gh-action-pypi-publish from 1.14.0 to 1.14.1 (#10674) fix(providers): update DeepSeek model names to v4 API (#10729) fix(acp): forward Claude Code model picker selection to the adapter (#10675) fix(acp): forward Pi model selection to the adapter (#10707) fix(config): preserve enabled flag when migrating platform extensions (#10690) fix(acp): pass session working_dir to on_call_tool (#10689) fix(security): preserve adversary tool arguments (#10529) fix(local-inference): keep XML snippets inside JSON as data (#10606) fix: sync generated chat title in header (#10578) feat: tab completion and switch provider for `model` (#10585) fix(telegram): prompt for tool approval in gateway sessions (#10613) fix: keep CLI provider prompts out of process arguments (#10547) fix(providers): ignore stale inventory for static model lists (#10591) fix(ui): Refine dark theme message surfaces for consistent, compliant dark mode UX. (#10693) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Security impact
Serialized system, conversation, and user prompt content is no longer exposed through child process argv to same-host process inspection.
Fixes project-loupe/audit-goose#66.
Fixes project-loupe/audit-goose#251.
Validation
cargo fmt --allcargo test -p goose is_sent_on_stdin -- --nocapture(4 passed)cargo test -p goose providers::cursor_agent::tests:: -- --nocapture(2 passed)cargo test -p goose providers::gemini_cli::tests:: -- --nocapture(3 passed)cargo build -p goosecargo clippy -p goose --all-targets -- -D warningsThis finding was discovered by Project Loupe.