-
Notifications
You must be signed in to change notification settings - Fork 903
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[abc] Assertion src/base/abc/abcAig.c:1134: void abc::Abc_AigUpdateLevelR_int(abc::Abc_Aig_t *): Assertion `Abc_ObjIsNode(pNode)' failed. #4039
Comments
yosys-abc-FpVpDJ-issue4039.tar.bz2.gz Only BZIP2 can get it below the github 25MB limit. github does not accept tar.bz2 attachments, so it is wrapped in gzip.
See |
Note that Yosys itself doesn't use the crashing For this particular example, replacing all uses of If this issue indeed only affects obsolete commands with working replacements, my suggestion would be that we remove such commands from yosys-abc, replacing them with an error message pointing at the replacement command to make sure that third party flows do not inadvertently keep using broken abc commands. The alternative would be to get this fixed in upstream abc, but given the amount of effort it takes to debug issues in abc, the fact that there seems to be a working drop-in replacement with |
Re Yosys commands: rewrite & refactor These commands are considered obsolete and unmaintained by Yosys Replacement commands exist in the form of: drw & drf See also: YosysHQ/yosys#4039 The-OpenROAD-Project#1523
* Updated `Yosys.Synthesis`, `Yosys.VHDLSynthesis` per comments from Yosys team [(1)](YosysHQ/yosys#4039 (comment)) [(2)](The-OpenROAD-Project/OpenLane#2051 (comment)) * Replaced instances of ABC command `rewrite` with `drw -l` with new variable `SYNTH_ABC_LEGACY_REWRITE` being set to `true` restoring the older functionality (`false` by default) * Replaced instances of ABC command `refactor` with `drf -l` with new variable `SYNTH_ABC_LEGACY_REFACTOR` being set to `true` restoring the older functionality (`false` by default)
Version
Yosys 0.33+21 (git sha1 9e00442, clang 10.0.0-4ubuntu1 -fPIC -Os) oss-cad-suite-20230913
On which OS did this happen?
Linux
Reproduction Steps
Test case ZIP attached.
FAIL: Yosys 0.33+21 (git sha1 9e00442, clang 10.0.0-4ubuntu1 -fPIC -Os) oss-cad-suite-20230913 FIRST FAILING VERSION
yosys-abc: src/base/abc/abcAig.c:1134: void abc::Abc_AigUpdateLevelR_int(abc::Abc_Aig_t *): Assertion `Abc_ObjIsNode(pNode)' failed.
It looks like ABC went:
https://github.com/YosysHQ/abc
bb64142..9537f39
In that time this assertion was triggered.
OpenLane flow emits:
Expected Behavior
Yosys:
PASS: Yosys 0.28+6 (git sha1 cee3cb3, clang 10.0.0-4ubuntu1 -fPIC -Os) oss-cad-suite-20230504
PASS: Yosys 0.31+16 (git sha1 b04d0e0, clang 10.0.0-4ubuntu1 -fPIC -Os) oss-cad-suite-20230725
PASS: Yosys 0.32+79 (git sha1 b75959f, clang 10.0.0-4ubuntu1 -fPIC -Os) oss-cad-suite-20230905
PASS: Yosys 0.33+3 (git sha1 83b1a57, clang 10.0.0-4ubuntu1 -fPIC -Os) oss-cad-suite-20230906
PASS: Yosys 0.33+6 (git sha1 41b34a1, clang 10.0.0-4ubuntu1 -fPIC -Os) oss-cad-suite-20230911
PASS: Yosys 0.33+6 (git sha1 41b34a1, clang 10.0.0-4ubuntu1 -fPIC -Os) oss-cad-suite-20230912
yosys-abc: src/base/abc/abcAig.c:1134: void abc::Abc_AigUpdateLevelR_int(abc::Abc_Aig_t *): Assertion `Abc_ObjIsNode(pNode)' failed.
FAIL: Yosys 0.33+21 (git sha1 9e00442, clang 10.0.0-4ubuntu1 -fPIC -Os) oss-cad-suite-20230913 FIRST FAILING VERSION
FAIL: Yosys 0.33+53 (git sha1 e2b6133, clang 10.0.0-4ubuntu1 -fPIC -Os) oss-cad-suite-20230919
FAIL: Yosys 0.33+112 (git sha1 3e02b63, clang 10.0.0-4ubuntu1 -fPIC -Os) oss-cad-suite-20231005
FAIL: Yosys 0.34+7 (git sha1 fc815fd, clang 10.0.0-4ubuntu1 -fPIC -Os) oss-cad-suite-20231006
FAIL: Yosys 0.34+60 (git sha1 93a426c, clang 10.0.0-4ubuntu1 -fPIC -Os) oss-cad-suite-20231107
FAIL: Yosys 0.35+7 (git sha1 5691cd0, clang 10.0.0-4ubuntu1 -fPIC -Os) oss-cad-suite-20231108
FAIL: Yosys 0.35+29 (git sha1 ab6c1d3, clang 10.0.0-4ubuntu1 -fPIC -Os) oss-cad-suite-20231118
Actual Behavior
The text was updated successfully, but these errors were encountered: