Proposed 2.0.0-rc6 #4853
Merged
Proposed 2.0.0-rc6 #4853
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Hussein Badakhchani <[email protected]>
…PLF#3839)" (XRPLF#4850) This reverts commit 8f89694.
…XRPLF#4852) This reverts commit 002893f. There were two files with conflicts in the automated revert: - src/ripple/rpc/impl/RPCHelpers.h and - src/test/rpc/JSONRPC_test.cpp Those files were manually resolved.
intelliot
requested review from
Bronek,
gregtatcam,
manojsdoshi and
SaxenaKaustubh
gregtatcam
approved these changes
Dec 20, 2023
|
all the unit tests pass on MacOS 👍 |
Bronek
approved these changes
Dec 20, 2023
|
@HowardHinnant confirmed that tests are now passing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
The only C++ code changes are reverts of #3839 and #4504.
Context of Change
Ledgers with zero transactions were observed in Testnet, and the issue seems to be exacerbated by changes in
develop. The two PRs reverted here were identified as potentially risky and are therefore being reverted until a more rigorous and realistic test harness is ready in 6-12 months.Type of Change
API Impact
Since this release candidate reverts #4505, it removes the "sync_mode" field which had been added to the transaction submission API.
Test Plan
We expect to run this release candidate on Testnet for 2 weeks, with close observation to identify if any issues occur.