Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert #3839 "Add ProtocolStart and GracefulClose P2P protocol messages" #4850

Merged
merged 1 commit into from
Dec 19, 2023

Conversation

Bronek
Copy link
Collaborator

@Bronek Bronek commented Dec 13, 2023

This reverts PR #3839

High Level Overview of Change

Context of Change

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor (non-breaking change that only restructures code)
  • Tests (you added tests for code that already exists, or your new feature included in this PR)
  • Documentation update
  • Chore (no impact to binary, e.g. .gitignore, formatting, dropping support for older tooling)
  • Release

@HowardHinnant HowardHinnant self-requested a review December 14, 2023 01:21
Copy link
Collaborator

@scottschurr scottschurr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have verified this pull request as well as I can.

  • I verified that the contents of the pull request exactly match a git-generated revert.
  • I verified that using my difftool as well as with a visual inspection.

What I would like to do is verify that it builds, passes unit tests, and syncs on my development box. However there was a recent corporate mandated update to my laptop. Since that update I can no longer build develop. So I can't provide that verification until that problem is solved.

The good news (I guess) is that building develop and building this branch both fail in the same way 😁.

@intelliot intelliot added this to the 2.0.0 milestone Dec 18, 2023
@intelliot intelliot added the Passed Passed code review & PR owner thinks it's ready to merge. Perf sign-off may still be required. label Dec 19, 2023
@intelliot intelliot merged commit ffb53f2 into XRPLF:develop Dec 19, 2023
16 checks passed
sophiax851 pushed a commit to sophiax851/rippled that referenced this pull request Jun 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Passed Passed code review & PR owner thinks it's ready to merge. Perf sign-off may still be required.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants