Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TRIVIAL] Typo fix 'of' instead of 'on' #4821

Merged
merged 2 commits into from
Dec 6, 2023
Merged

[TRIVIAL] Typo fix 'of' instead of 'on' #4821

merged 2 commits into from
Dec 6, 2023

Conversation

hoos
Copy link
Contributor

@hoos hoos commented Nov 17, 2023

High Level Overview of Change

The class comment in AMMCreate.h used the word "on" instead of "of" in the sentence: "... AMM pool in the form on LPTokens."

Context of Change

A typo in comments.

Type of Change

  • [ x] Documentation update

API Impact

  • Public API: New feature (new methods and/or new fields)
  • Public API: Breaking change (in general, breaking changes should only impact the next api_version)
  • libxrpl change (any change that may affect libxrpl or dependents of libxrpl)
  • Peer protocol change (must be backward compatible or bump the peer protocol version)

Copy link
Collaborator

@Bronek Bronek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add [TRIVIAL] in this PR subject line.

@hoos hoos changed the title Typo fix 'of' instead of 'on' Typo fix 'of' instead of 'on' [TRIVIAL] Dec 4, 2023
@hoos hoos changed the title Typo fix 'of' instead of 'on' [TRIVIAL] [TRIVIAL] Typo fix 'of' instead of 'on' Dec 4, 2023
@hoos
Copy link
Contributor Author

hoos commented Dec 4, 2023

I added [TRIVIAL] to the beginning of the subject line of the PR.

@intelliot
Copy link
Collaborator

intelliot commented Dec 6, 2023

It's truly a trivial change, but giving @gregtatcam - as the original author of AMM - a chance to see

Copy link
Collaborator

@gregtatcam gregtatcam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

@intelliot intelliot merged commit 656948c into XRPLF:develop Dec 6, 2023
16 checks passed
@intelliot
Copy link
Collaborator

Merged because this only touches a comment (no code).

sophiax851 pushed a commit to sophiax851/rippled that referenced this pull request Jun 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants