Repository navigation
Conversation
desrosj
added
[Type] Build Tooling
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
desrosj
added this pull request to stack #85017
October 16, 2026 20:10
|
Size Change: 0 B Total Size: 1.14 MB ℹ️ View Unchanged
|
This was referenced Oct 16, 2026
Open
desrosj
marked this pull request as ready for review
October 19, 2026 13:19
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #82938.
What?
Adds a
WP_ENV_MARIADB_VERSIONenvironment variable that picks the MariaDB imagewp-envuses:packages/env/lib/build-docker-compose-config.jschanges'mariadb'to'mariadb:${WP_ENV_MARIADB_VERSION:-latest}', so the default image doesn't change.wp-env destroy, since MariaDB can't start on a database written by a newer version. With a version older than 11.4,wp dbcommands in thecliandtests-clicontainers fail andwp-env cleanleaves the database alone, because thewordpress:cliimage's MariaDB client requires TLS; WordPress itself isn't affected.packages/env/test/build-docker-compose-config.jschecks the image string.Why?
This branch's
wp-env(1.6.0) always runs the floatingmariadbimage, many years newer than anything this branch was tested against, with no way to pin an older one.How?
Follows #83751, which adds a
mariadbVersionoption and this environment variable to trunk.wp-env1.6.0 has no version settings to extend, so only the variable is ported. Docker Compose substitutes it when it reads the generated file, as it already does forWP_ENV_PORTandLOCAL_PHP.npm run test-unit -- packages/envpasses all 31 tests locally (packages/env/test/cli.jscan't load without a builtnodegit, which is unrelated).The
mariadb-checkTLS errorwp-env starthits with older MariaDB versions is fixed by #85010, two PRs above.Use of AI Tools
This PR was created by Claude Code under my supervision. All code should be treated as AI-produced and not yet reviewed by a human until this PR is marked Ready for Review.
🤖 Generated with Claude Code