Repository navigation
Conversation
desrosj
added
[Type] Build Tooling
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
desrosj
added this pull request to stack #85017
October 16, 2026 20:10
|
Size Change: 0 B Total Size: 1.14 MB ℹ️ View Unchanged
|
This was referenced Oct 16, 2026
Closed
desrosj
marked this pull request as ready for review
October 19, 2026 13:20
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
ramonjd
approved these changes
Oct 21, 2026
This was referenced Oct 21, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #82938.
What?
Adds a
WP_ENV_PHP_VERSIONenvironment variable that chooses the PHP version ofwp-env's WordPress and WP-CLI containers, and defaults it to7.4, the highest PHP version WordPress 5.5 supports. Inpackages/env/lib/build-docker-compose-config.js:wordpress,tests-wordpresswordpresswordpress:php${WP_ENV_PHP_VERSION:-7.4}cli,tests-cliwordpress:cliwordpress:cli-php${WP_ENV_PHP_VERSION:-7.4}Adds a test for the image strings, a README note next to the
WP_ENV_MARIADB_VERSIONone, and apackages/env/CHANGELOG.mdentry under New Features. Thephpunitservice is unchanged: it already usesLOCAL_PHP, which thePHPjob's matrix sets.Why?
The floating
wordpressimage now runs PHP 8.3, but WordPress 5.5 doesn't support PHP 8. On PHP 8, WordPress 5.5'sWP_Query::parse_query()makes every front-end request without a post ID a 404: it checks$qv['p'] < 0without casting, and PHP 8 compares''with0as strings, which is true. WordPress 5.6 casts the value to an integer first.That breaks every end-to-end test that loads the site editor's
front-pagedemo template: the front page is a 404, so Gutenberg resolvesindexinstead, andfront-pageand its header template part never load. 10 tests fail on this branch for that reason (experiments/multi-entity-editing.test.js5,multi-entity-saving.test.js4,template-part.test.js1).Defaulting to
7.4, rather than the images' default, means anyone running this branch'swp-envgets a PHP version WordPress 5.5 supports without setting anything. CI sets the variable explicitly in #85013.How?
This follows
WP_ENV_MARIADB_VERSION(#85008), and the variable name matches the one laterwp-envversions use.wp-env1.6.0 has nophpVersionoption to extend, so only the environment variable is added; Docker Compose fills it in when it reads the generateddocker-compose.yml. Both image families have aphp<version>/cli-php<version>tag for each PHP version, so one default covers both.Verified:
packages/env/test/build-docker-compose-config.js(14 tests).docker compose configon this branch's generated file resolveswordpress:php7.4/wordpress:cli-php7.4with the variable unset, andwordpress:php7.3/wordpress:cli-php7.3withWP_ENV_PHP_VERSION=7.3. All four tags exist on Docker Hub.7.4images passed every check, including all fourAdminjobs.Use of AI Tools
This PR was created by Claude Code under my supervision. All code should be treated as AI-produced and not yet reviewed by a human until this PR is marked Ready for Review.