DataViews: Restrict the isAll filter operator to array fields

[oandregal]

What?

Follow up to #77942.

Makes the isAll filter operator work only with array values. It is removed from the valid operators of the number, integer, text, email, url and telephone field types, and the filter itself now excludes any item whose value is not an array instead of throwing or matching substrings.

Why?

"Includes all of" only makes sense for a value that can hold several items at once. A number or a string holds one, so the operator could never match more than one selected value. Worse, the filter called includes on whatever the field returned: for a number it threw a TypeError, and for a string it did substring matching, so "Product includes all: a, b" matched the title "abc". The README still listed isAll as valid for all six scalar types, so consumers had no way to know it was unusable.

How?

The isAll filter in operators.tsx returns false for any non-array value. Fields with no declared type accept every operator, so a scalar can still reach it, and excluding the item matches how isAny and isNone treat unsupported types. The six scalar field types drop OPERATOR_IS_ALL from their validOperators, which also stops the filter UI from offering it, and the README lists are updated. While editing those lists I found that the second "email" entry sat where "telephone" belongs and "telephone" was missing, so that entry is renamed. The deprecated isNotAll is untouched: it is an alias of isNone, which works for scalars.

Testing Instructions

Run the DataViews unit tests with npm run test:unit:vitest -- packages/dataviews. The new cases in filter-sort-and-paginate.js check that an untyped number and an untyped string field are excluded by isAll instead of throwing, and the new cases in normalize-fields.ts check that each of the six scalar types drops isAll from a field's operators. To see it in the UI, open the DataViews story in Storybook, temporarily give the satellites field in packages/dataviews/src/dataviews/stories/fixtures.tsx an elements list and filterBy: { operators: [ 'isAny', 'isNone', 'isAll' ] }, and add a Satellites filter. On trunk the "Includes all" operator is offered and picking a value throws in the console. On this branch only "Includes" and "Is none of" are offered.

Testing Instructions for Keyboard

Same as above. The filter operator list is a regular menu, so open it with Enter or Space and move through it with the arrow keys to confirm "Includes all" is not offered for the Satellites field.

Use of AI Tools

This PR was written with Claude Code, including the code, tests and this description. I reviewed every change and take responsibility for it.

🤖 Generated with Claude Code

https://claude.ai/code/session_01G3JDtk1v34AMMhCWECAc9X

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. To trigger a review, include @coderabbitai review in the PR description. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Team

Run ID: 16132e73-a85b-4d9c-8697-5617cd61a5f0

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

---

_{Comment @coderabbitai help to get the list of available commands.}

[github-actions]

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: oandregal <oandregal@git.wordpress.org>
Co-authored-by: youknowriad <youknowriad@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

[Copilot]

🟡 Changes recommended

Persisted typed-scalar isAll filters become visible no-ops because normalization removes their handler.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Pull request overview

Restricts isAll filtering to array-valued DataViews fields.

Changes:

• Rejects non-array values for isAll.
• Removes isAll from scalar field operators.
• Updates tests and documentation.

File summaries

File	Description
packages/dataviews/src/utils/operators.tsx	Guards isAll against scalar values.
packages/dataviews/src/utils/test/filter-sort-and-paginate.js	Tests scalar filtering behavior.
packages/dataviews/src/field-types/test/normalize-fields.ts	Tests scalar operator normalization.
packages/dataviews/src/field-types/email.tsx	Removes scalar isAll support.
packages/dataviews/src/field-types/integer.tsx	Removes scalar isAll support.
packages/dataviews/src/field-types/number.tsx	Removes scalar isAll support.
packages/dataviews/src/field-types/telephone.tsx	Removes scalar isAll support.
packages/dataviews/src/field-types/text.tsx	Removes scalar isAll support.
packages/dataviews/src/field-types/url.tsx	Removes scalar isAll support.
packages/dataviews/README.md	Documents valid operators.
packages/dataviews/CHANGELOG.md	Records the behavior change.

Review details

• Files reviewed: 11/11 changed files
• Comments generated: 1
• Review effort level: Balanced

---

💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[oandregal]

For all fields (email, integer, number, telephone, text, url) this was a valid operator but not a default operator. I checked major DataViews consumers I work with and none used it.

[github-actions]

🤖 PR meta 🤖

📦 Bundle size

Size Change: -349 B (0%)

Total Size: 8 MB

📦 View Changed

Filename	Size	Change
build/scripts/block-editor/index.min.js	479 kB	-75 B (-0.02%)
build/scripts/block-library/index.min.js	367 kB	-36 B (-0.01%)
build/scripts/components/index.min.js	266 kB	-30 B (-0.01%)
build/scripts/edit-site/index.min.js	379 kB	-83 B (-0.02%)
build/scripts/editor/index.min.js	584 kB	-35 B (-0.01%)
build/scripts/format-library/index.min.js	40.2 kB	-31 B (-0.08%)
build/scripts/media-utils/index.min.js	201 kB	-59 B (-0.03%)

_{0ec0e73 Run}

⚡ Performance

Show the results

Client side metrics exclude the server response time.

front-end-block-theme

Metric	9f36e39	trunk	% Change
timeToFirstByte	54.65 ms +16.56% -3.39%	56 ms +8.3% -5.09%	-2.41%
largestContentfulPaint	94 ms +6.38% -10.64%	94 ms +4.26% -6.38%	0%
lcpMinusTtfb	33.95 ms +16.49% -5.74%	32.65 ms +26.8% -3.83%	3.98%
wpBeforeTemplate	26.83 ms +20.16% -7.42%	25.65 ms +15.05% -3.63%	4.6%
wpTemplate	24.2 ms +5.45% -2.11%	24.74 ms +2.75% -2.95%	-2.18%
wpTotal	50.61 ms +15% -3.42%	52 ms +6.54% -5.44%	-2.67%
wpMemoryUsage	7.52 MB +0% -0%	7.48 MB +0% -0%	0.46%
wpDbQueries	17 +0% -0%	17 +0% -0%	0%

front-end-classic-theme

Metric	9f36e39	trunk	% Change
timeToFirstByte	45.15 ms +3.1% -2.66%	45.05 ms +10.88% -4.66%	0.22%
largestContentfulPaint	92 ms +4.35% -2.17%	92 ms +4.35% -4.35%	0%
lcpMinusTtfb	46.7 ms +2.68% -4.28%	45.7 ms +1.86% -3.72%	2.19%
wpBeforeTemplate	22.19 ms +11.85% -2.03%	21.97 ms +15.38% -2.64%	1%
wpTemplate	18.88 ms +6.25% -3.5%	18.79 ms +6.17% -5.91%	0.48%
wpTotal	41.8 ms +3.18% -2.7%	41.3 ms +11.07% -4.43%	1.21%
wpMemoryUsage	6.14 MB +0% -0%	6.10 MB +0% -0%	0.58%
wpDbQueries	14 +0% -0%	14 +0% -0%	0%

media-processing

Metric	9f36e39	trunk	% Change
mediaProcessingJpeg	395.78 ms +0.67% -1.3%	393.99 ms +0.26% -0.21%	0.45%
mediaProcessingAvif	5868.55 ms +0.45% -0.34%	5833.49 ms +0.14% -0.18%	0.6%
mediaProcessingJpegToAvif	4099.13 ms +0.06% -0.35%	4092.44 ms +0.13% -0.05%	0.16%

media-upload

Metric	9f36e39	trunk	% Change
jpegUploadProcessing	1507.12 ms +30.73% -4.23%	1448.07 ms +0.67% -0.26%	4.08%
pngUploadProcessing	227.68 ms +4.36% -7.66%	216.7 ms +8.63% -4.37%	5.07%
largeJpegUploadProcessing	1421.93 ms +0.59% -0.17%	1430.59 ms +0.22% -0.35%	-0.61%
multipleImageUploadProcessing	1607.62 ms +32.34% -0.27%	1628.15 ms +30.42% -2.13%	-1.26%

post-editor

Metric	9f36e39	trunk	% Change
serverResponse	462.28 ms +1.52% -8.26%	456.7 ms +7.4% -1.72%	1.22%
firstPaint	215.02 ms +6.33% -10.9%	216.31 ms +19.56% -19.73%	-0.6%
domContentLoaded	1312.67 ms +1.44% -1.43%	1338.45 ms +0.98% -1%	-1.93%
loaded	1314.09 ms +1.45% -1.44%	1340.02 ms +0.97% -1.01%	-1.94%
firstContentfulPaint	435.75 ms +2.59% -5.9%	447.53 ms +3.44% -2.24%	-2.63%
firstBlock	3503.76 ms +0.56% -1.42%	3583.47 ms +0.15% -1.19%	-2.22%
type	21.7 ms +5.21% -14.33%	23.43 ms +14.81% -17.67%	-7.38%
typeWithoutInspector	21.59 ms +13.71% -18.94%	23.11 ms +5.32% -18%	-6.58%
typeWithTopToolbar	26.36 ms +4.86% -18.89%	25.55 ms +10.84% -8.77%	3.17%
typeContainer	9.74 ms +1.23% -8.42%	10.08 ms +4.46% -8.04%	-3.37%
focus	86.08 ms +4.87% -11.72%	82.01 ms +3.72% -8.26%	4.96%
firstFocus	185.16 ms +0% -0%	182.42 ms +0% -0%	1.5%
selectAll	610.5 ms +0.88% -2.63%	575.18 ms +0.34% -0.41%	6.14%
listViewOpen	73.03 ms +9.01% -9.64%	66.04 ms +8.62% -7.51%	10.58%
inserterOpen	25.47 ms +10.09% -10.13%	24.21 ms +8.55% -12.06%	5.2%
inserterHover	4.19 ms +11.93% -13.37%	3.98 ms +16.33% -6.78%	5.28%
inserterSearch	8.73 ms +11% -7.22%	8.75 ms +18.06% -6.63%	-0.23%
loadPatterns	673.63 ms +4.22% -2.84%	634.93 ms +5.68% -0.84%	6.1%
wpTotal	450.83 ms +1.56% -8.44%	445.69 ms +7.48% -1.84%	1.15%
wpMemoryUsage	13.12 MB +0% -0%	13.08 MB +0% -0%	0.28%
wpDbQueries	54 +0% -1.85%	54 +0% -1.85%	0%

site-editor

Metric	9f36e39	trunk	% Change
serverResponse	537.44 ms +2.79% -3.63%	539.83 ms +3.66% -5.92%	-0.44%
firstPaint	258.75 ms +23.42% -17.17%	245.38 ms +9.69% -5.62%	5.45%
domContentLoaded	1430.38 ms +0.71% -0.56%	1426.3 ms +1.06% -2.33%	0.29%
loaded	1431.62 ms +0.7% -0.57%	1427.58 ms +1.06% -2.32%	0.28%
firstContentfulPaint	440.15 ms +2.83% -1.11%	443.15 ms +4.29% -4.59%	-0.68%
firstBlock	4546.3 ms +1.36% -0.83%	4529.18 ms +0.48% -1.4%	0.38%
type	20.94 ms +15.28% -13.23%	22.09 ms +6.2% -9.82%	-5.21%
navigate	105.69 ms +4.35% -4.99%	108.35 ms +2.91% -7.19%	-2.46%
loadPatterns	1456.01 ms +14.43% -12.02%	1485.3 ms +6.85% -9.33%	-1.97%
loadPages	1325.31 ms +21.87% -12.73%	1295.83 ms +27.14% -9.69%	2.27%
wpTotal	527.78 ms +2.79% -3.75%	529.94 ms +3.73% -5.92%	-0.41%
wpMemoryUsage	12.00 MB +0% -0%	11.97 MB +0% -0%	0.23%
wpDbQueries	43 +2.33% -0%	43 +2.33% -0%	0%

_{0ec0e73 Run}