Repository navigation
Packages: Declare missing @types/react dependency - #78882
Conversation
Several packages reference React types in their generated `build-types/`
declarations (via `import('react')`) but do not declare `@types/react` as a
dependency. Consumers installing these packages cannot resolve those type
imports; with `skipLibCheck: true` TypeScript silently falls back to `any`,
disabling type checking for the affected exports.
Declare `@types/react` in `dependencies` for packages whose emitted types
reference it, and in `devDependencies` for packages that only use React types
internally. Also declares `@types/react-dom` where used.
Follows the same rationale as #74655 (which did this for `csstype`).
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: 0 B Total Size: 8.21 MB ℹ️ View Unchanged
|
|
This makes sense to me, but I'm trying to think realistically how we can maintain this moving forward:
|
| "@storybook/react-vite": "^10.2.8", | ||
| "@testing-library/jest-dom": "^6.9.1", | ||
| "@types/jest": "^29.5.14", | ||
| "@types/react-dom": "^19.2.3", |
There was a problem hiding this comment.
Unsure if it's intentional, but we use 19.2.13 everywhere else.
| "@types/react-dom": "^19.2.3", | |
| "@types/react-dom": "^19.2.13", |
There was a problem hiding this comment.
That is the version for @types/react, not @types/react-dom. For @types/react-dom, 19.2.3 is the latest version right now.
There was a problem hiding this comment.
Ah, my mistake, I missed react vs. react-dom 🤦
There was a problem hiding this comment.
Separately, I'd be curious why we're using createPortal directly from react-dom rather than @wordpress/element, considering we already have element package imports in the file already 🤷
There was a problem hiding this comment.
Not sure about that.
| "@storybook/react-vite": "^10.2.8", | ||
| "@testing-library/jest-dom": "^6.9.1", | ||
| "@types/jest": "^29.5.14", | ||
| "@types/react-dom": "^19.2.3", |
There was a problem hiding this comment.
@types/react-dom is also declared in dependencies above. We should probably do a pass across these packages to make sure we're not duplicating elsewhere.
Separately, this seems like something common enough and easy enough to test for in CI ? 🤔
There was a problem hiding this comment.
No, only @types/react is defined in dependencies.
Yes, I am exploring the options to fix this via some tool. Unfortunately, ESLint won't help much. Switch to npm |
| }, | ||
| "devDependencies": { | ||
| "@types/react": "^19.2.13" | ||
| }, |
There was a problem hiding this comment.
The distinction between devDependencies and dependencies can get very subtle. This particular package uses React types internally (import type { ComponentType } from 'react';) but the trick is that this usage is not exported, the public .d.ts files don't reference it. The function that uses ComponentType is statically passed to addFilter.
This is fragile and can easily break unexpectedly. Locally everything is fine, because @types/react is still in node_modules, but a third party user of the NPM package won't get devDependencies installed.
What if we always put the types into dependencies?
There was a problem hiding this comment.
I’m exploring a tool creation which skips installing devDeps and then tries to resolve imports in type defs. It should hopefully catch any missing dependencies.
|
In checking this locally, I found a few more. Do we need to define these dependencies as well?
|
Ideally yes, but we can fix those once we have the tool ready. |
aduth
left a comment
There was a problem hiding this comment.
LGTM based on what's here being an improvement over the current state 👍 As mentioned in previous comment, there might be a few more. Also looking forward to tooling to help with this.
I have some good news for us all. I created the tool I promised! It's called You can try it in Gutenberg for any package npx @mawesome/dependency-audit @wordpress/componentsor locally npx @mawesome/dependency-audit packages/componentsYou can also check all at once npx @mawesome/dependency-audit packages/*Here is what the output looks like
Please give it a try and let me know if I should go ahead with integrating it in this repo. 😄 |
|
You can also use the playground I created, to audit the packages - https://mawesome.pages.dev/dependency-audit/playground/
|
|
That looks like a great project, @manzoorwanijk ! To me I think it'd be worth worth integrating, as this has been a recurring issue and we still don't yet have good protections against future regressions. Maybe your project could even ship a GitHub Action that we could use as part of our CI? Running the command directly could work as well, just thinking about isolating some of the dependencies. |
Thanks! GitHub Action is a cool idea, but it may be hard to integrate with all kinds of monorepos, where package structure changes. But, it's worth a try. |
This updates the pinned commit hash of the Gutenberg repository from `14db4ab9395a9e96430eed678e4288a59eecbd15 ` (version `23.3.0`) to `14db4ab9395a9e96430eed678e4288a59eecbd15` (version `23.4.0`). A full list of changes included in this commit can be found on GitHub: https://github.com/WordPress/gutenberg/compare/v23.3.0..v23.4.0. The following commits are included: - Hide image dimension tools when a state is selected (WordPress/gutenberg#78670) - Changed labels to consistently use Patterns in favor of Block patterns (WordPress/gutenberg#56880) - Fix: Restrict parent page API search to post titles only (WordPress/gutenberg#78683) - Update AGENTS.md to mention additional pitfalls: (WordPress/gutenberg#78718) - Docs: Fix big_image_size_threshold xref typo (WordPress/gutenberg#76299) - Compose: Fully deprecate the 'pure' HoC (WordPress/gutenberg#78674) - Common CSS: avoid false-positive border-style on custom properties (WordPress/gutenberg#77476) - Compose: Fix SSR crash in useMediaQuery and useViewportMatch (WordPress/gutenberg#78725) - CI: Skip plugin repo release when SVN tag already exists (WordPress/gutenberg#78476) - Dashboard: Hello Dolly (WordPress/gutenberg#78648) - UI: `Tooltip.Provider` — forward upstream `closeDelay` and `timeout` props (WordPress/gutenberg#78642) - Compose: Support React 19 ref callback cleanups in `useMergeRefs` (WordPress/gutenberg#78685) - Add copilot-instructions.md file (WordPress/gutenberg#78584) - Dashboard: show ghost widgets visually & allow easy removal (WordPress/gutenberg#78502) - Bump fast-xml-builder from 1.0.0 to 1.2.0 (WordPress/gutenberg#78272) - Bump actions/stale (WordPress/gutenberg#78745) - Bump fast-xml-parser from 4.5.0 to 4.5.6 (WordPress/gutenberg#77167) - Bump actions/github-script from 8.0.0 to 9.0.0 in /.github/workflows (WordPress/gutenberg#78591) - @wordpress/theme: deduplicate addFallbackToVar helper (WordPress/gutenberg#78666) - Add Combobox primitives (WordPress/gutenberg#78399) - Editor: Fix keyboard activation of the template actions preview (WordPress/gutenberg#78641) - Theme: drop `density` support from `@wordpress/theme` (WordPress/gutenberg#78741) - Tooltip migration: fields + media-editor + media-fields + global-styles-ui (4/5) (WordPress/gutenberg#78691) - List View: Expose block visibility label to assistive technology (WordPress/gutenberg#78640) - Hide paragraph Drop cap control when a state is selected (WordPress/gutenberg#78672) - Image cropper: round zoom control values and display as percentages (WordPress/gutenberg#78757) - Media Editor Modal: Try placing the save and cancel buttons in the footer (WordPress/gutenberg#78708) - Unset grid span defaults with viewport states enabled (WordPress/gutenberg#78709) - Media Editor: Remove resize handles toggle from crop panel (WordPress/gutenberg#78758) - Image Editor: focus return after closing image crop modal (WordPress/gutenberg#78711) - Add dashboard Events widget (WordPress/gutenberg#78553) - Writing flow: Delete at end of nested list item should merge into next block (WordPress/gutenberg#78742) - RTC: Re-render collaborators overlay when the block tree changes (WordPress/gutenberg#78636) - Dashboard: rename `widget-types` to `widget-primitives` and consolidate the widget contract (WordPress/gutenberg#78749) - Fix Gutenberg plugin assuming its directory is named "gutenberg" (WordPress/gutenberg#78705) - Codemods: Remove one-shot Tooltip migration codemod (WordPress/gutenberg#78669) - Dashboard: rename `WidgetChrome` to `DashboardWidgetChrome` (WordPress/gutenberg#78751) - Paragraph: Strip stale block-support classes from className during align attribute migration (WordPress/gutenberg#78731) - Global Styles: Fix CSS not applying to Custom CSS textarea in Advanced panel (WordPress/gutenberg#78773) - scripts: Use require.resolve for SVG loaders to fix pnpm compat (WordPress/gutenberg#78777) - Post list: Remove close button from Quick Edit drawer (WordPress/gutenberg#78730) - Revert "Gate client-side media processing as plugin-only (WordPress/gutenberg#76700)" (WordPress/gutenberg#76751) - Tooltip migration: boot consumers + shell-level Tooltip.Provider (5/5) (WordPress/gutenberg#78692) - Dashboard: replace `surface` with `host` in widget contract docs (WordPress/gutenberg#78778) - Shortcode block: Fix editor crash when selecting transform menu (WordPress/gutenberg#78770) - Make `@wordpress/nux` a no-op compatibility package (WordPress/gutenberg#77773) - Tests: Temporarily disable REST index output-format assertions (WordPress/gutenberg#78788) - Hide Cover overlay controls for viewport states (WordPress/gutenberg#78763) - Fix type of `$block_instance` parameter in `block_core_image_render_lightbox()` (WordPress/gutenberg#78790) - TypeScript: Migrate server-side-render package to TS (WordPress/gutenberg#71383) - feat: Migrate performance results to tools release (WordPress/gutenberg#78761) - wp-build: Fix black flash on wp-admin pages before hydration (WordPress/gutenberg#78493) - Icons: maintain absolute stroke-width regardless of icon-size (WordPress/gutenberg#78774) - Dashboard: Use Howdy greeting for page title (WordPress/gutenberg#78740) - Block Editor: Refactor Inserter to a function component (WordPress/gutenberg#78766) - Dashboard: Move layout settings to customize toolbar (WordPress/gutenberg#78738) - Build: update changelog (WordPress/gutenberg#78807) - Icons: rename timeToRead to time (WordPress/gutenberg#78804) - RTC: Prevent slower polling filters (WordPress/gutenberg#78811) - Button.Icon: Fix clipped icons (WordPress/gutenberg#78614) - Bump docker/login-action (WordPress/gutenberg#78819) - RTC: Return forbidden rooms together (WordPress/gutenberg#78748) - Update browserslist (WordPress/gutenberg#78840) - Try allowing transforms to a variation of another block (WordPress/gutenberg#78713) - Elements: Guard against non-string className in render filter (WordPress/gutenberg#78841) - e2e-test-utils-playwright: add src to published NPM files (WordPress/gutenberg#78847) - Editor: Refactor 'PostPublishButton' into function component (WordPress/gutenberg#78737) - Dashboard: Promote WidgetRender into widget-primitives (WordPress/gutenberg#78821) - Notes: Show default avatar in the indicator when user avatars are disabled (WordPress/gutenberg#78849) - Revert "Icons: maintain absolute stroke-width regardless of icon-size (WordPress/gutenberg#78774)" (WordPress/gutenberg#78854) - Media: Send Document-Isolation-Policy header on the site preview frame (WordPress/gutenberg#78404) - Revert navigation morph & playlist commits pushed directly to trunk (WordPress/gutenberg#78857) - Fix Update button staying active when changes are reverted. (WordPress/gutenberg#78567) - Docs: Fix and improve documentation (WordPress/gutenberg#78686) - Abilities: Add validation tests pinning behavior for WP-specific schema keywords (WordPress/gutenberg#78783) - Tools: migrate docs/tool into tools/docs workspace (WordPress/gutenberg#78870) - Dashboard: Fix Add widget error on non-secure HTTP origins (WordPress/gutenberg#78850) - Docs: Fix @wordpress/data README fragment links (WordPress/gutenberg#78866) - bin: Remove obsolete bin/setup-local-env.sh (WordPress/gutenberg#78871) - Boot navigation: wrap items in a list role for valid listitem semantics (WordPress/gutenberg#78829) - wp-build: Document generated page hooks per WordPress standards. (WordPress/gutenberg#78826) - Update CODEOWNERS for tooling directories (WordPress/gutenberg#78874) - Block Visibility: Keep hide-everywhere working after a block opts out of visibility support (WordPress/gutenberg#78780) - Dashboard: Replace grid row height controls with size presets. (WordPress/gutenberg#78735) - Prevent font-size propagation in Navigation items causing `em` compounding (WordPress/gutenberg#77419) - Media Editor Modal: Reorder details fields so the editable regular layout fields appear at the top (WordPress/gutenberg#78792) - Fix media editor sidebar close button label (WordPress/gutenberg#78895) - Dashboard: event widget iteration (WordPress/gutenberg#78815) - Playlist Block: Add visualization style selector (WordPress/gutenberg#76147) - [Content Types]: Fix extra Page padding causing vertical scrollbar (WordPress/gutenberg#78661) - Remove migrated dependencies from root package.json (WordPress/gutenberg#78813) - Packages: Declare missing `@types/react` dependency (WordPress/gutenberg#78882) - Fix collapsed experiment cards not stretching to full width (WordPress/gutenberg#78910) - Element: add polyfills for render, hydrate, unmountComponentAtNode (WordPress/gutenberg#78899) - Revert "wp-build: Replace getter-based exports with data properties" (WordPress/gutenberg#78917) - React: add ReactCurrentOwner polyfill (WordPress/gutenberg#78923) - Fix playlist metadata edits recreating player (WordPress/gutenberg#78876) - Media Editor: Fix sidebar overflowing the modal between the small and medium breakpoints (WordPress/gutenberg#78931) - Media: Move client-side media compat file to wordpress-7.1 directory (WordPress/gutenberg#78852) - env: Replace extract-zip with adm-zip to fix hang on Node 24.16 (WordPress/gutenberg#78828) - Media Editor: refactor modal layout (WordPress/gutenberg#78896) - Optimize wp-env source downloads with Git partial clones (WordPress/gutenberg#78918) - Fix: Escape URLs in block render functions using `esc_url()` (WordPress/gutenberg#78912) - Blocks: Allow the Login/out block as an inner block in the Navigation Submenu block (WordPress/gutenberg#75497) - Fix sprintf format specifiers in post-date and read-more blocks (WordPress/gutenberg#78933) - Refactor: Remove jest/test deps from root package.json (WordPress/gutenberg#78801) - Upload Media: Add retry with exponential backoff and network resilience (WordPress/gutenberg#76765) - Build Scripts: Fix Windows path handling in dev script (WordPress/gutenberg#78939) - Revert React 19 upgrade (WordPress/gutenberg#78940) - Fix: block auto-complete for AI API Keys in Connectors (WordPress/gutenberg#78946) - Dashboard: Opinionated grid columns with container breakpoints (WordPress/gutenberg#78732) - Skip including inactive or experimental routes when building for WordPress Core (WordPress/gutenberg#76715) - RTC: Fix Yjs undo manager to update UI state when undo stack changes (WordPress/gutenberg#78864) - Storybook: Enhance Theme Provider example with admin-ui Page. (WordPress/gutenberg#78814) - RTC: Fix CRDT deferred updates resulting in jumbled typing (WordPress/gutenberg#78756) - Add playlist track length setting (WordPress/gutenberg#78954) - Add aspect ratio control to media editor mobile toolbar (WordPress/gutenberg#78935) - Media Editor: Replace the zoom slider with +/- buttons (WordPress/gutenberg#78928) - Use omit-unchanged for compressed-size-action (WordPress/gutenberg#78976) - DataViewsPicker: Add a new `pickerActivity` layout (WordPress/gutenberg#78941) - refactor: move babel dependencies to workspace configuration (WordPress/gutenberg#78974) - feat: Migrate the browserlintrc file to `packages/postcss-plugins-preset` (WordPress/gutenberg#78764) - Storybook: Declare workspace dependencies for theme example story. (WordPress/gutenberg#78979) - Refactor: Move React dependencies from root to workspaces (WordPress/gutenberg#78981) - UI: Update `@base-ui/react` to `1.5.0` (WordPress/gutenberg#78448) - ui/AlertDialog: Fix footer layout style override (WordPress/gutenberg#78953) - Font Library: Fix focus issue when navigating (WordPress/gutenberg#78671) - Docs: Auto-generate per-block API reference pages from block.json (WordPress/gutenberg#77612) - Patterns: fix focus loss when dismissing Create pattern dialog (WordPress/gutenberg#78957) - Show media upload progress in a snackbar (WordPress/gutenberg#77249) - Upload Media: Gate very large images out of client-side processing (WordPress/gutenberg#78949) - Media: Add UltraHDR (ISO 21496-1) gain map support (WordPress/gutenberg#74873) - Site Editor: Apply the user's admin color scheme (WordPress/gutenberg#78397) - Navigation Link: fix duplicate block html attributes in editor (WordPress/gutenberg#78973) - Added Missing Global Documentation (WordPress/gutenberg#78997) - Post Revisions: Upgrade `diff` from v4 to v8 (WordPress/gutenberg#77992) - Theme: Increase stroke1 contrast target to 2.9 (WordPress/gutenberg#77599) - Tooltip: Use md border radius for portaled popups. (WordPress/gutenberg#78983) - Framework: Remove invalid stale nested npm package references (WordPress/gutenberg#79014) - Theme package: Add element size design tokens (WordPress/gutenberg#76545) - Inserter: use forwardRef for refs (WordPress/gutenberg#79006) - RTC: Add separate doc persistence endpoint (WordPress/gutenberg#78891) - DataViews: Add DataViews components to components manifest (WordPress/gutenberg#78960) - Media Editor: Keep crop handles operable on large images (WordPress/gutenberg#79011) - Media editor: tweak paddings and margins (WordPress/gutenberg#79009) - Media Editor: Remove lag when toggling the sidebar (WordPress/gutenberg#79024) - Elements: Align class name parsing with custom CSS implementation (WordPress/gutenberg#79023) - CI: Suppress lint:js warnings on static checks (WordPress/gutenberg#79025) - Remove React Native implementation, framework, and dependencies (WordPress/gutenberg#78747) - e2e-test-utils-playwright: start transpiling again, but faster (WordPress/gutenberg#79026) - CI: Remove Validate Gradle Wrapper workflow (WordPress/gutenberg#79030) - Remove dead native code branches from Platform usages (WordPress/gutenberg#79031) - Remove orphaned README files for deleted native-only components (WordPress/gutenberg#79035) - Remove orphaned mobile bug report issue template (WordPress/gutenberg#79038) - Inserter: Fix error being thrown for spoken message when inserting default/direct block (WordPress/gutenberg#79004) - Editor: Remove dead native guard in block removal warnings (WordPress/gutenberg#79039) - Preserve nested list when deleting a selection across sibling list items (WordPress/gutenberg#78776) - Remove platform-docs Docusaurus site (WordPress/gutenberg#79034) - Align dependency versions across workspaces (WordPress/gutenberg#77954) - RichText: Remove dead native-only prop filtering (WordPress/gutenberg#79037) - Navigable Container: Hoist getFocusableContext out of the component (WordPress/gutenberg#79029) - Tools: Lint dependency version consistency with Syncpack (WordPress/gutenberg#77950) - Extract entity view config into a filterable API (WordPress/gutenberg#78977) - Rich text: use subscribeDelegatedListener for element event listeners (WordPress/gutenberg#79047) - theme/ThemeProvider: rename `color.bg` prop to `color.background` (WordPress/gutenberg#79007) - Format Library: Migrate to recommended `@wordpress/ui` components (WordPress/gutenberg#79059) - Syncpack: ban `classnames` from being reintroduced (WordPress/gutenberg#79061) - UI: Update CSS cascade layers to use nesting (WordPress/gutenberg#78959) - Docs: Remove stale mobile references from tooling and primitives docs (WordPress/gutenberg#79041) - Release: Drop mobile-specific changelog omit rules (WordPress/gutenberg#79042) - Bump actions/checkout (WordPress/gutenberg#79033) - `ColorPalette`: don't render when custom colors disabled and no colors passed (WordPress/gutenberg#72402) - Bump minimatch and lerna (WordPress/gutenberg#76750) - Image block: don't show crop icon while image is uploading (WordPress/gutenberg#79103) - Add React 19 as an experimental flag (WordPress/gutenberg#79077) - Media modal: small tweak to gutters (WordPress/gutenberg#79168) - Add more React internals polyfills (WordPress/gutenberg#79142) - Media editor modal: Fix keyboard resizing for locked aspect-ratio crops (WordPress/gutenberg#79207) - Fix responsive element styles front end output (WordPress/gutenberg#79135) (WordPress/gutenberg#79215) Props adamsilverstein, jorbin, westonruter, wildworks. Fixes #65368. Built from https://develop.svn.wordpress.org/trunk@62584 git-svn-id: http://core.svn.wordpress.org/trunk@61864 1a063a9b-81f0-0310-95a4-ce76da25c4cd
This updates the pinned commit hash of the Gutenberg repository from `14db4ab9395a9e96430eed678e4288a59eecbd15 ` (version `23.3.0`) to `14db4ab9395a9e96430eed678e4288a59eecbd15` (version `23.4.0`). A full list of changes included in this commit can be found on GitHub: https://github.com/WordPress/gutenberg/compare/v23.3.0..v23.4.0. The following commits are included: - Hide image dimension tools when a state is selected (WordPress/gutenberg#78670) - Changed labels to consistently use Patterns in favor of Block patterns (WordPress/gutenberg#56880) - Fix: Restrict parent page API search to post titles only (WordPress/gutenberg#78683) - Update AGENTS.md to mention additional pitfalls: (WordPress/gutenberg#78718) - Docs: Fix big_image_size_threshold xref typo (WordPress/gutenberg#76299) - Compose: Fully deprecate the 'pure' HoC (WordPress/gutenberg#78674) - Common CSS: avoid false-positive border-style on custom properties (WordPress/gutenberg#77476) - Compose: Fix SSR crash in useMediaQuery and useViewportMatch (WordPress/gutenberg#78725) - CI: Skip plugin repo release when SVN tag already exists (WordPress/gutenberg#78476) - Dashboard: Hello Dolly (WordPress/gutenberg#78648) - UI: `Tooltip.Provider` — forward upstream `closeDelay` and `timeout` props (WordPress/gutenberg#78642) - Compose: Support React 19 ref callback cleanups in `useMergeRefs` (WordPress/gutenberg#78685) - Add copilot-instructions.md file (WordPress/gutenberg#78584) - Dashboard: show ghost widgets visually & allow easy removal (WordPress/gutenberg#78502) - Bump fast-xml-builder from 1.0.0 to 1.2.0 (WordPress/gutenberg#78272) - Bump actions/stale (WordPress/gutenberg#78745) - Bump fast-xml-parser from 4.5.0 to 4.5.6 (WordPress/gutenberg#77167) - Bump actions/github-script from 8.0.0 to 9.0.0 in /.github/workflows (WordPress/gutenberg#78591) - @wordpress/theme: deduplicate addFallbackToVar helper (WordPress/gutenberg#78666) - Add Combobox primitives (WordPress/gutenberg#78399) - Editor: Fix keyboard activation of the template actions preview (WordPress/gutenberg#78641) - Theme: drop `density` support from `@wordpress/theme` (WordPress/gutenberg#78741) - Tooltip migration: fields + media-editor + media-fields + global-styles-ui (4/5) (WordPress/gutenberg#78691) - List View: Expose block visibility label to assistive technology (WordPress/gutenberg#78640) - Hide paragraph Drop cap control when a state is selected (WordPress/gutenberg#78672) - Image cropper: round zoom control values and display as percentages (WordPress/gutenberg#78757) - Media Editor Modal: Try placing the save and cancel buttons in the footer (WordPress/gutenberg#78708) - Unset grid span defaults with viewport states enabled (WordPress/gutenberg#78709) - Media Editor: Remove resize handles toggle from crop panel (WordPress/gutenberg#78758) - Image Editor: focus return after closing image crop modal (WordPress/gutenberg#78711) - Add dashboard Events widget (WordPress/gutenberg#78553) - Writing flow: Delete at end of nested list item should merge into next block (WordPress/gutenberg#78742) - RTC: Re-render collaborators overlay when the block tree changes (WordPress/gutenberg#78636) - Dashboard: rename `widget-types` to `widget-primitives` and consolidate the widget contract (WordPress/gutenberg#78749) - Fix Gutenberg plugin assuming its directory is named "gutenberg" (WordPress/gutenberg#78705) - Codemods: Remove one-shot Tooltip migration codemod (WordPress/gutenberg#78669) - Dashboard: rename `WidgetChrome` to `DashboardWidgetChrome` (WordPress/gutenberg#78751) - Paragraph: Strip stale block-support classes from className during align attribute migration (WordPress/gutenberg#78731) - Global Styles: Fix CSS not applying to Custom CSS textarea in Advanced panel (WordPress/gutenberg#78773) - scripts: Use require.resolve for SVG loaders to fix pnpm compat (WordPress/gutenberg#78777) - Post list: Remove close button from Quick Edit drawer (WordPress/gutenberg#78730) - Revert "Gate client-side media processing as plugin-only (WordPress/gutenberg#76700)" (WordPress/gutenberg#76751) - Tooltip migration: boot consumers + shell-level Tooltip.Provider (5/5) (WordPress/gutenberg#78692) - Dashboard: replace `surface` with `host` in widget contract docs (WordPress/gutenberg#78778) - Shortcode block: Fix editor crash when selecting transform menu (WordPress/gutenberg#78770) - Make `@wordpress/nux` a no-op compatibility package (WordPress/gutenberg#77773) - Tests: Temporarily disable REST index output-format assertions (WordPress/gutenberg#78788) - Hide Cover overlay controls for viewport states (WordPress/gutenberg#78763) - Fix type of `$block_instance` parameter in `block_core_image_render_lightbox()` (WordPress/gutenberg#78790) - TypeScript: Migrate server-side-render package to TS (WordPress/gutenberg#71383) - feat: Migrate performance results to tools release (WordPress/gutenberg#78761) - wp-build: Fix black flash on wp-admin pages before hydration (WordPress/gutenberg#78493) - Icons: maintain absolute stroke-width regardless of icon-size (WordPress/gutenberg#78774) - Dashboard: Use Howdy greeting for page title (WordPress/gutenberg#78740) - Block Editor: Refactor Inserter to a function component (WordPress/gutenberg#78766) - Dashboard: Move layout settings to customize toolbar (WordPress/gutenberg#78738) - Build: update changelog (WordPress/gutenberg#78807) - Icons: rename timeToRead to time (WordPress/gutenberg#78804) - RTC: Prevent slower polling filters (WordPress/gutenberg#78811) - Button.Icon: Fix clipped icons (WordPress/gutenberg#78614) - Bump docker/login-action (WordPress/gutenberg#78819) - RTC: Return forbidden rooms together (WordPress/gutenberg#78748) - Update browserslist (WordPress/gutenberg#78840) - Try allowing transforms to a variation of another block (WordPress/gutenberg#78713) - Elements: Guard against non-string className in render filter (WordPress/gutenberg#78841) - e2e-test-utils-playwright: add src to published NPM files (WordPress/gutenberg#78847) - Editor: Refactor 'PostPublishButton' into function component (WordPress/gutenberg#78737) - Dashboard: Promote WidgetRender into widget-primitives (WordPress/gutenberg#78821) - Notes: Show default avatar in the indicator when user avatars are disabled (WordPress/gutenberg#78849) - Revert "Icons: maintain absolute stroke-width regardless of icon-size (WordPress/gutenberg#78774)" (WordPress/gutenberg#78854) - Media: Send Document-Isolation-Policy header on the site preview frame (WordPress/gutenberg#78404) - Revert navigation morph & playlist commits pushed directly to trunk (WordPress/gutenberg#78857) - Fix Update button staying active when changes are reverted. (WordPress/gutenberg#78567) - Docs: Fix and improve documentation (WordPress/gutenberg#78686) - Abilities: Add validation tests pinning behavior for WP-specific schema keywords (WordPress/gutenberg#78783) - Tools: migrate docs/tool into tools/docs workspace (WordPress/gutenberg#78870) - Dashboard: Fix Add widget error on non-secure HTTP origins (WordPress/gutenberg#78850) - Docs: Fix @wordpress/data README fragment links (WordPress/gutenberg#78866) - bin: Remove obsolete bin/setup-local-env.sh (WordPress/gutenberg#78871) - Boot navigation: wrap items in a list role for valid listitem semantics (WordPress/gutenberg#78829) - wp-build: Document generated page hooks per WordPress standards. (WordPress/gutenberg#78826) - Update CODEOWNERS for tooling directories (WordPress/gutenberg#78874) - Block Visibility: Keep hide-everywhere working after a block opts out of visibility support (WordPress/gutenberg#78780) - Dashboard: Replace grid row height controls with size presets. (WordPress/gutenberg#78735) - Prevent font-size propagation in Navigation items causing `em` compounding (WordPress/gutenberg#77419) - Media Editor Modal: Reorder details fields so the editable regular layout fields appear at the top (WordPress/gutenberg#78792) - Fix media editor sidebar close button label (WordPress/gutenberg#78895) - Dashboard: event widget iteration (WordPress/gutenberg#78815) - Playlist Block: Add visualization style selector (WordPress/gutenberg#76147) - [Content Types]: Fix extra Page padding causing vertical scrollbar (WordPress/gutenberg#78661) - Remove migrated dependencies from root package.json (WordPress/gutenberg#78813) - Packages: Declare missing `@types/react` dependency (WordPress/gutenberg#78882) - Fix collapsed experiment cards not stretching to full width (WordPress/gutenberg#78910) - Element: add polyfills for render, hydrate, unmountComponentAtNode (WordPress/gutenberg#78899) - Revert "wp-build: Replace getter-based exports with data properties" (WordPress/gutenberg#78917) - React: add ReactCurrentOwner polyfill (WordPress/gutenberg#78923) - Fix playlist metadata edits recreating player (WordPress/gutenberg#78876) - Media Editor: Fix sidebar overflowing the modal between the small and medium breakpoints (WordPress/gutenberg#78931) - Media: Move client-side media compat file to wordpress-7.1 directory (WordPress/gutenberg#78852) - env: Replace extract-zip with adm-zip to fix hang on Node 24.16 (WordPress/gutenberg#78828) - Media Editor: refactor modal layout (WordPress/gutenberg#78896) - Optimize wp-env source downloads with Git partial clones (WordPress/gutenberg#78918) - Fix: Escape URLs in block render functions using `esc_url()` (WordPress/gutenberg#78912) - Blocks: Allow the Login/out block as an inner block in the Navigation Submenu block (WordPress/gutenberg#75497) - Fix sprintf format specifiers in post-date and read-more blocks (WordPress/gutenberg#78933) - Refactor: Remove jest/test deps from root package.json (WordPress/gutenberg#78801) - Upload Media: Add retry with exponential backoff and network resilience (WordPress/gutenberg#76765) - Build Scripts: Fix Windows path handling in dev script (WordPress/gutenberg#78939) - Revert React 19 upgrade (WordPress/gutenberg#78940) - Fix: block auto-complete for AI API Keys in Connectors (WordPress/gutenberg#78946) - Dashboard: Opinionated grid columns with container breakpoints (WordPress/gutenberg#78732) - Skip including inactive or experimental routes when building for WordPress Core (WordPress/gutenberg#76715) - RTC: Fix Yjs undo manager to update UI state when undo stack changes (WordPress/gutenberg#78864) - Storybook: Enhance Theme Provider example with admin-ui Page. (WordPress/gutenberg#78814) - RTC: Fix CRDT deferred updates resulting in jumbled typing (WordPress/gutenberg#78756) - Add playlist track length setting (WordPress/gutenberg#78954) - Add aspect ratio control to media editor mobile toolbar (WordPress/gutenberg#78935) - Media Editor: Replace the zoom slider with +/- buttons (WordPress/gutenberg#78928) - Use omit-unchanged for compressed-size-action (WordPress/gutenberg#78976) - DataViewsPicker: Add a new `pickerActivity` layout (WordPress/gutenberg#78941) - refactor: move babel dependencies to workspace configuration (WordPress/gutenberg#78974) - feat: Migrate the browserlintrc file to `packages/postcss-plugins-preset` (WordPress/gutenberg#78764) - Storybook: Declare workspace dependencies for theme example story. (WordPress/gutenberg#78979) - Refactor: Move React dependencies from root to workspaces (WordPress/gutenberg#78981) - UI: Update `@base-ui/react` to `1.5.0` (WordPress/gutenberg#78448) - ui/AlertDialog: Fix footer layout style override (WordPress/gutenberg#78953) - Font Library: Fix focus issue when navigating (WordPress/gutenberg#78671) - Docs: Auto-generate per-block API reference pages from block.json (WordPress/gutenberg#77612) - Patterns: fix focus loss when dismissing Create pattern dialog (WordPress/gutenberg#78957) - Show media upload progress in a snackbar (WordPress/gutenberg#77249) - Upload Media: Gate very large images out of client-side processing (WordPress/gutenberg#78949) - Media: Add UltraHDR (ISO 21496-1) gain map support (WordPress/gutenberg#74873) - Site Editor: Apply the user's admin color scheme (WordPress/gutenberg#78397) - Navigation Link: fix duplicate block html attributes in editor (WordPress/gutenberg#78973) - Added Missing Global Documentation (WordPress/gutenberg#78997) - Post Revisions: Upgrade `diff` from v4 to v8 (WordPress/gutenberg#77992) - Theme: Increase stroke1 contrast target to 2.9 (WordPress/gutenberg#77599) - Tooltip: Use md border radius for portaled popups. (WordPress/gutenberg#78983) - Framework: Remove invalid stale nested npm package references (WordPress/gutenberg#79014) - Theme package: Add element size design tokens (WordPress/gutenberg#76545) - Inserter: use forwardRef for refs (WordPress/gutenberg#79006) - RTC: Add separate doc persistence endpoint (WordPress/gutenberg#78891) - DataViews: Add DataViews components to components manifest (WordPress/gutenberg#78960) - Media Editor: Keep crop handles operable on large images (WordPress/gutenberg#79011) - Media editor: tweak paddings and margins (WordPress/gutenberg#79009) - Media Editor: Remove lag when toggling the sidebar (WordPress/gutenberg#79024) - Elements: Align class name parsing with custom CSS implementation (WordPress/gutenberg#79023) - CI: Suppress lint:js warnings on static checks (WordPress/gutenberg#79025) - Remove React Native implementation, framework, and dependencies (WordPress/gutenberg#78747) - e2e-test-utils-playwright: start transpiling again, but faster (WordPress/gutenberg#79026) - CI: Remove Validate Gradle Wrapper workflow (WordPress/gutenberg#79030) - Remove dead native code branches from Platform usages (WordPress/gutenberg#79031) - Remove orphaned README files for deleted native-only components (WordPress/gutenberg#79035) - Remove orphaned mobile bug report issue template (WordPress/gutenberg#79038) - Inserter: Fix error being thrown for spoken message when inserting default/direct block (WordPress/gutenberg#79004) - Editor: Remove dead native guard in block removal warnings (WordPress/gutenberg#79039) - Preserve nested list when deleting a selection across sibling list items (WordPress/gutenberg#78776) - Remove platform-docs Docusaurus site (WordPress/gutenberg#79034) - Align dependency versions across workspaces (WordPress/gutenberg#77954) - RichText: Remove dead native-only prop filtering (WordPress/gutenberg#79037) - Navigable Container: Hoist getFocusableContext out of the component (WordPress/gutenberg#79029) - Tools: Lint dependency version consistency with Syncpack (WordPress/gutenberg#77950) - Extract entity view config into a filterable API (WordPress/gutenberg#78977) - Rich text: use subscribeDelegatedListener for element event listeners (WordPress/gutenberg#79047) - theme/ThemeProvider: rename `color.bg` prop to `color.background` (WordPress/gutenberg#79007) - Format Library: Migrate to recommended `@wordpress/ui` components (WordPress/gutenberg#79059) - Syncpack: ban `classnames` from being reintroduced (WordPress/gutenberg#79061) - UI: Update CSS cascade layers to use nesting (WordPress/gutenberg#78959) - Docs: Remove stale mobile references from tooling and primitives docs (WordPress/gutenberg#79041) - Release: Drop mobile-specific changelog omit rules (WordPress/gutenberg#79042) - Bump actions/checkout (WordPress/gutenberg#79033) - `ColorPalette`: don't render when custom colors disabled and no colors passed (WordPress/gutenberg#72402) - Bump minimatch and lerna (WordPress/gutenberg#76750) - Image block: don't show crop icon while image is uploading (WordPress/gutenberg#79103) - Add React 19 as an experimental flag (WordPress/gutenberg#79077) - Media modal: small tweak to gutters (WordPress/gutenberg#79168) - Add more React internals polyfills (WordPress/gutenberg#79142) - Media editor modal: Fix keyboard resizing for locked aspect-ratio crops (WordPress/gutenberg#79207) - Fix responsive element styles front end output (WordPress/gutenberg#79135) (WordPress/gutenberg#79215) Props adamsilverstein, jorbin, westonruter, wildworks. Fixes #65368. git-svn-id: https://develop.svn.wordpress.org/trunk@62584 602fd350-edb4-49c9-b593-d223f7449a82
This updates the pinned commit hash of the Gutenberg repository from `14db4ab9395a9e96430eed678e4288a59eecbd15 ` (version `23.3.0`) to `14db4ab9395a9e96430eed678e4288a59eecbd15` (version `23.4.0`). A full list of changes included in this commit can be found on GitHub: https://github.com/WordPress/gutenberg/compare/v23.3.0..v23.4.0. The following commits are included: - Hide image dimension tools when a state is selected (WordPress/gutenberg#78670) - Changed labels to consistently use Patterns in favor of Block patterns (WordPress/gutenberg#56880) - Fix: Restrict parent page API search to post titles only (WordPress/gutenberg#78683) - Update AGENTS.md to mention additional pitfalls: (WordPress/gutenberg#78718) - Docs: Fix big_image_size_threshold xref typo (WordPress/gutenberg#76299) - Compose: Fully deprecate the 'pure' HoC (WordPress/gutenberg#78674) - Common CSS: avoid false-positive border-style on custom properties (WordPress/gutenberg#77476) - Compose: Fix SSR crash in useMediaQuery and useViewportMatch (WordPress/gutenberg#78725) - CI: Skip plugin repo release when SVN tag already exists (WordPress/gutenberg#78476) - Dashboard: Hello Dolly (WordPress/gutenberg#78648) - UI: `Tooltip.Provider` — forward upstream `closeDelay` and `timeout` props (WordPress/gutenberg#78642) - Compose: Support React 19 ref callback cleanups in `useMergeRefs` (WordPress/gutenberg#78685) - Add copilot-instructions.md file (WordPress/gutenberg#78584) - Dashboard: show ghost widgets visually & allow easy removal (WordPress/gutenberg#78502) - Bump fast-xml-builder from 1.0.0 to 1.2.0 (WordPress/gutenberg#78272) - Bump actions/stale (WordPress/gutenberg#78745) - Bump fast-xml-parser from 4.5.0 to 4.5.6 (WordPress/gutenberg#77167) - Bump actions/github-script from 8.0.0 to 9.0.0 in /.github/workflows (WordPress/gutenberg#78591) - @wordpress/theme: deduplicate addFallbackToVar helper (WordPress/gutenberg#78666) - Add Combobox primitives (WordPress/gutenberg#78399) - Editor: Fix keyboard activation of the template actions preview (WordPress/gutenberg#78641) - Theme: drop `density` support from `@wordpress/theme` (WordPress/gutenberg#78741) - Tooltip migration: fields + media-editor + media-fields + global-styles-ui (4/5) (WordPress/gutenberg#78691) - List View: Expose block visibility label to assistive technology (WordPress/gutenberg#78640) - Hide paragraph Drop cap control when a state is selected (WordPress/gutenberg#78672) - Image cropper: round zoom control values and display as percentages (WordPress/gutenberg#78757) - Media Editor Modal: Try placing the save and cancel buttons in the footer (WordPress/gutenberg#78708) - Unset grid span defaults with viewport states enabled (WordPress/gutenberg#78709) - Media Editor: Remove resize handles toggle from crop panel (WordPress/gutenberg#78758) - Image Editor: focus return after closing image crop modal (WordPress/gutenberg#78711) - Add dashboard Events widget (WordPress/gutenberg#78553) - Writing flow: Delete at end of nested list item should merge into next block (WordPress/gutenberg#78742) - RTC: Re-render collaborators overlay when the block tree changes (WordPress/gutenberg#78636) - Dashboard: rename `widget-types` to `widget-primitives` and consolidate the widget contract (WordPress/gutenberg#78749) - Fix Gutenberg plugin assuming its directory is named "gutenberg" (WordPress/gutenberg#78705) - Codemods: Remove one-shot Tooltip migration codemod (WordPress/gutenberg#78669) - Dashboard: rename `WidgetChrome` to `DashboardWidgetChrome` (WordPress/gutenberg#78751) - Paragraph: Strip stale block-support classes from className during align attribute migration (WordPress/gutenberg#78731) - Global Styles: Fix CSS not applying to Custom CSS textarea in Advanced panel (WordPress/gutenberg#78773) - scripts: Use require.resolve for SVG loaders to fix pnpm compat (WordPress/gutenberg#78777) - Post list: Remove close button from Quick Edit drawer (WordPress/gutenberg#78730) - Revert "Gate client-side media processing as plugin-only (WordPress/gutenberg#76700)" (WordPress/gutenberg#76751) - Tooltip migration: boot consumers + shell-level Tooltip.Provider (5/5) (WordPress/gutenberg#78692) - Dashboard: replace `surface` with `host` in widget contract docs (WordPress/gutenberg#78778) - Shortcode block: Fix editor crash when selecting transform menu (WordPress/gutenberg#78770) - Make `@wordpress/nux` a no-op compatibility package (WordPress/gutenberg#77773) - Tests: Temporarily disable REST index output-format assertions (WordPress/gutenberg#78788) - Hide Cover overlay controls for viewport states (WordPress/gutenberg#78763) - Fix type of `$block_instance` parameter in `block_core_image_render_lightbox()` (WordPress/gutenberg#78790) - TypeScript: Migrate server-side-render package to TS (WordPress/gutenberg#71383) - feat: Migrate performance results to tools release (WordPress/gutenberg#78761) - wp-build: Fix black flash on wp-admin pages before hydration (WordPress/gutenberg#78493) - Icons: maintain absolute stroke-width regardless of icon-size (WordPress/gutenberg#78774) - Dashboard: Use Howdy greeting for page title (WordPress/gutenberg#78740) - Block Editor: Refactor Inserter to a function component (WordPress/gutenberg#78766) - Dashboard: Move layout settings to customize toolbar (WordPress/gutenberg#78738) - Build: update changelog (WordPress/gutenberg#78807) - Icons: rename timeToRead to time (WordPress/gutenberg#78804) - RTC: Prevent slower polling filters (WordPress/gutenberg#78811) - Button.Icon: Fix clipped icons (WordPress/gutenberg#78614) - Bump docker/login-action (WordPress/gutenberg#78819) - RTC: Return forbidden rooms together (WordPress/gutenberg#78748) - Update browserslist (WordPress/gutenberg#78840) - Try allowing transforms to a variation of another block (WordPress/gutenberg#78713) - Elements: Guard against non-string className in render filter (WordPress/gutenberg#78841) - e2e-test-utils-playwright: add src to published NPM files (WordPress/gutenberg#78847) - Editor: Refactor 'PostPublishButton' into function component (WordPress/gutenberg#78737) - Dashboard: Promote WidgetRender into widget-primitives (WordPress/gutenberg#78821) - Notes: Show default avatar in the indicator when user avatars are disabled (WordPress/gutenberg#78849) - Revert "Icons: maintain absolute stroke-width regardless of icon-size (WordPress/gutenberg#78774)" (WordPress/gutenberg#78854) - Media: Send Document-Isolation-Policy header on the site preview frame (WordPress/gutenberg#78404) - Revert navigation morph & playlist commits pushed directly to trunk (WordPress/gutenberg#78857) - Fix Update button staying active when changes are reverted. (WordPress/gutenberg#78567) - Docs: Fix and improve documentation (WordPress/gutenberg#78686) - Abilities: Add validation tests pinning behavior for WP-specific schema keywords (WordPress/gutenberg#78783) - Tools: migrate docs/tool into tools/docs workspace (WordPress/gutenberg#78870) - Dashboard: Fix Add widget error on non-secure HTTP origins (WordPress/gutenberg#78850) - Docs: Fix @wordpress/data README fragment links (WordPress/gutenberg#78866) - bin: Remove obsolete bin/setup-local-env.sh (WordPress/gutenberg#78871) - Boot navigation: wrap items in a list role for valid listitem semantics (WordPress/gutenberg#78829) - wp-build: Document generated page hooks per WordPress standards. (WordPress/gutenberg#78826) - Update CODEOWNERS for tooling directories (WordPress/gutenberg#78874) - Block Visibility: Keep hide-everywhere working after a block opts out of visibility support (WordPress/gutenberg#78780) - Dashboard: Replace grid row height controls with size presets. (WordPress/gutenberg#78735) - Prevent font-size propagation in Navigation items causing `em` compounding (WordPress/gutenberg#77419) - Media Editor Modal: Reorder details fields so the editable regular layout fields appear at the top (WordPress/gutenberg#78792) - Fix media editor sidebar close button label (WordPress/gutenberg#78895) - Dashboard: event widget iteration (WordPress/gutenberg#78815) - Playlist Block: Add visualization style selector (WordPress/gutenberg#76147) - [Content Types]: Fix extra Page padding causing vertical scrollbar (WordPress/gutenberg#78661) - Remove migrated dependencies from root package.json (WordPress/gutenberg#78813) - Packages: Declare missing `@types/react` dependency (WordPress/gutenberg#78882) - Fix collapsed experiment cards not stretching to full width (WordPress/gutenberg#78910) - Element: add polyfills for render, hydrate, unmountComponentAtNode (WordPress/gutenberg#78899) - Revert "wp-build: Replace getter-based exports with data properties" (WordPress/gutenberg#78917) - React: add ReactCurrentOwner polyfill (WordPress/gutenberg#78923) - Fix playlist metadata edits recreating player (WordPress/gutenberg#78876) - Media Editor: Fix sidebar overflowing the modal between the small and medium breakpoints (WordPress/gutenberg#78931) - Media: Move client-side media compat file to wordpress-7.1 directory (WordPress/gutenberg#78852) - env: Replace extract-zip with adm-zip to fix hang on Node 24.16 (WordPress/gutenberg#78828) - Media Editor: refactor modal layout (WordPress/gutenberg#78896) - Optimize wp-env source downloads with Git partial clones (WordPress/gutenberg#78918) - Fix: Escape URLs in block render functions using `esc_url()` (WordPress/gutenberg#78912) - Blocks: Allow the Login/out block as an inner block in the Navigation Submenu block (WordPress/gutenberg#75497) - Fix sprintf format specifiers in post-date and read-more blocks (WordPress/gutenberg#78933) - Refactor: Remove jest/test deps from root package.json (WordPress/gutenberg#78801) - Upload Media: Add retry with exponential backoff and network resilience (WordPress/gutenberg#76765) - Build Scripts: Fix Windows path handling in dev script (WordPress/gutenberg#78939) - Revert React 19 upgrade (WordPress/gutenberg#78940) - Fix: block auto-complete for AI API Keys in Connectors (WordPress/gutenberg#78946) - Dashboard: Opinionated grid columns with container breakpoints (WordPress/gutenberg#78732) - Skip including inactive or experimental routes when building for WordPress Core (WordPress/gutenberg#76715) - RTC: Fix Yjs undo manager to update UI state when undo stack changes (WordPress/gutenberg#78864) - Storybook: Enhance Theme Provider example with admin-ui Page. (WordPress/gutenberg#78814) - RTC: Fix CRDT deferred updates resulting in jumbled typing (WordPress/gutenberg#78756) - Add playlist track length setting (WordPress/gutenberg#78954) - Add aspect ratio control to media editor mobile toolbar (WordPress/gutenberg#78935) - Media Editor: Replace the zoom slider with +/- buttons (WordPress/gutenberg#78928) - Use omit-unchanged for compressed-size-action (WordPress/gutenberg#78976) - DataViewsPicker: Add a new `pickerActivity` layout (WordPress/gutenberg#78941) - refactor: move babel dependencies to workspace configuration (WordPress/gutenberg#78974) - feat: Migrate the browserlintrc file to `packages/postcss-plugins-preset` (WordPress/gutenberg#78764) - Storybook: Declare workspace dependencies for theme example story. (WordPress/gutenberg#78979) - Refactor: Move React dependencies from root to workspaces (WordPress/gutenberg#78981) - UI: Update `@base-ui/react` to `1.5.0` (WordPress/gutenberg#78448) - ui/AlertDialog: Fix footer layout style override (WordPress/gutenberg#78953) - Font Library: Fix focus issue when navigating (WordPress/gutenberg#78671) - Docs: Auto-generate per-block API reference pages from block.json (WordPress/gutenberg#77612) - Patterns: fix focus loss when dismissing Create pattern dialog (WordPress/gutenberg#78957) - Show media upload progress in a snackbar (WordPress/gutenberg#77249) - Upload Media: Gate very large images out of client-side processing (WordPress/gutenberg#78949) - Media: Add UltraHDR (ISO 21496-1) gain map support (WordPress/gutenberg#74873) - Site Editor: Apply the user's admin color scheme (WordPress/gutenberg#78397) - Navigation Link: fix duplicate block html attributes in editor (WordPress/gutenberg#78973) - Added Missing Global Documentation (WordPress/gutenberg#78997) - Post Revisions: Upgrade `diff` from v4 to v8 (WordPress/gutenberg#77992) - Theme: Increase stroke1 contrast target to 2.9 (WordPress/gutenberg#77599) - Tooltip: Use md border radius for portaled popups. (WordPress/gutenberg#78983) - Framework: Remove invalid stale nested npm package references (WordPress/gutenberg#79014) - Theme package: Add element size design tokens (WordPress/gutenberg#76545) - Inserter: use forwardRef for refs (WordPress/gutenberg#79006) - RTC: Add separate doc persistence endpoint (WordPress/gutenberg#78891) - DataViews: Add DataViews components to components manifest (WordPress/gutenberg#78960) - Media Editor: Keep crop handles operable on large images (WordPress/gutenberg#79011) - Media editor: tweak paddings and margins (WordPress/gutenberg#79009) - Media Editor: Remove lag when toggling the sidebar (WordPress/gutenberg#79024) - Elements: Align class name parsing with custom CSS implementation (WordPress/gutenberg#79023) - CI: Suppress lint:js warnings on static checks (WordPress/gutenberg#79025) - Remove React Native implementation, framework, and dependencies (WordPress/gutenberg#78747) - e2e-test-utils-playwright: start transpiling again, but faster (WordPress/gutenberg#79026) - CI: Remove Validate Gradle Wrapper workflow (WordPress/gutenberg#79030) - Remove dead native code branches from Platform usages (WordPress/gutenberg#79031) - Remove orphaned README files for deleted native-only components (WordPress/gutenberg#79035) - Remove orphaned mobile bug report issue template (WordPress/gutenberg#79038) - Inserter: Fix error being thrown for spoken message when inserting default/direct block (WordPress/gutenberg#79004) - Editor: Remove dead native guard in block removal warnings (WordPress/gutenberg#79039) - Preserve nested list when deleting a selection across sibling list items (WordPress/gutenberg#78776) - Remove platform-docs Docusaurus site (WordPress/gutenberg#79034) - Align dependency versions across workspaces (WordPress/gutenberg#77954) - RichText: Remove dead native-only prop filtering (WordPress/gutenberg#79037) - Navigable Container: Hoist getFocusableContext out of the component (WordPress/gutenberg#79029) - Tools: Lint dependency version consistency with Syncpack (WordPress/gutenberg#77950) - Extract entity view config into a filterable API (WordPress/gutenberg#78977) - Rich text: use subscribeDelegatedListener for element event listeners (WordPress/gutenberg#79047) - theme/ThemeProvider: rename `color.bg` prop to `color.background` (WordPress/gutenberg#79007) - Format Library: Migrate to recommended `@wordpress/ui` components (WordPress/gutenberg#79059) - Syncpack: ban `classnames` from being reintroduced (WordPress/gutenberg#79061) - UI: Update CSS cascade layers to use nesting (WordPress/gutenberg#78959) - Docs: Remove stale mobile references from tooling and primitives docs (WordPress/gutenberg#79041) - Release: Drop mobile-specific changelog omit rules (WordPress/gutenberg#79042) - Bump actions/checkout (WordPress/gutenberg#79033) - `ColorPalette`: don't render when custom colors disabled and no colors passed (WordPress/gutenberg#72402) - Bump minimatch and lerna (WordPress/gutenberg#76750) - Image block: don't show crop icon while image is uploading (WordPress/gutenberg#79103) - Add React 19 as an experimental flag (WordPress/gutenberg#79077) - Media modal: small tweak to gutters (WordPress/gutenberg#79168) - Add more React internals polyfills (WordPress/gutenberg#79142) - Media editor modal: Fix keyboard resizing for locked aspect-ratio crops (WordPress/gutenberg#79207) - Fix responsive element styles front end output (WordPress/gutenberg#79135) (WordPress/gutenberg#79215) Props adamsilverstein, jorbin, westonruter, wildworks. Fixes #65368. git-svn-id: https://develop.svn.wordpress.org/trunk@62584 602fd350-edb4-49c9-b593-d223f7449a82
This updates the pinned commit hash of the Gutenberg repository from `14db4ab9395a9e96430eed678e4288a59eecbd15 ` (version `23.3.0`) to `14db4ab9395a9e96430eed678e4288a59eecbd15` (version `23.4.0`). A full list of changes included in this commit can be found on GitHub: https://github.com/WordPress/gutenberg/compare/v23.3.0..v23.4.0. The following commits are included: - Hide image dimension tools when a state is selected (WordPress/gutenberg#78670) - Changed labels to consistently use Patterns in favor of Block patterns (WordPress/gutenberg#56880) - Fix: Restrict parent page API search to post titles only (WordPress/gutenberg#78683) - Update AGENTS.md to mention additional pitfalls: (WordPress/gutenberg#78718) - Docs: Fix big_image_size_threshold xref typo (WordPress/gutenberg#76299) - Compose: Fully deprecate the 'pure' HoC (WordPress/gutenberg#78674) - Common CSS: avoid false-positive border-style on custom properties (WordPress/gutenberg#77476) - Compose: Fix SSR crash in useMediaQuery and useViewportMatch (WordPress/gutenberg#78725) - CI: Skip plugin repo release when SVN tag already exists (WordPress/gutenberg#78476) - Dashboard: Hello Dolly (WordPress/gutenberg#78648) - UI: `Tooltip.Provider` — forward upstream `closeDelay` and `timeout` props (WordPress/gutenberg#78642) - Compose: Support React 19 ref callback cleanups in `useMergeRefs` (WordPress/gutenberg#78685) - Add copilot-instructions.md file (WordPress/gutenberg#78584) - Dashboard: show ghost widgets visually & allow easy removal (WordPress/gutenberg#78502) - Bump fast-xml-builder from 1.0.0 to 1.2.0 (WordPress/gutenberg#78272) - Bump actions/stale (WordPress/gutenberg#78745) - Bump fast-xml-parser from 4.5.0 to 4.5.6 (WordPress/gutenberg#77167) - Bump actions/github-script from 8.0.0 to 9.0.0 in /.github/workflows (WordPress/gutenberg#78591) - @wordpress/theme: deduplicate addFallbackToVar helper (WordPress/gutenberg#78666) - Add Combobox primitives (WordPress/gutenberg#78399) - Editor: Fix keyboard activation of the template actions preview (WordPress/gutenberg#78641) - Theme: drop `density` support from `@wordpress/theme` (WordPress/gutenberg#78741) - Tooltip migration: fields + media-editor + media-fields + global-styles-ui (4/5) (WordPress/gutenberg#78691) - List View: Expose block visibility label to assistive technology (WordPress/gutenberg#78640) - Hide paragraph Drop cap control when a state is selected (WordPress/gutenberg#78672) - Image cropper: round zoom control values and display as percentages (WordPress/gutenberg#78757) - Media Editor Modal: Try placing the save and cancel buttons in the footer (WordPress/gutenberg#78708) - Unset grid span defaults with viewport states enabled (WordPress/gutenberg#78709) - Media Editor: Remove resize handles toggle from crop panel (WordPress/gutenberg#78758) - Image Editor: focus return after closing image crop modal (WordPress/gutenberg#78711) - Add dashboard Events widget (WordPress/gutenberg#78553) - Writing flow: Delete at end of nested list item should merge into next block (WordPress/gutenberg#78742) - RTC: Re-render collaborators overlay when the block tree changes (WordPress/gutenberg#78636) - Dashboard: rename `widget-types` to `widget-primitives` and consolidate the widget contract (WordPress/gutenberg#78749) - Fix Gutenberg plugin assuming its directory is named "gutenberg" (WordPress/gutenberg#78705) - Codemods: Remove one-shot Tooltip migration codemod (WordPress/gutenberg#78669) - Dashboard: rename `WidgetChrome` to `DashboardWidgetChrome` (WordPress/gutenberg#78751) - Paragraph: Strip stale block-support classes from className during align attribute migration (WordPress/gutenberg#78731) - Global Styles: Fix CSS not applying to Custom CSS textarea in Advanced panel (WordPress/gutenberg#78773) - scripts: Use require.resolve for SVG loaders to fix pnpm compat (WordPress/gutenberg#78777) - Post list: Remove close button from Quick Edit drawer (WordPress/gutenberg#78730) - Revert "Gate client-side media processing as plugin-only (WordPress/gutenberg#76700)" (WordPress/gutenberg#76751) - Tooltip migration: boot consumers + shell-level Tooltip.Provider (5/5) (WordPress/gutenberg#78692) - Dashboard: replace `surface` with `host` in widget contract docs (WordPress/gutenberg#78778) - Shortcode block: Fix editor crash when selecting transform menu (WordPress/gutenberg#78770) - Make `@wordpress/nux` a no-op compatibility package (WordPress/gutenberg#77773) - Tests: Temporarily disable REST index output-format assertions (WordPress/gutenberg#78788) - Hide Cover overlay controls for viewport states (WordPress/gutenberg#78763) - Fix type of `$block_instance` parameter in `block_core_image_render_lightbox()` (WordPress/gutenberg#78790) - TypeScript: Migrate server-side-render package to TS (WordPress/gutenberg#71383) - feat: Migrate performance results to tools release (WordPress/gutenberg#78761) - wp-build: Fix black flash on wp-admin pages before hydration (WordPress/gutenberg#78493) - Icons: maintain absolute stroke-width regardless of icon-size (WordPress/gutenberg#78774) - Dashboard: Use Howdy greeting for page title (WordPress/gutenberg#78740) - Block Editor: Refactor Inserter to a function component (WordPress/gutenberg#78766) - Dashboard: Move layout settings to customize toolbar (WordPress/gutenberg#78738) - Build: update changelog (WordPress/gutenberg#78807) - Icons: rename timeToRead to time (WordPress/gutenberg#78804) - RTC: Prevent slower polling filters (WordPress/gutenberg#78811) - Button.Icon: Fix clipped icons (WordPress/gutenberg#78614) - Bump docker/login-action (WordPress/gutenberg#78819) - RTC: Return forbidden rooms together (WordPress/gutenberg#78748) - Update browserslist (WordPress/gutenberg#78840) - Try allowing transforms to a variation of another block (WordPress/gutenberg#78713) - Elements: Guard against non-string className in render filter (WordPress/gutenberg#78841) - e2e-test-utils-playwright: add src to published NPM files (WordPress/gutenberg#78847) - Editor: Refactor 'PostPublishButton' into function component (WordPress/gutenberg#78737) - Dashboard: Promote WidgetRender into widget-primitives (WordPress/gutenberg#78821) - Notes: Show default avatar in the indicator when user avatars are disabled (WordPress/gutenberg#78849) - Revert "Icons: maintain absolute stroke-width regardless of icon-size (WordPress/gutenberg#78774)" (WordPress/gutenberg#78854) - Media: Send Document-Isolation-Policy header on the site preview frame (WordPress/gutenberg#78404) - Revert navigation morph & playlist commits pushed directly to trunk (WordPress/gutenberg#78857) - Fix Update button staying active when changes are reverted. (WordPress/gutenberg#78567) - Docs: Fix and improve documentation (WordPress/gutenberg#78686) - Abilities: Add validation tests pinning behavior for WP-specific schema keywords (WordPress/gutenberg#78783) - Tools: migrate docs/tool into tools/docs workspace (WordPress/gutenberg#78870) - Dashboard: Fix Add widget error on non-secure HTTP origins (WordPress/gutenberg#78850) - Docs: Fix @wordpress/data README fragment links (WordPress/gutenberg#78866) - bin: Remove obsolete bin/setup-local-env.sh (WordPress/gutenberg#78871) - Boot navigation: wrap items in a list role for valid listitem semantics (WordPress/gutenberg#78829) - wp-build: Document generated page hooks per WordPress standards. (WordPress/gutenberg#78826) - Update CODEOWNERS for tooling directories (WordPress/gutenberg#78874) - Block Visibility: Keep hide-everywhere working after a block opts out of visibility support (WordPress/gutenberg#78780) - Dashboard: Replace grid row height controls with size presets. (WordPress/gutenberg#78735) - Prevent font-size propagation in Navigation items causing `em` compounding (WordPress/gutenberg#77419) - Media Editor Modal: Reorder details fields so the editable regular layout fields appear at the top (WordPress/gutenberg#78792) - Fix media editor sidebar close button label (WordPress/gutenberg#78895) - Dashboard: event widget iteration (WordPress/gutenberg#78815) - Playlist Block: Add visualization style selector (WordPress/gutenberg#76147) - [Content Types]: Fix extra Page padding causing vertical scrollbar (WordPress/gutenberg#78661) - Remove migrated dependencies from root package.json (WordPress/gutenberg#78813) - Packages: Declare missing `@types/react` dependency (WordPress/gutenberg#78882) - Fix collapsed experiment cards not stretching to full width (WordPress/gutenberg#78910) - Element: add polyfills for render, hydrate, unmountComponentAtNode (WordPress/gutenberg#78899) - Revert "wp-build: Replace getter-based exports with data properties" (WordPress/gutenberg#78917) - React: add ReactCurrentOwner polyfill (WordPress/gutenberg#78923) - Fix playlist metadata edits recreating player (WordPress/gutenberg#78876) - Media Editor: Fix sidebar overflowing the modal between the small and medium breakpoints (WordPress/gutenberg#78931) - Media: Move client-side media compat file to wordpress-7.1 directory (WordPress/gutenberg#78852) - env: Replace extract-zip with adm-zip to fix hang on Node 24.16 (WordPress/gutenberg#78828) - Media Editor: refactor modal layout (WordPress/gutenberg#78896) - Optimize wp-env source downloads with Git partial clones (WordPress/gutenberg#78918) - Fix: Escape URLs in block render functions using `esc_url()` (WordPress/gutenberg#78912) - Blocks: Allow the Login/out block as an inner block in the Navigation Submenu block (WordPress/gutenberg#75497) - Fix sprintf format specifiers in post-date and read-more blocks (WordPress/gutenberg#78933) - Refactor: Remove jest/test deps from root package.json (WordPress/gutenberg#78801) - Upload Media: Add retry with exponential backoff and network resilience (WordPress/gutenberg#76765) - Build Scripts: Fix Windows path handling in dev script (WordPress/gutenberg#78939) - Revert React 19 upgrade (WordPress/gutenberg#78940) - Fix: block auto-complete for AI API Keys in Connectors (WordPress/gutenberg#78946) - Dashboard: Opinionated grid columns with container breakpoints (WordPress/gutenberg#78732) - Skip including inactive or experimental routes when building for WordPress Core (WordPress/gutenberg#76715) - RTC: Fix Yjs undo manager to update UI state when undo stack changes (WordPress/gutenberg#78864) - Storybook: Enhance Theme Provider example with admin-ui Page. (WordPress/gutenberg#78814) - RTC: Fix CRDT deferred updates resulting in jumbled typing (WordPress/gutenberg#78756) - Add playlist track length setting (WordPress/gutenberg#78954) - Add aspect ratio control to media editor mobile toolbar (WordPress/gutenberg#78935) - Media Editor: Replace the zoom slider with +/- buttons (WordPress/gutenberg#78928) - Use omit-unchanged for compressed-size-action (WordPress/gutenberg#78976) - DataViewsPicker: Add a new `pickerActivity` layout (WordPress/gutenberg#78941) - refactor: move babel dependencies to workspace configuration (WordPress/gutenberg#78974) - feat: Migrate the browserlintrc file to `packages/postcss-plugins-preset` (WordPress/gutenberg#78764) - Storybook: Declare workspace dependencies for theme example story. (WordPress/gutenberg#78979) - Refactor: Move React dependencies from root to workspaces (WordPress/gutenberg#78981) - UI: Update `@base-ui/react` to `1.5.0` (WordPress/gutenberg#78448) - ui/AlertDialog: Fix footer layout style override (WordPress/gutenberg#78953) - Font Library: Fix focus issue when navigating (WordPress/gutenberg#78671) - Docs: Auto-generate per-block API reference pages from block.json (WordPress/gutenberg#77612) - Patterns: fix focus loss when dismissing Create pattern dialog (WordPress/gutenberg#78957) - Show media upload progress in a snackbar (WordPress/gutenberg#77249) - Upload Media: Gate very large images out of client-side processing (WordPress/gutenberg#78949) - Media: Add UltraHDR (ISO 21496-1) gain map support (WordPress/gutenberg#74873) - Site Editor: Apply the user's admin color scheme (WordPress/gutenberg#78397) - Navigation Link: fix duplicate block html attributes in editor (WordPress/gutenberg#78973) - Added Missing Global Documentation (WordPress/gutenberg#78997) - Post Revisions: Upgrade `diff` from v4 to v8 (WordPress/gutenberg#77992) - Theme: Increase stroke1 contrast target to 2.9 (WordPress/gutenberg#77599) - Tooltip: Use md border radius for portaled popups. (WordPress/gutenberg#78983) - Framework: Remove invalid stale nested npm package references (WordPress/gutenberg#79014) - Theme package: Add element size design tokens (WordPress/gutenberg#76545) - Inserter: use forwardRef for refs (WordPress/gutenberg#79006) - RTC: Add separate doc persistence endpoint (WordPress/gutenberg#78891) - DataViews: Add DataViews components to components manifest (WordPress/gutenberg#78960) - Media Editor: Keep crop handles operable on large images (WordPress/gutenberg#79011) - Media editor: tweak paddings and margins (WordPress/gutenberg#79009) - Media Editor: Remove lag when toggling the sidebar (WordPress/gutenberg#79024) - Elements: Align class name parsing with custom CSS implementation (WordPress/gutenberg#79023) - CI: Suppress lint:js warnings on static checks (WordPress/gutenberg#79025) - Remove React Native implementation, framework, and dependencies (WordPress/gutenberg#78747) - e2e-test-utils-playwright: start transpiling again, but faster (WordPress/gutenberg#79026) - CI: Remove Validate Gradle Wrapper workflow (WordPress/gutenberg#79030) - Remove dead native code branches from Platform usages (WordPress/gutenberg#79031) - Remove orphaned README files for deleted native-only components (WordPress/gutenberg#79035) - Remove orphaned mobile bug report issue template (WordPress/gutenberg#79038) - Inserter: Fix error being thrown for spoken message when inserting default/direct block (WordPress/gutenberg#79004) - Editor: Remove dead native guard in block removal warnings (WordPress/gutenberg#79039) - Preserve nested list when deleting a selection across sibling list items (WordPress/gutenberg#78776) - Remove platform-docs Docusaurus site (WordPress/gutenberg#79034) - Align dependency versions across workspaces (WordPress/gutenberg#77954) - RichText: Remove dead native-only prop filtering (WordPress/gutenberg#79037) - Navigable Container: Hoist getFocusableContext out of the component (WordPress/gutenberg#79029) - Tools: Lint dependency version consistency with Syncpack (WordPress/gutenberg#77950) - Extract entity view config into a filterable API (WordPress/gutenberg#78977) - Rich text: use subscribeDelegatedListener for element event listeners (WordPress/gutenberg#79047) - theme/ThemeProvider: rename `color.bg` prop to `color.background` (WordPress/gutenberg#79007) - Format Library: Migrate to recommended `@wordpress/ui` components (WordPress/gutenberg#79059) - Syncpack: ban `classnames` from being reintroduced (WordPress/gutenberg#79061) - UI: Update CSS cascade layers to use nesting (WordPress/gutenberg#78959) - Docs: Remove stale mobile references from tooling and primitives docs (WordPress/gutenberg#79041) - Release: Drop mobile-specific changelog omit rules (WordPress/gutenberg#79042) - Bump actions/checkout (WordPress/gutenberg#79033) - `ColorPalette`: don't render when custom colors disabled and no colors passed (WordPress/gutenberg#72402) - Bump minimatch and lerna (WordPress/gutenberg#76750) - Image block: don't show crop icon while image is uploading (WordPress/gutenberg#79103) - Add React 19 as an experimental flag (WordPress/gutenberg#79077) - Media modal: small tweak to gutters (WordPress/gutenberg#79168) - Add more React internals polyfills (WordPress/gutenberg#79142) - Media editor modal: Fix keyboard resizing for locked aspect-ratio crops (WordPress/gutenberg#79207) - Fix responsive element styles front end output (WordPress/gutenberg#79135) (WordPress/gutenberg#79215) Props adamsilverstein, jorbin, westonruter, wildworks. Fixes #65368. git-svn-id: https://develop.svn.wordpress.org/trunk@62584 602fd350-edb4-49c9-b593-d223f7449a82


What?
Related to #75041
Declare
@types/react(and@types/react-domwhere applicable) as an explicit dependency in the packages that use React types but do not currently declare it.Why?
Many packages reference React types in their generated
build-types/declarations via inline imports likeimport('react').ReactNode, but do not declare@types/reactas a dependency. Today this resolves only because@types/reacthappens to be hoisted to the repo root, so the typings are found ambiently. That is fragile:@types/react, so those inline type imports fail to resolve. WithskipLibCheck: true(a common tsconfig setting) TypeScript silently falls back toany, effectively disabling type checking for the affected exports.node_modules/.store/install-strategy=linked, pnpm-style), packages can only resolve what they declare, so the types stop resolving entirely.A package should declare every module its published files reference. This is the same class of fix as #74310 ("Fix missing dependencies for packages") and #74655 (which did exactly this for
csstypein@wordpress/components).How?
For each affected package:
@types/reactis added todependencieswhen the package's emittedbuild-types/*.d.tsreference React types (so consumers can resolve them).@types/reactis added todevDependencieswhen React types are only used internally (not in the emitted declarations).@types/react-domis added wherereact-domtypes are used.No source or runtime changes; this only adds dependency declarations (and the corresponding
package-lock.json/CHANGELOG.mdentries).Testing Instructions
npm cinpm run buildand confirm the type build still passes.@types/reactfrom their own dependency tree rather than relying on root hoisting.Testing Instructions for Keyboard
N/A — dependency declaration changes only, no UI.
Screenshots or screencast
N/A.
Use of AI Tools
Used Claude Code to identify the packages whose generated types reference React without declaring
@types/react(by scanningbuild-types/) and to apply the declarations and changelog entries. The diff was reviewed before submission.