Repository navigation
Hide paragraph Drop Cap and Fit Text controls when a state is selected - #78672
Merged
Merged
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on top of #78670, so that should be merged first. Also lets check perf results before merging this. If it shows issues I can look at further optimizations.
What?
Hides the paragraph block's drop cap control when a responsive state (Mobile / Tablet) is selected.
Why?
Currently changing drop cap for a given viewport isn't supported, so this avoid confusion for users.
The drop cap implementation will need some improvements for it to be supported.
How?
Hides the control by checking the
hasSelectedStyleState, which was implemented in #78670.Testing Instructions
Screenshots or screencast
Use of AI Tools
OpenCode / Codex