Skip to content

Packages: Declare missing @types/react dependency #78882

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
manzoorwanijk merged 4 commits into from
Jun 3, 2026
Merged

Packages: Declare missing @types/react dependency #78882

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d2f73c0
Packages: Declare missing @types/react dependency
manzoorwanijk Jun 2, 2026
77f9b44
Add CHANGELOG entries for @types/react dependency
manzoorwanijk Jun 2, 2026
94f19c9
annotations: Fix package.json property order
manzoorwanijk Jun 2, 2026
42042bb
Add CHANGELOG.md for packages that lacked one
manzoorwanijk Jun 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
69 changes: 69 additions & 0 deletions package-lock.json
View file
Open in desktop

Large diffs are not rendered by default.

4 changes: 4 additions & 0 deletions packages/admin-ui/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,10 @@

## Unreleased

### Code Quality

- Add missing `@types/react` dependency. [#78882](https://github.com/WordPress/gutenberg/pull/78882).

## 2.2.0 (2026-05-27)

## 2.1.0 (2026-05-14)
Expand Down
1 change: 1 addition & 0 deletions packages/admin-ui/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,7 @@
"src/**/*.module.css"
],
"dependencies": {
"@types/react": "^19.2.13",
"@wordpress/components": "file:../components",
"@wordpress/element": "file:../element",
"@wordpress/i18n": "file:../i18n",
Expand Down
3 changes: 3 additions & 0 deletions packages/annotations/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,9 @@
"@wordpress/rich-text": "file:../rich-text",
"uuid": "^14.0.0"
},
"devDependencies": {
"@types/react": "^19.2.13"
},

@jsnajdr jsnajdr Jun 3, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The distinction between devDependencies and dependencies can get very subtle. This particular package uses React types internally (import type { ComponentType } from 'react';) but the trick is that this usage is not exported, the public .d.ts files don't reference it. The function that uses ComponentType is statically passed to addFilter.

This is fragile and can easily break unexpectedly. Locally everything is fine, because @types/react is still in node_modules, but a third party user of the NPM package won't get devDependencies installed.

What if we always put the types into dependencies?

@manzoorwanijk manzoorwanijk Jun 3, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I’m exploring a tool creation which skips installing devDeps and then tries to resolve imports in type defs. It should hopefully catch any missing dependencies.

"peerDependencies": {
"react": "^19.2.4"
},
Expand Down
4 changes: 4 additions & 0 deletions packages/block-editor/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,10 @@

## Unreleased

### Code Quality

- Add missing `@types/react` dependency. [#78882](https://github.com/WordPress/gutenberg/pull/78882).

### Documentation

- Fix documentation typos and grammar ([#78686](https://github.com/WordPress/gutenberg/pull/78686)).
Expand Down
1 change: 1 addition & 0 deletions packages/block-editor/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,7 @@
],
"dependencies": {
"@react-spring/web": "^9.4.5",
"@types/react": "^19.2.13",
"@wordpress/a11y": "file:../a11y",
"@wordpress/base-styles": "file:../base-styles",
"@wordpress/blob": "file:../blob",
Expand Down
4 changes: 4 additions & 0 deletions packages/block-library/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,10 @@

## Unreleased

### Code Quality

- Add missing `@types/react` dependency. [#78882](https://github.com/WordPress/gutenberg/pull/78882).

## 9.47.0 (2026-05-27)

### Internal
Expand Down
1 change: 1 addition & 0 deletions packages/block-library/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,6 +95,7 @@
],
"dependencies": {
"@arraypress/waveform-player": "1.2.1",
"@types/react": "^19.2.13",
"@wordpress/a11y": "file:../a11y",
"@wordpress/api-fetch": "file:../api-fetch",
"@wordpress/autop": "file:../autop",
Expand Down
4 changes: 4 additions & 0 deletions packages/blocks/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,10 @@

## Unreleased

### Code Quality

- Add missing `@types/react` dependency. [#78882](https://github.com/WordPress/gutenberg/pull/78882).

## 15.20.0 (2026-05-27)

### Bug Fix
Expand Down
1 change: 1 addition & 0 deletions packages/blocks/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,7 @@
"build-module/store/index.mjs"
],
"dependencies": {
"@types/react": "^19.2.13",
"@wordpress/autop": "file:../autop",
"@wordpress/blob": "file:../blob",
"@wordpress/block-serialization-default-parser": "file:../block-serialization-default-parser",
Expand Down
7 changes: 7 additions & 0 deletions packages/boot/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
<!-- Learn how to maintain this file at https://github.com/WordPress/gutenberg/tree/HEAD/packages#maintaining-changelogs. -->

## Unreleased

### Code Quality

- Add missing `@types/react` dependency. [#78882](https://github.com/WordPress/gutenberg/pull/78882).
1 change: 1 addition & 0 deletions packages/boot/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,7 @@
"wpScriptModuleExports": "./build-module/index.mjs",
"types": "build-types",
"dependencies": {
"@types/react": "^19.2.13",
Comment thread
manzoorwanijk marked this conversation as resolved.
"@wordpress/a11y": "file:../a11y",
"@wordpress/admin-ui": "file:../admin-ui",
"@wordpress/base-styles": "file:../base-styles",
Expand Down
1 change: 1 addition & 0 deletions packages/components/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,6 +110,7 @@
"@storybook/react-vite": "^10.2.8",
"@testing-library/jest-dom": "^6.9.1",
"@types/jest": "^29.5.14",
"@types/react-dom": "^19.2.3",

@aduth aduth Jun 2, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unsure if it's intentional, but we use 19.2.13 everywhere else.

Suggested change
"@types/react-dom": "^19.2.3",
"@types/react-dom": "^19.2.13",

@manzoorwanijk manzoorwanijk Jun 3, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is the version for @types/react, not @types/react-dom. For @types/react-dom, 19.2.3 is the latest version right now.

@aduth aduth Jun 3, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, my mistake, I missed react vs. react-dom 🤦

@aduth aduth Jun 3, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Separately, I'd be curious why we're using createPortal directly from react-dom rather than @wordpress/element, considering we already have element package imports in the file already 🤷

@manzoorwanijk manzoorwanijk Jun 3, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure about that.

@aduth aduth Jun 2, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@types/react-dom is also declared in dependencies above. We should probably do a pass across these packages to make sure we're not duplicating elsewhere.

Separately, this seems like something common enough and easy enough to test for in CI ? 🤔

@manzoorwanijk manzoorwanijk Jun 3, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, only @types/react is defined in dependencies.

"@wordpress/jest-console": "file:../jest-console",
"snapshot-diff": "^0.10.0",
"storybook": "^10.2.8",
Expand Down
4 changes: 4 additions & 0 deletions packages/compose/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,10 @@

## Unreleased

### Code Quality

- Add missing `@types/react` dependency. [#78882](https://github.com/WordPress/gutenberg/pull/78882).

### Documentation

- Fix documentation typos ([#78686](https://github.com/WordPress/gutenberg/pull/78686)).
Expand Down
1 change: 1 addition & 0 deletions packages/compose/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,7 @@
"sideEffects": false,
"dependencies": {
"@types/mousetrap": "^1.6.8",
"@types/react": "^19.2.13",
"@wordpress/deprecated": "file:../deprecated",
"@wordpress/dom": "file:../dom",
"@wordpress/element": "file:../element",
Expand Down
7 changes: 7 additions & 0 deletions packages/connectors/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
<!-- Learn how to maintain this file at https://github.com/WordPress/gutenberg/tree/HEAD/packages#maintaining-changelogs. -->

## Unreleased

### Code Quality

- Add missing `@types/react` dependency. [#78882](https://github.com/WordPress/gutenberg/pull/78882).
1 change: 1 addition & 0 deletions packages/connectors/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@
"wpScriptModuleExports": "./build-module/index.mjs",
"types": "build-types",
"dependencies": {
"@types/react": "^19.2.13",
"@wordpress/components": "file:../components",
"@wordpress/data": "file:../data",
"@wordpress/element": "file:../element",
Expand Down
7 changes: 7 additions & 0 deletions packages/content-types/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
<!-- Learn how to maintain this file at https://github.com/WordPress/gutenberg/tree/HEAD/packages#maintaining-changelogs. -->

## Unreleased

### Code Quality

- Add missing `@types/react` dependency. [#78882](https://github.com/WordPress/gutenberg/pull/78882).
1 change: 1 addition & 0 deletions packages/content-types/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@
"wpScriptModuleExports": "./build-module/index.mjs",
"types": "build-types",
"dependencies": {
"@types/react": "^19.2.13",
"@wordpress/admin-ui": "file:../admin-ui",
"@wordpress/base-styles": "file:../base-styles",
"@wordpress/components": "file:../components",
Expand Down
4 changes: 4 additions & 0 deletions packages/core-data/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,10 @@

## Unreleased

### Code Quality

- Add missing `@types/react` dependency. [#78882](https://github.com/WordPress/gutenberg/pull/78882).

## 7.47.0 (2026-05-27)

## 7.46.0 (2026-05-14)
Expand Down
1 change: 1 addition & 0 deletions packages/core-data/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,7 @@
"build-module/index.mjs"
],
"dependencies": {
"@types/react": "^19.2.13",
"@wordpress/api-fetch": "file:../api-fetch",
"@wordpress/block-editor": "file:../block-editor",
"@wordpress/blocks": "file:../blocks",
Expand Down
4 changes: 4 additions & 0 deletions packages/data/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,10 @@

## Unreleased

### Code Quality

- Add missing `@types/react` dependency. [#78882](https://github.com/WordPress/gutenberg/pull/78882).

## 10.47.0 (2026-05-27)

## 10.46.0 (2026-05-14)
Expand Down
1 change: 1 addition & 0 deletions packages/data/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,7 @@
"types": "build-types",
"sideEffects": false,
"dependencies": {
"@types/react": "^19.2.13",
"@wordpress/compose": "file:../compose",
"@wordpress/deprecated": "file:../deprecated",
"@wordpress/element": "file:../element",
Expand Down
4 changes: 4 additions & 0 deletions packages/dataviews/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,10 @@

## Unreleased

### Code Quality

- Add missing `@types/react` dependency. [#78882](https://github.com/WordPress/gutenberg/pull/78882).

## 15.0.0 (2026-05-27)

### Breaking Changes
Expand Down
1 change: 1 addition & 0 deletions packages/dataviews/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,7 @@
"sideEffects": false,
"dependencies": {
"@ariakit/react": "^0.4.21",
"@types/react": "^19.2.13",
"@wordpress/base-styles": "file:../base-styles",
"@wordpress/components": "file:../components",
"@wordpress/compose": "file:../compose",
Expand Down
4 changes: 4 additions & 0 deletions packages/editor/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,10 @@

## Unreleased

### Code Quality

- Add missing `@types/react` dependency. [#78882](https://github.com/WordPress/gutenberg/pull/78882).

### Documentation

- Fix documentation grammar ([#78686](https://github.com/WordPress/gutenberg/pull/78686)).
Expand Down
1 change: 1 addition & 0 deletions packages/editor/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,7 @@
"build-module/bindings/**"
],
"dependencies": {
"@types/react": "^19.2.13",
"@wordpress/a11y": "file:../a11y",
"@wordpress/api-fetch": "file:../api-fetch",
"@wordpress/base-styles": "file:../base-styles",
Expand Down
4 changes: 4 additions & 0 deletions packages/fields/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,10 @@

## Unreleased

### Code Quality

- Add missing `@types/react` dependency. [#78882](https://github.com/WordPress/gutenberg/pull/78882).

### Internal

- Migrate `Tooltip` consumers from `@wordpress/components` to the new compositional `Tooltip` in `@wordpress/ui` ([#78691](https://github.com/WordPress/gutenberg/pull/78691)).
Expand Down
1 change: 1 addition & 0 deletions packages/fields/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,7 @@
],
"dependencies": {
"@react-spring/web": "^9.4.5",
"@types/react": "^19.2.13",
"@wordpress/api-fetch": "file:../api-fetch",
"@wordpress/base-styles": "file:../base-styles",
"@wordpress/blob": "file:../blob",
Expand Down
7 changes: 7 additions & 0 deletions packages/global-styles-ui/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
<!-- Learn how to maintain this file at https://github.com/WordPress/gutenberg/tree/HEAD/packages#maintaining-changelogs. -->

## Unreleased

### Code Quality

- Add missing `@types/react` dependency. [#78882](https://github.com/WordPress/gutenberg/pull/78882).
1 change: 1 addition & 0 deletions packages/global-styles-ui/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,7 @@
},
"react-native": "src/index",
"dependencies": {
"@types/react": "^19.2.13",
"@wordpress/a11y": "file:../a11y",
"@wordpress/api-fetch": "file:../api-fetch",
"@wordpress/base-styles": "file:../base-styles",
Expand Down
4 changes: 4 additions & 0 deletions packages/grid/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,10 @@

## Unreleased

### Code Quality

- Add missing `@types/react` dependency. [#78882](https://github.com/WordPress/gutenberg/pull/78882).

### Enhancements

- Clamp tile resize so width cannot shrink below a single column
Expand Down
1 change: 1 addition & 0 deletions packages/grid/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,7 @@
"@dnd-kit/core": "^6.3.1",
"@dnd-kit/sortable": "^10.0.0",
"@dnd-kit/utilities": "^3.2.2",
"@types/react": "^19.2.13",
"@wordpress/compose": "file:../compose",
"@wordpress/element": "file:../element",
"@wordpress/style-runtime": "file:../style-runtime",
Expand Down
4 changes: 4 additions & 0 deletions packages/icons/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,10 @@

## Unreleased

### Code Quality

- Add missing `@types/react` dependency. [#78882](https://github.com/WordPress/gutenberg/pull/78882).

### Breaking Changes

- Rename `timeToRead` icon to `time`. ([#78804](https://github.com/WordPress/gutenberg/pull/78804))
Expand Down
1 change: 1 addition & 0 deletions packages/icons/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,7 @@
"types": "build-types",
"sideEffects": false,
"dependencies": {
"@types/react": "^19.2.13",
"@wordpress/element": "file:../element",
"@wordpress/primitives": "file:../primitives",
"change-case": "4.1.2"
Expand Down
4 changes: 4 additions & 0 deletions packages/image-cropper/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,10 @@

## Unreleased

### Code Quality

- Add missing `@types/react` dependency. [#78882](https://github.com/WordPress/gutenberg/pull/78882).

## 1.11.0 (2026-05-27)

## 1.10.0 (2026-05-14)
Expand Down
1 change: 1 addition & 0 deletions packages/image-cropper/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,7 @@
"types": "build-types",
"sideEffects": false,
"dependencies": {
"@types/react": "^19.2.13",
"@wordpress/components": "file:../components",
"@wordpress/element": "file:../element",
"@wordpress/i18n": "file:../i18n",
Expand Down
4 changes: 4 additions & 0 deletions packages/keyboard-shortcuts/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,10 @@

## Unreleased

### Code Quality

- Add missing `@types/react` dependency. [#78882](https://github.com/WordPress/gutenberg/pull/78882).

## 5.47.0 (2026-05-27)

## 5.46.0 (2026-05-14)
Expand Down
1 change: 1 addition & 0 deletions packages/keyboard-shortcuts/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,7 @@
"wpScript": true,
"types": "build-types/index.d.ts",
"dependencies": {
"@types/react": "^19.2.13",
"@wordpress/data": "file:../data",
"@wordpress/element": "file:../element",
"@wordpress/keycodes": "file:../keycodes"
Expand Down
4 changes: 4 additions & 0 deletions packages/keycodes/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,10 @@

## Unreleased

### Code Quality

- Add missing `@types/react` dependency. [#78882](https://github.com/WordPress/gutenberg/pull/78882).

### Documentation

- Fix documentation typos ([#78686](https://github.com/WordPress/gutenberg/pull/78686)).
Expand Down
1 change: 1 addition & 0 deletions packages/keycodes/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,7 @@
"types": "build-types",
"sideEffects": false,
"dependencies": {
"@types/react": "^19.2.13",
"@wordpress/i18n": "file:../i18n"
},
"publishConfig": {
Expand Down
4 changes: 4 additions & 0 deletions packages/lazy-editor/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,10 @@

## Unreleased

### Code Quality

- Add missing `@types/react` dependency. [#78882](https://github.com/WordPress/gutenberg/pull/78882).

## 1.13.0 (2026-05-27)

## 1.12.0 (2026-05-14)
Expand Down
1 change: 1 addition & 0 deletions packages/lazy-editor/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,7 @@
"wpScriptModuleExports": "./build-module/index.mjs",
"types": "build-types",
"dependencies": {
"@types/react": "^19.2.13",
"@wordpress/asset-loader": "file:../asset-loader",
"@wordpress/base-styles": "file:../base-styles",
"@wordpress/block-editor": "file:../block-editor",
Expand Down
4 changes: 4 additions & 0 deletions packages/list-reusable-blocks/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,10 @@

## Unreleased

### Code Quality

- Add missing `@types/react` dependency. [#78882](https://github.com/WordPress/gutenberg/pull/78882).

## 5.47.0 (2026-05-27)

### Internal
Expand Down
Loading
Loading