Repository navigation
Upgrade Playwright to v1.45 - #61443
Merged
Merged
Conversation
Mamaduka
added
the
[Type] Automated Testing
Mamaduka
requested review from
ajitbohra,
gziolo,
nerrad,
ntwb and
ryanwelcher
as code owners
May 7, 2024 11:31
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Mamaduka
requested review from
WunderBart,
kevin940726 and
swissspidy
and removed request for
ajitbohra,
nerrad,
ntwb and
ryanwelcher
May 7, 2024 11:31
Mamaduka
commented
May 7, 2024
Comment on lines
+65
to
+67
| await expect( navBlockNode ).toHaveAccessibleDescription( | ||
| /This block is locked./ | ||
| ); |
Member
Author
There was a problem hiding this comment.
@afercia, I think you'll like the new a11y assertions - https://github.com/microsoft/playwright/releases/tag/v1.44.0
Contributor
There was a problem hiding this comment.
Uhu, thanks for pointing me at it 🥳
|
Size Change: 0 B Total Size: 1.75 MB ℹ️ View Unchanged
|
swissspidy
approved these changes
May 7, 2024
Mamaduka
force-pushed
the
update/playwright-latest
branch
from
May 7, 2024 13:20
a516c99 to
5910db3
Compare
Member
Author
|
The RichText e2e tests seem to be failing on Firefox after the upgrade. I couldn't reproduce them manually, but I will continue debugging tomorrow. |
Member
Author
|
Some of the |
Mamaduka
force-pushed
the
update/playwright-latest
branch
from
May 31, 2024 08:10
5910db3 to
4cb1608
Compare
Member
@Mamaduka, I'm wondering if we should use |
Member
Author
|
@WunderBart, do you think there are changes in |
Member
I'm not sure, but considering that |
Mamaduka
force-pushed
the
update/playwright-latest
branch
from
June 26, 2024 07:08
4cb1608 to
bf80573
Compare
Member
Author
|
The same failures remain after the latest update; there might be an actual bug with Firefox and RichText. I'll try to debug it later.
@WunderBart, I don't think we can use |
Mamaduka
force-pushed
the
update/playwright-latest
branch
2 times, most recently
from
July 9, 2024 16:19
1ea26b9 to
52d459a
Compare
scruffian
pushed a commit
that referenced
this pull request
Jul 15, 2024
* Upgrade Playwright to v1.44 * Use new accessibility assertions * Bump to latest * Bump to v1.45 * Bump to v1.45.1 * Skip failing RichText tests on Firefox Co-authored-by: Mamaduka <mamaduka@git.wordpress.org> Co-authored-by: swissspidy <swissspidy@git.wordpress.org> Co-authored-by: afercia <afercia@git.wordpress.org> Co-authored-by: WunderBart <bartkalisz@git.wordpress.org> Co-authored-by: ellatrix <ellatrix@git.wordpress.org>
2 tasks done
carstingaxion
pushed a commit
to carstingaxion/gutenberg
that referenced
this pull request
Jul 18, 2024
* Upgrade Playwright to v1.44 * Use new accessibility assertions * Bump to latest * Bump to v1.45 * Bump to v1.45.1 * Skip failing RichText tests on Firefox Co-authored-by: Mamaduka <mamaduka@git.wordpress.org> Co-authored-by: swissspidy <swissspidy@git.wordpress.org> Co-authored-by: afercia <afercia@git.wordpress.org> Co-authored-by: WunderBart <bartkalisz@git.wordpress.org> Co-authored-by: ellatrix <ellatrix@git.wordpress.org>
desrosj
added a commit
to desrosj/gutenberg
that referenced
this pull request
Aug 31, 2026
… version. Playwright `1.49.1`'s newer Firefox engine behaves differently than the version this branch was last tested against for two `rich-text.spec.js` tests: "should return focus when pressing formatting button" and "should update internal selection after fresh focus". This is a real behavior difference in Firefox's focus/selection handling, not test flakiness. Both titles gain a `(-firefox)` suffix, which the `grepInvert: /-firefox/` project filter already configured in `test/e2e/playwright.config.ts` uses to exclude matching tests from the `firefox` project only — the tests still run normally on `chromium` and `webkit`. Ported from trunk's own `1.43.0` -> `1.45.1` Playwright upgrade (`de23bb92851806318267a657753d7acaff770d83`, WordPress#61443, "Upgrade Playwright to v1.45"), which hit the identical issue.
desrosj
added a commit
to desrosj/gutenberg
that referenced
this pull request
Aug 31, 2026
… test. `navigation-editor.spec.js` looked up a block's `aria-describedby` attribute by hand and then asserted on the text of the element it pointed to. Playwright `1.44` added `toHaveAccessibleDescription`, a built-in assertion that resolves the accessible description the same way assistive technology does, making the manual lookup unnecessary. `1.43.0`, this branch's previous pinned version, predates that API; `1.49.1` has it. Ported from trunk's own `1.43.0` -> `1.45.1` Playwright upgrade (`de23bb92851806318267a657753d7acaff770d83`, WordPress#61443, "Upgrade Playwright to v1.45"), which made the same swap for the same reason.
desrosj
added a commit
to desrosj/gutenberg
that referenced
this pull request
Sep 10, 2026
GitHub's `ubuntu-latest` runner now resolves to Ubuntu 24.04 ("Noble"). Playwright versions before `1.45` don't recognize Noble in their bundled OS-dependency lookup, so `npx playwright install --with-deps` in `end2end-test.yml`'s `e2e-playwright` job fails outright before any tests can run.
`1.49.1` is used as the target version rather than `1.45.1` (the version trunk originally moved to when it fixed this same problem, in [WordPress#61443](WordPress#61443)) because `1.49.1` is already proven working on this project's own `wp/6.8` branch's Playwright stack.
`.nvmrc`'s Node `20` already satisfies `1.49.1`'s Node >=18 floor, so no Node version bump is needed alongside this change.
desrosj
added a commit
to desrosj/gutenberg
that referenced
this pull request
Sep 11, 2026
GitHub's `ubuntu-latest` runner now resolves to Ubuntu 24.04 ("Noble"). Playwright versions before `1.45` don't recognize Noble in their bundled OS-dependency lookup, so `npx playwright install --with-deps` in `end2end-test.yml`'s `e2e-playwright` job fails outright before any tests can run.
`1.49.1` is used as the target version rather than `1.45.1` (the version trunk originally moved to when it fixed this same problem, in [WordPress#61443](WordPress#61443)) because `1.49.1` is already proven working on this project's own `wp/6.8` branch's Playwright stack.
`.nvmrc`'s Node `20` already satisfies `1.49.1`'s Node >=18 floor, so no Node version bump is needed alongside this change.
desrosj
added a commit
to desrosj/gutenberg
that referenced
this pull request
Sep 11, 2026
GitHub's `ubuntu-latest` runner now resolves to Ubuntu 24.04 ("Noble"). Playwright versions before `1.45` don't recognize Noble in their bundled OS-dependency lookup, so `npx playwright install --with-deps` in `end2end-test.yml`'s `e2e-playwright` job fails outright before any tests can run.
`1.49.1` is used as the target version rather than `1.45.1` (the version trunk originally moved to when it fixed this same problem, in [WordPress#61443](WordPress#61443)) because `1.49.1` is already proven working on this project's own `wp/6.8` branch's Playwright stack.
`.nvmrc`'s Node `20` already satisfies `1.49.1`'s Node >=18 floor, so no Node version bump is needed alongside this change.
desrosj
added a commit
to desrosj/gutenberg
that referenced
this pull request
Sep 11, 2026
GitHub's `ubuntu-latest` runner now resolves to Ubuntu 24.04 ("Noble"). Playwright versions before `1.45` don't recognize Noble in their bundled OS-dependency lookup, so `npx playwright install --with-deps` in `end2end-test.yml`'s `e2e-playwright` job fails outright before any tests can run.
`1.49.1` is used as the target version rather than `1.45.1` (the version trunk originally moved to when it fixed this same problem, in [WordPress#61443](WordPress#61443)) because `1.49.1` is already proven working on this project's own `wp/6.8` branch's Playwright stack.
`.nvmrc`'s Node `20` already satisfies `1.49.1`'s Node >=18 floor, so no Node version bump is needed alongside this change.
desrosj
added a commit
to desrosj/gutenberg
that referenced
this pull request
Sep 11, 2026
GitHub's `ubuntu-latest` runner now resolves to Ubuntu 24.04 ("Noble"). Playwright versions before `1.45` don't recognize Noble in their bundled OS-dependency lookup, so `npx playwright install --with-deps` in `end2end-test.yml`'s `e2e-playwright` job fails outright before any tests can run.
`1.49.1` is used as the target version rather than `1.45.1` (the version trunk originally moved to when it fixed this same problem, in [WordPress#61443](WordPress#61443)) because `1.49.1` is already proven working on this project's own `wp/6.8` branch's Playwright stack.
`.nvmrc`'s Node `20` already satisfies `1.49.1`'s Node >=18 floor, so no Node version bump is needed alongside this change.
desrosj
added a commit
to desrosj/gutenberg
that referenced
this pull request
Sep 11, 2026
GitHub's `ubuntu-latest` runner now resolves to Ubuntu 24.04 ("Noble"). Playwright versions before `1.45` don't recognize Noble in their bundled OS-dependency lookup, so `npx playwright install --with-deps` in `end2end-test.yml`'s `e2e-playwright` job fails outright before any tests can run.
`1.49.1` is used as the target version rather than `1.45.1` (the version trunk originally moved to when it fixed this same problem, in [WordPress#61443](WordPress#61443)) because `1.49.1` is already proven working on this project's own `wp/6.8` branch's Playwright stack.
`.nvmrc`'s Node `20` already satisfies `1.49.1`'s Node >=18 floor, so no Node version bump is needed alongside this change.
desrosj
added a commit
to desrosj/gutenberg
that referenced
this pull request
Sep 11, 2026
GitHub's `ubuntu-latest` runner now resolves to Ubuntu 24.04 ("Noble"). Playwright versions before `1.45` don't recognize Noble in their bundled OS-dependency lookup, so `npx playwright install --with-deps` in `end2end-test.yml`'s `e2e-playwright` job fails outright before any tests can run.
`1.49.1` is used as the target version rather than `1.45.1` (the version trunk originally moved to when it fixed this same problem, in [WordPress#61443](WordPress#61443)) because `1.49.1` is already proven working on this project's own `wp/6.8` branch's Playwright stack.
`.nvmrc`'s Node `20` already satisfies `1.49.1`'s Node >=18 floor, so no Node version bump is needed alongside this change.
desrosj
added a commit
to desrosj/gutenberg
that referenced
this pull request
Sep 11, 2026
GitHub's `ubuntu-24.04` runner ("Noble") isn't recognized by this branch's
pinned `@playwright/test@1.43.0` in its bundled OS-dependency lookup table, so
`npx playwright install --with-deps` fails with apt-get errors on renamed/
removed packages (libasound2, libffi7, libx264-163). Confirmed from a live
failing CI run (34612306207).
- Bumps `@playwright/test` (and transitive playwright/playwright-core) to
1.49.1, matching the version already proven on `wp/6.5` (#139) and `wp/6.8`.
- Ports two trunk test-file adaptations from
WordPress@de23bb9
(WordPress#61443): rich-text.spec.js gets a `(-firefox)` title
suffix on two Firefox-incompatible tests (exploiting playwright.config.ts's
`grepInvert: /-firefox/`), and navigation-editor.spec.js's manual
aria-describedby lookup becomes `toHaveAccessibleDescription`.
This branch already has an abandoned spike attempt at this exact fix,
`fix-actions-6.6/spike-playwright-noble` (#136), which correctly identified
this same set of changes but went stale after several newer layers were built
on top of the stack without it. This commit reimplements the same fix fresh
against the current top of the stack rather than reviving that branch; #136
is being closed and its branch deleted as part of this same change.
desrosj
added a commit
to desrosj/gutenberg
that referenced
this pull request
Sep 13, 2026
GitHub's `ubuntu-latest` runner now resolves to Ubuntu 24.04 ("Noble"). Playwright versions before `1.45` don't recognize Noble in their bundled OS-dependency lookup, so `npx playwright install --with-deps` in `end2end-test.yml`'s `e2e-playwright` job fails outright before any tests can run.
`1.49.1` is used as the target version rather than `1.45.1` (the version trunk originally moved to when it fixed this same problem, in [WordPress#61443](WordPress#61443)) because `1.49.1` is already proven working on this project's own `wp/6.8` branch's Playwright stack.
`.nvmrc`'s Node `20` already satisfies `1.49.1`'s Node >=18 floor, so no Node version bump is needed alongside this change.
desrosj
added a commit
to desrosj/gutenberg
that referenced
this pull request
Sep 13, 2026
GitHub's `ubuntu-latest` runner now resolves to Ubuntu 24.04 ("Noble"). Playwright versions before `1.45` don't recognize Noble in their bundled OS-dependency lookup, so `npx playwright install --with-deps` in `end2end-test.yml`'s `e2e-playwright` job fails outright before any tests can run.
`1.49.1` is used as the target version rather than `1.45.1` (the version trunk originally moved to when it fixed this same problem, in [WordPress#61443](WordPress#61443)) because `1.49.1` is already proven working on this project's own `wp/6.8` branch's Playwright stack.
`.nvmrc`'s Node `20` already satisfies `1.49.1`'s Node >=18 floor, so no Node version bump is needed alongside this change.
desrosj
added a commit
to desrosj/gutenberg
that referenced
this pull request
Sep 14, 2026
GitHub's `ubuntu-24.04` runner ("Noble") isn't recognized by this branch's
pinned `@playwright/test@1.43.0` in its bundled OS-dependency lookup table, so
`npx playwright install --with-deps` fails with apt-get errors on renamed/
removed packages (libasound2, libffi7, libx264-163). Confirmed from a live
failing CI run (34612306207).
- Bumps `@playwright/test` (and transitive playwright/playwright-core) to
1.49.1, matching the version already proven on `wp/6.5` (#139) and `wp/6.8`.
- Ports two trunk test-file adaptations from
WordPress@de23bb9
(WordPress#61443): rich-text.spec.js gets a `(-firefox)` title
suffix on two Firefox-incompatible tests (exploiting playwright.config.ts's
`grepInvert: /-firefox/`), and navigation-editor.spec.js's manual
aria-describedby lookup becomes `toHaveAccessibleDescription`.
This branch already has an abandoned spike attempt at this exact fix,
`fix-actions-6.6/spike-playwright-noble` (#136), which correctly identified
this same set of changes but went stale after several newer layers were built
on top of the stack without it. This commit reimplements the same fix fresh
against the current top of the stack rather than reviving that branch; #136
is being closed and its branch deleted as part of this same change.
desrosj
added a commit
to desrosj/gutenberg
that referenced
this pull request
Sep 14, 2026
GitHub's `ubuntu-latest` runner now resolves to Ubuntu 24.04 ("Noble"). Playwright versions before `1.45` don't recognize Noble in their bundled OS-dependency lookup, so `npx playwright install --with-deps` in `end2end-test.yml`'s `e2e-playwright` job fails outright before any tests can run.
`1.49.1` is used as the target version rather than `1.45.1` (the version trunk originally moved to when it fixed this same problem, in [WordPress#61443](WordPress#61443)) because `1.49.1` is already proven working on this project's own `wp/6.8` branch's Playwright stack.
`.nvmrc`'s Node `20` already satisfies `1.49.1`'s Node >=18 floor, so no Node version bump is needed alongside this change.
desrosj
added a commit
to desrosj/gutenberg
that referenced
this pull request
Sep 14, 2026
GitHub's `ubuntu-latest` runner now resolves to Ubuntu 24.04 ("Noble"). Playwright versions before `1.45` don't recognize Noble in their bundled OS-dependency lookup, so `npx playwright install --with-deps` in `end2end-test.yml`'s `e2e-playwright` job fails outright before any tests can run.
`1.49.1` is used as the target version rather than `1.45.1` (the version trunk originally moved to when it fixed this same problem, in [WordPress#61443](WordPress#61443)) because `1.49.1` is already proven working on this project's own `wp/6.8` branch's Playwright stack.
`.nvmrc`'s Node `20` already satisfies `1.49.1`'s Node >=18 floor, so no Node version bump is needed alongside this change.
desrosj
added a commit
to desrosj/gutenberg
that referenced
this pull request
Sep 14, 2026
GitHub's `ubuntu-24.04` runner ("Noble") isn't recognized by this branch's
pinned `@playwright/test@1.43.0` in its bundled OS-dependency lookup table, so
`npx playwright install --with-deps` fails with apt-get errors on renamed/
removed packages (libasound2, libffi7, libx264-163). Confirmed from a live
failing CI run (34612306207).
- Bumps `@playwright/test` (and transitive playwright/playwright-core) to
1.49.1, matching the version already proven on `wp/6.5` (#139) and `wp/6.8`.
- Ports two trunk test-file adaptations from
WordPress@de23bb9
(WordPress#61443): rich-text.spec.js gets a `(-firefox)` title
suffix on two Firefox-incompatible tests (exploiting playwright.config.ts's
`grepInvert: /-firefox/`), and navigation-editor.spec.js's manual
aria-describedby lookup becomes `toHaveAccessibleDescription`.
This branch already has an abandoned spike attempt at this exact fix,
`fix-actions-6.6/spike-playwright-noble` (#136), which correctly identified
this same set of changes but went stale after several newer layers were built
on top of the stack without it. This commit reimplements the same fix fresh
against the current top of the stack rather than reviving that branch; #136
is being closed and its branch deleted as part of this same change.
desrosj
added a commit
to desrosj/gutenberg
that referenced
this pull request
Sep 15, 2026
GitHub's `ubuntu-24.04` runner ("Noble") isn't recognized by this branch's
pinned `@playwright/test@1.43.0` in its bundled OS-dependency lookup table, so
`npx playwright install --with-deps` fails with apt-get errors on renamed/
removed packages (libasound2, libffi7, libx264-163). Confirmed from a live
failing CI run (34612306207).
- Bumps `@playwright/test` (and transitive playwright/playwright-core) to
1.49.1, matching the version already proven on `wp/6.5` (#139) and `wp/6.8`.
- Ports two trunk test-file adaptations from
WordPress@de23bb9
(WordPress#61443): rich-text.spec.js gets a `(-firefox)` title
suffix on two Firefox-incompatible tests (exploiting playwright.config.ts's
`grepInvert: /-firefox/`), and navigation-editor.spec.js's manual
aria-describedby lookup becomes `toHaveAccessibleDescription`.
This branch already has an abandoned spike attempt at this exact fix,
`fix-actions-6.6/spike-playwright-noble` (#136), which correctly identified
this same set of changes but went stale after several newer layers were built
on top of the stack without it. This commit reimplements the same fix fresh
against the current top of the stack rather than reviving that branch; #136
is being closed and its branch deleted as part of this same change.
desrosj
added a commit
to desrosj/gutenberg
that referenced
this pull request
Sep 15, 2026
GitHub's `ubuntu-24.04` runner ("Noble") isn't recognized by this branch's
pinned `@playwright/test@1.43.0` in its bundled OS-dependency lookup table, so
`npx playwright install --with-deps` fails with apt-get errors on renamed/
removed packages (libasound2, libffi7, libx264-163). Confirmed from a live
failing CI run (34612306207).
- Bumps `@playwright/test` (and transitive playwright/playwright-core) to
1.49.1, matching the version already proven on `wp/6.5` (#139) and `wp/6.8`.
- Ports two trunk test-file adaptations from
WordPress@de23bb9
(WordPress#61443): rich-text.spec.js gets a `(-firefox)` title
suffix on two Firefox-incompatible tests (exploiting playwright.config.ts's
`grepInvert: /-firefox/`), and navigation-editor.spec.js's manual
aria-describedby lookup becomes `toHaveAccessibleDescription`.
This branch already has an abandoned spike attempt at this exact fix,
`fix-actions-6.6/spike-playwright-noble` (#136), which correctly identified
this same set of changes but went stale after several newer layers were built
on top of the stack without it. This commit reimplements the same fix fresh
against the current top of the stack rather than reviving that branch; #136
is being closed and its branch deleted as part of this same change.
desrosj
added a commit
to desrosj/gutenberg
that referenced
this pull request
Sep 15, 2026
GitHub's `ubuntu-24.04` runner ("Noble") isn't recognized by this branch's
pinned `@playwright/test@1.43.0` in its bundled OS-dependency lookup table, so
`npx playwright install --with-deps` fails with apt-get errors on renamed/
removed packages (libasound2, libffi7, libx264-163). Confirmed from a live
failing CI run (34612306207).
- Bumps `@playwright/test` (and transitive playwright/playwright-core) to
1.49.1, matching the version already proven on `wp/6.5` (#139) and `wp/6.8`.
- Ports two trunk test-file adaptations from
WordPress@de23bb9
(WordPress#61443): rich-text.spec.js gets a `(-firefox)` title
suffix on two Firefox-incompatible tests (exploiting playwright.config.ts's
`grepInvert: /-firefox/`), and navigation-editor.spec.js's manual
aria-describedby lookup becomes `toHaveAccessibleDescription`.
This branch already has an abandoned spike attempt at this exact fix,
`fix-actions-6.6/spike-playwright-noble` (#136), which correctly identified
this same set of changes but went stale after several newer layers were built
on top of the stack without it. This commit reimplements the same fix fresh
against the current top of the stack rather than reviving that branch; #136
is being closed and its branch deleted as part of this same change.
desrosj
added a commit
to desrosj/gutenberg
that referenced
this pull request
Sep 15, 2026
GitHub's `ubuntu-latest` runner now resolves to Ubuntu 24.04 ("Noble"). Playwright versions before `1.45` don't recognize Noble in their bundled OS-dependency lookup, so `npx playwright install --with-deps` in `end2end-test.yml`'s `e2e-playwright` job fails outright before any tests can run.
`1.49.1` is used as the target version rather than `1.45.1` (the version trunk originally moved to when it fixed this same problem, in [WordPress#61443](WordPress#61443)) because `1.49.1` is already proven working on this project's own `wp/6.8` branch's Playwright stack.
`.nvmrc`'s Node `20` already satisfies `1.49.1`'s Node >=18 floor, so no Node version bump is needed alongside this change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Upgrade Playwright to v1.45
What's new?
https://github.com/microsoft/playwright/releases/tag/v1.44.0
https://github.com/microsoft/playwright/releases/tag/v1.45.0
Testing Instructions