Repository navigation
Conversation
desrosj
force-pushed
the
fix-actions-6.6/fix-playwright-noble-install
branch
from
September 11, 2026 16:11
19f4c91 to
cbdc29c
Compare
desrosj
force-pushed
the
fix-actions-6.6/fix-playwright-noble-install
branch
from
September 14, 2026 01:36
cbdc29c to
f9dac71
Compare
desrosj
force-pushed
the
fix-actions-6.6/fix-playwright-noble-install
branch
from
September 14, 2026 19:19
f9dac71 to
711c25f
Compare
desrosj
marked this pull request as ready for review
September 15, 2026 00:02
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Warning: Type of PR label mismatch To merge this PR, it requires exactly 1 label indicating the type of PR. Other labels are optional and not being checked here.
Read more about Type labels in Gutenberg. Don't worry if you don't have the required permissions to add labels; the PR reviewer should be able to help with the task. |
desrosj
force-pushed
the
fix-actions-6.6/fix-playwright-noble-install
branch
from
September 15, 2026 00:12
711c25f to
668bf9a
Compare
desrosj
force-pushed
the
fix-actions-6.6/fix-playwright-noble-install
branch
from
September 15, 2026 00:27
668bf9a to
726c87c
Compare
GitHub's `ubuntu-24.04` runner ("Noble") isn't recognized by this branch's
pinned `@playwright/test@1.43.0` in its bundled OS-dependency lookup table, so
`npx playwright install --with-deps` fails with apt-get errors on renamed/
removed packages (libasound2, libffi7, libx264-163). Confirmed from a live
failing CI run (34612306207).
- Bumps `@playwright/test` (and transitive playwright/playwright-core) to
1.49.1, matching the version already proven on `wp/6.5` (#139) and `wp/6.8`.
- Ports two trunk test-file adaptations from
WordPress@de23bb9
(WordPress#61443): rich-text.spec.js gets a `(-firefox)` title
suffix on two Firefox-incompatible tests (exploiting playwright.config.ts's
`grepInvert: /-firefox/`), and navigation-editor.spec.js's manual
aria-describedby lookup becomes `toHaveAccessibleDescription`.
This branch already has an abandoned spike attempt at this exact fix,
`fix-actions-6.6/spike-playwright-noble` (#136), which correctly identified
this same set of changes but went stale after several newer layers were built
on top of the stack without it. This commit reimplements the same fix fresh
against the current top of the stack rather than reviving that branch; #136
is being closed and its branch deleted as part of this same change.
desrosj
force-pushed
the
fix-actions-6.6/fix-playwright-noble-install
branch
from
September 15, 2026 00:42
726c87c to
db725b2
Compare
Owner
Author
|
Migrated to real upstream: WordPress#82926. Closing this fork PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Bumps
@playwright/testto1.49.1and ports two trunk test-file adaptations (rich-text.spec.js,navigation-editor.spec.js) so End-to-End Tests can run onubuntu-24.04("Noble") runners.Why?
Confirmed from a live failing CI run (34612306207): Playwright's browser install fails with
apt-geterrors on packages renamed/removed on Noble (libasound2,libffi7,libx264-163), because this branch's pinned@playwright/test@1.43.0predates Playwright's Noble support (added in1.45). This is the same root cause already fixed onwp/6.5via #139, and matches the approach ported from trunk commitde23bb92851806318267a657753d7acaff770d83(WordPress/gutenberg#61443).This supersedes the abandoned spike PR #136, which correctly identified this same fix but went stale after several newer stack layers were built without it — this PR reimplements the same three changes fresh against the current top of the stack instead of reviving that branch.
Use of AI Tools
This PR was created by Claude Code under my supervision. All code should be treated as AI-produced and not yet reviewed by a human until this PR is marked Ready for Review.