Conversation
📝 WalkthroughWalkthrough광고 플랫폼별 예산 수정과 상태 관리, 플랫폼 광고 데이터 동기화, 공유 AI 리포트 재사용, 워크스페이스 소유권 양도, 타임라인 및 설정 화면의 반응형 UI가 추가 또는 변경되었습니다. Changes광고 관리 및 예산 기능
플랫폼 동기화와 AI 분석
워크스페이스 소유권과 멤버 관리
타임라인과 설정 UI
Estimated code review effort: 5 (Critical) | ~120 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (3 passed)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 11
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (3)
src/components/landing/GuideTimeline.tsx (1)
22-34: 📐 Maintainability & Code Quality | 🟠 Major | ⚡ Quick win컴포넌트 내부
<style>를 공용 스크롤바 유틸리티로 옮겨 주세요.
src/components/landing/GuideTimeline.tsx:22에는 TSX 파일 내부에 인라인 CSS가 들어갑니다.custom-scrollbar스타일을src/styles/utilities.css에 공용 클래스로 정의하고,GuideTimeline에서는 해당 클래스만 사용하도록 변경하세요.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@src/components/landing/GuideTimeline.tsx` around lines 22 - 34, Move the custom-scrollbar rules from the inline style block in GuideTimeline into the shared utilities stylesheet, defining the reusable utility class there. Remove the component-level style block and update GuideTimeline to rely only on the shared custom-scrollbar class.Source: Coding guidelines
src/pages/ads/list/CampaignDetail.tsx (1)
59-68: 🩺 Stability & Availability | 🟡 Minor | ⚡ Quick win
Number()변환 결과가NaN일 수 있습니다.경로 파라미터가 숫자가 아니면
orgIdNum과projectIdNum은NaN이 됩니다.NaN은null이 아닙니다. 결과는 다음과 같습니다.
useUpdateAdStatus의orgId == null가드를 통과합니다.NaN이 요청 URL에 그대로 들어갑니다.- Line 481의
orgIdNum != null조건을 통과합니다.EditPlatformBudgetModal이NaN을 받습니다.
useAdList는Number.isFinite검사를 하므로 조회만 막힙니다. 변경 요청은 막히지 않습니다. 변환 지점에서 한 번에 정규화해 주세요.🛠 제안 diff
- const orgIdNum = orgId ? Number(orgId) : null; - const projectIdNum = projectId ? Number(projectId) : null; + const toPositiveId = (value?: string) => { + const parsed = value ? Number(value) : NaN; + return Number.isFinite(parsed) && parsed > 0 ? parsed : null; + }; + const orgIdNum = toPositiveId(orgId); + const projectIdNum = toPositiveId(projectId);🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@src/pages/ads/list/CampaignDetail.tsx` around lines 59 - 68, Normalize orgIdNum and projectIdNum at their conversion points so non-numeric path parameters become null rather than NaN. Update the declarations near useCampaignDetail, useAdList, and useUpdateAdStatus to use finite-number validation, preserving valid numeric IDs and ensuring downstream orgId == null and orgIdNum != null guards reject invalid values.src/components/ads/AdListTable.tsx (1)
87-95: 📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win플랫폼별 테이블이 여러 개일 때 전체 선택 체크박스 레이블이 중복됩니다.
CampaignDetail.tsx는 플랫폼 섹션마다AdListTable을 렌더링합니다. 각 테이블의 전체 선택 체크박스는 모두 "표시 중인 광고 전체 선택"이라는 동일한aria-label을 가집니다. 스크린리더 사용자는 어떤 플랫폼의 전체 선택인지 구분할 수 없습니다.섹션 구분용 레이블을 props로 받아 붙여 주세요.
🛠 제안 diff
interface IAdsListTableProps { ads: IAd[]; embedded?: boolean; hidePlatformColumn?: boolean; + /** 여러 테이블이 동시에 보일 때 접근성 레이블 구분용 */ + selectAllLabel?: string; selectedAdIds: ReadonlySet<number>; onToggleAd: (adId: number) => void; onToggleSelectAllVisible: (operableIds: readonly number[]) => void; }- aria-label="표시 중인 광고 전체 선택" + aria-label={selectAllLabel ?? "표시 중인 광고 전체 선택"}
CampaignDetail.tsx에서는selectAllLabel={${platform} 광고 전체 선택}형태로 전달하면 됩니다.As per path instructions, "접근성: 시맨틱 HTML, ARIA 속성 사용 확인".
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@src/components/ads/AdListTable.tsx` around lines 87 - 95, Update AdListTable’s props to accept a section-specific selectAllLabel and use it for the select-all checkbox aria-label instead of the fixed text. In CampaignDetail, pass selectAllLabel={`${platform} 광고 전체 선택`} for each platform-rendered AdListTable.Source: Path instructions
🧹 Nitpick comments (9)
src/components/common/select/SearchSelect.tsx (1)
121-127: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick win조건부 클래스는
twMerge로 합치세요.
listPlacement분기에서 조건부 클래스 문자열을 직접 선택하고 있습니다. 공통 클래스와 배치별 클래스를twMerge로 합치세요. 이후 배치별 클래스가 추가되어도 충돌을 일관되게 처리할 수 있습니다.[recommend_refactor]
As per coding guidelines:
Use twMerge for conditional classes.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@src/components/common/select/SearchSelect.tsx` around lines 121 - 127, Update the list container’s className in SearchSelect to use twMerge, passing the shared classes together with the listPlacement-specific classes instead of selecting complete class strings directly. Preserve the existing flow and absolute placement styles while allowing future Tailwind class conflicts to be resolved consistently.Source: Coding guidelines
src/components/workspace/TransferOwnerModal.tsx (1)
8-8: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick win공용
Modalimport에@/별칭을 사용하세요.상대 경로 import는 이동과 리팩터링 시 깨지기 쉽습니다.
@/components/common/modal/Modal로 변경하세요.[recommend_refactor]
As per coding guidelines:
Use@/alias for all imports.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@src/components/workspace/TransferOwnerModal.tsx` at line 8, Update the Modal import in TransferOwnerModal to use the project’s `@/` alias, changing the relative reference to `@/components/common/modal/Modal` while leaving the imported symbol and surrounding code unchanged.Source: Coding guidelines
src/types/workspace/workspace.ts (1)
61-65: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick win새 타입 이름을 저장소 규칙에 맞추세요.
src/types/workspace/workspace.ts#L61-L65:TChangeOwnerRequest,TChangeOwnerResponse를IChangeOwnerRequest,IChangeOwnerResponse로 변경하세요.src/components/workspace/TransferOwnerModal.tsx#L12-L19:TTransferOwnerModalProps를ITransferOwnerModalProps로 변경하세요.As per coding guidelines:
API/request-response use I*andcomponent props use I*Props.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@src/types/workspace/workspace.ts` around lines 61 - 65, Rename the API types TChangeOwnerRequest and TChangeOwnerResponse to IChangeOwnerRequest and IChangeOwnerResponse in src/types/workspace/workspace.ts:61-65, updating all references. Rename the component props type TTransferOwnerModalProps to ITransferOwnerModalProps in src/components/workspace/TransferOwnerModal.tsx:12-19 and update its usages.Source: Coding guidelines
src/components/ads/CampaignPlatformSection.tsx (1)
19-23: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick winSVG 색상 토큰을 적용해 주세요.
Line 20과 Line 22의
GoogleLogo,NaverLogo에는text-*색상 클래스가 없습니다. 두 SVG는fill또는stroke에currentColor를 사용하고, 컴포넌트에는text-text-title같은@theme색상 토큰을 적용하세요.수정 예시
- google: <GoogleLogo className="h-10 w-10 shrink-0" />, + google: <GoogleLogo className="h-10 w-10 shrink-0 text-text-title" />, ... - naver: <NaverLogo className="h-10 w-10 shrink-0" />, + naver: <NaverLogo className="h-10 w-10 shrink-0 text-text-title" />,As per coding guidelines, SVG icons must use
fill/stroke="currentColor"withtext-*color classes.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@src/components/ads/CampaignPlatformSection.tsx` around lines 19 - 23, Update the PLATFORM_LOGO entries for GoogleLogo and NaverLogo to include the `@theme` text color token class text-text-title, matching MetaLogo. Preserve their existing sizing and ensure the SVGs receive color through currentColor-based fill or stroke behavior.Source: Coding guidelines
src/components/ads/AdDetailContent.tsx (1)
9-12: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick win상대 경로 import를
@/alias로 바꿔 주세요.코딩 가이드라인은 모든 import에
@/alias를 사용하도록 정합니다. 이 파일은../common/...상대 경로를 사용합니다. 같은 파일의 다른 import는 이미 alias를 사용하고 있어 방식이 섞여 있습니다.♻️ 제안 수정
-import Badge from "../common/badge/Badge"; -import Button from "../common/button/Button"; -import Modal from "../common/modal/Modal"; -import ModalContent from "../common/modal/ModalContent"; +import Badge from "`@/components/common/badge/Badge`"; +import Button from "`@/components/common/button/Button`"; +import Modal from "`@/components/common/modal/Modal`"; +import ModalContent from "`@/components/common/modal/ModalContent`";As per coding guidelines: "Use
@/alias for all imports."🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@src/components/ads/AdDetailContent.tsx` around lines 9 - 12, Update the imports in AdDetailContent.tsx to replace each ../common/... relative path with the corresponding `@/` alias, keeping the imported Badge, Button, Modal, and ModalContent symbols unchanged and consistent with the file’s existing import style.Source: Coding guidelines
src/hooks/ads/useAdList.ts (1)
20-24: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick win쿼리 키에 non-null 단언 대신 nullable 시그니처를 쓰는 편이 안전합니다.
isValid가 false이면orgId와projectId는null입니다. Line 21은!로 단언하므로 실제 키는["adList", null, null]이 됩니다.enabled: false덕분에 요청은 발생하지 않습니다. 그러나 키 타입 계약(ads(orgId: number, projectId: number))이 깨집니다. 이후 다른 곳에서 이 키를 무효화할 때 혼동이 생길 수 있습니다.
QUERY_KEYS.campaign.ads를number | null허용으로 바꾸거나, 다른 키 생성자들(campaign.list(orgId: number | null))과 동일한 규칙을 따르도록 맞춰 주세요.As per path instructions, "타입 안정성: TypeScript 타입의 명확성 확인".
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@src/hooks/ads/useAdList.ts` around lines 20 - 24, Update the QUERY_KEYS.campaign.ads signature to accept nullable orgId and projectId, matching the nullable-key convention used by campaign.list. Remove the non-null assertions from the useCoreQuery call in useAdList while preserving the existing isValid-enabled behavior and getAdList invocation.Source: Path instructions
src/utils/ads/settleBulkRequests.ts (1)
36-49: 📐 Maintainability & Code Quality | 🔵 Trivial | 💤 Low value도달 불가능한 분기를 정리하면 좋겠습니다.
Error인스턴스는 항상"message" in result.firstError조건을 만족합니다. 따라서 Line 42에서 먼저 throw됩니다. Line 45-47의instanceof Error삼항은 절대 참이 되지 않습니다.♻️ 제안 diff
- throw new Error( - result.firstError instanceof Error - ? result.firstError.message - : "요청에 실패했습니다.", - ); + throw new Error("요청에 실패했습니다.");🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@src/utils/ads/settleBulkRequests.ts` around lines 36 - 49, 정리 함수의 result.firstError 처리에서 중복된 Error 분기를 제거하세요. `result.successCount === 0` 블록의 객체 및 message 검사 경로를 유지하고, 이후 Error 인스턴스를 다시 판별하는 도달 불가능한 삼항 조건은 제거해 기존의 일반 실패 메시지 처리만 남기세요.src/hooks/ads/useUpdateAdStatus.ts (1)
33-39: 🚀 Performance & Scalability | 🔵 Trivial | ⚡ Quick win일괄 상태 변경 훅 두 곳이 동시 요청 수를 제한하지 않습니다. 두 훅 모두 대상 id 개수만큼 PATCH 요청을 한 번에 발행합니다. 근본 원인은
settleBulkRequests가 모든 promise를 즉시 시작한다는 점입니다. 대상이 많으면 브라우저 커넥션 한도와 서버 부하가 동시에 문제가 됩니다.
src/hooks/ads/useUpdateAdStatus.ts#L33-L39:vars.adContentIds를 배치 단위로 나누어 순차 처리하도록 변경해 주세요.src/hooks/ads/useUpdateCampaignStatus.ts#L39-L43:projectIds에 동일한 배치 처리를 적용해 주세요.
settleBulkRequests에 동시성 상한 옵션을 추가하면 두 곳을 한 번에 해결할 수 있습니다. 서버에 일괄 상태 변경 엔드포인트가 있는지도 확인해 주세요.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@src/hooks/ads/useUpdateAdStatus.ts` around lines 33 - 39, Limit concurrent PATCH requests in settleBulkRequests by adding a concurrency cap and processing inputs in sequential batches, rather than starting every promise immediately. Apply this shared behavior to src/hooks/ads/useUpdateAdStatus.ts lines 33-39 for vars.adContentIds and src/hooks/ads/useUpdateCampaignStatus.ts lines 39-43 for projectIds; verify whether an existing bulk status endpoint can be used instead.src/components/ads/AdRow.tsx (1)
13-49: 📐 Maintainability & Code Quality | 🔵 Trivial | 💤 Low value그리드 클래스 헬퍼를 별도 모듈로 분리하는 편이 좋겠습니다.
현재
AdListTable.tsx와skeleton/AdsSkeleton.tsx가 레이아웃 클래스를 얻으려고 행 컴포넌트인AdRow를 import합니다. 컴포넌트와 레이아웃 상수의 책임이 섞입니다.adListTableGrid.ts같은 모듈로 옮기면 의존 방향이 단순해집니다.부수적으로 Line 135는
min-w-11을,AdListTable.tsx헤더는min-w-[2.75rem]을 사용합니다. 값은 같습니다. 표기를 하나로 통일해 주세요.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@src/components/ads/AdRow.tsx` around lines 13 - 49, Move the grid constants, padding values, and helper functions currently defined in AdRow.tsx into a dedicated adListTableGrid module, then update AdRow, AdListTable, and skeleton/AdsSkeleton imports to use that module instead of importing the row component for layout classes. Preserve the existing platform-column behavior and exported class names. Also standardize the equivalent 2.75rem minimum-width classes between AdRow and the AdListTable header, using one consistent notation.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/api/workspace/org.ts`:
- Around line 182-198: Validate cursor advancement in getAllWorkspaceMembers
before continuing the loop: when page.hasNext is true, require page.nextCursor
to be non-null and different from the cursor used for the current request. Throw
an error when this invariant is violated; otherwise update cursor and continue
collecting members normally.
In `@src/components/ads/AdDetailContent.tsx`:
- Around line 23-29: Update the orgIdNum and projectIdNum conversion before
useCreateTrackingUrl so invalid path parameters become null instead of NaN,
allowing only finite numeric values through. Preserve valid numeric IDs and
ensure both the API request and QUERY_KEYS.campaign.ads cache invalidation
receive null for non-finite conversions.
In `@src/components/ads/EditPlatformBudgetModal.tsx`:
- Around line 115-118: Update the activeBudget-driven form initialization in
EditPlatformBudgetModal so platformBudgets refreshes do not reset user-entered
values merely because budgetEditTarget receives a new object reference. Make the
useEffect dependency stable by deriving it from the budget identity fields (such
as providerType, adCampaignId, naverCampaignId, and naverConnectionId), or
preserve the existing IPlatformProjectBudget reference when updating
budgetEditTarget after value changes.
In `@src/components/ads/PlatformBudgetItem.tsx`:
- Around line 29-31: Update the PlatformBudgetItem display around
remainingAmount so the label explicitly distinguishes the over-budget state from
the remaining-budget state: show an “over budget”/“excess amount” message when
isOverBudget is true, and retain the existing remaining-amount wording
otherwise. Ensure the text changes alongside the existing conditional amount and
styling.
In `@src/components/landing/GuideTimeline.tsx`:
- Around line 78-80: Update TimelineBar so its interactive semantics are
conditional on onBarClick: when no handler is provided, omit role="button",
tabIndex, pointer cursor styling, and keyboard event handling; preserve the
existing clickable and keyboard behavior when onBarClick is present. Ensure the
LANDING_TIMELINE_BARS usage remains non-interactive.
In `@src/constants/dashboard/overviewMetricsRange.ts`:
- Around line 4-11: overviewMetricsRange의 고정 endDate 값을 제거하고 최신 동기화 완료일을 API 응답
또는 런타임 계산으로 사용하도록 변경하세요. AI_ANALYSIS_LOOKBACK_DAYS의 14일 제한과 구간 시작일 이전으로 확장하지 않는
동작은 유지하고, 테스트 전용 고정 범위가 production 경로에 사용되지 않도록 분리하세요.
In `@src/pages/ads/list/CampaignDetail.tsx`:
- Around line 204-224: Remove the AD_PLATFORM_ORDER-based sort from the
platformSections useMemo. Return fromAds directly after adding budget-only
sections so the order from groupAdsByPlatform(data.providers) is preserved, with
new sections remaining in platformBudgets iteration order.
In `@src/pages/setting/Setting.tsx`:
- Around line 424-428: Update the change-detection logic that defines
hasOrgToggleChanges to require isAdmin, so non-admin master-notification changes
do not remain part of hasChanges. Keep shouldSaveOrg and the existing save
behavior unchanged, ensuring only administrators can detect and save
Slack/Discord organization-toggle changes.
In `@src/types/dashboard/aiAnalysis.ts`:
- Line 1: Update the import in aiAnalysis.ts to use the project's `@/` alias
instead of the relative "./provider" path, while preserving the existing
TAiAnalysisProvider and TProviderType imports.
In `@src/utils/ads/budgetEdit.ts`:
- Around line 92-111: Update the budget selection logic around declaredType so a
server-declared activeBudgetType is never replaced with the other budget type
when its corresponding data is null. If the active type’s budget data is
unavailable, block editing by returning the existing invalid/unavailable result
or otherwise preventing update payload construction; preserve DAILY and LIFETIME
data handling when present.
In `@src/utils/ads/projectBudget.ts`:
- Around line 62-76: Update the mock budget branches in the project budget
builder, including the NAVER and supportsDailyBudget paths, to set canEditBudget
to false. Ensure placeholder data returned when platformBudgets is unavailable
cannot enable budget-edit actions or trigger real update requests.
---
Outside diff comments:
In `@src/components/ads/AdListTable.tsx`:
- Around line 87-95: Update AdListTable’s props to accept a section-specific
selectAllLabel and use it for the select-all checkbox aria-label instead of the
fixed text. In CampaignDetail, pass selectAllLabel={`${platform} 광고 전체 선택`} for
each platform-rendered AdListTable.
In `@src/components/landing/GuideTimeline.tsx`:
- Around line 22-34: Move the custom-scrollbar rules from the inline style block
in GuideTimeline into the shared utilities stylesheet, defining the reusable
utility class there. Remove the component-level style block and update
GuideTimeline to rely only on the shared custom-scrollbar class.
In `@src/pages/ads/list/CampaignDetail.tsx`:
- Around line 59-68: Normalize orgIdNum and projectIdNum at their conversion
points so non-numeric path parameters become null rather than NaN. Update the
declarations near useCampaignDetail, useAdList, and useUpdateAdStatus to use
finite-number validation, preserving valid numeric IDs and ensuring downstream
orgId == null and orgIdNum != null guards reject invalid values.
---
Nitpick comments:
In `@src/components/ads/AdDetailContent.tsx`:
- Around line 9-12: Update the imports in AdDetailContent.tsx to replace each
../common/... relative path with the corresponding `@/` alias, keeping the
imported Badge, Button, Modal, and ModalContent symbols unchanged and consistent
with the file’s existing import style.
In `@src/components/ads/AdRow.tsx`:
- Around line 13-49: Move the grid constants, padding values, and helper
functions currently defined in AdRow.tsx into a dedicated adListTableGrid
module, then update AdRow, AdListTable, and skeleton/AdsSkeleton imports to use
that module instead of importing the row component for layout classes. Preserve
the existing platform-column behavior and exported class names. Also standardize
the equivalent 2.75rem minimum-width classes between AdRow and the AdListTable
header, using one consistent notation.
In `@src/components/ads/CampaignPlatformSection.tsx`:
- Around line 19-23: Update the PLATFORM_LOGO entries for GoogleLogo and
NaverLogo to include the `@theme` text color token class text-text-title, matching
MetaLogo. Preserve their existing sizing and ensure the SVGs receive color
through currentColor-based fill or stroke behavior.
In `@src/components/common/select/SearchSelect.tsx`:
- Around line 121-127: Update the list container’s className in SearchSelect to
use twMerge, passing the shared classes together with the listPlacement-specific
classes instead of selecting complete class strings directly. Preserve the
existing flow and absolute placement styles while allowing future Tailwind class
conflicts to be resolved consistently.
In `@src/components/workspace/TransferOwnerModal.tsx`:
- Line 8: Update the Modal import in TransferOwnerModal to use the project’s `@/`
alias, changing the relative reference to `@/components/common/modal/Modal` while
leaving the imported symbol and surrounding code unchanged.
In `@src/hooks/ads/useAdList.ts`:
- Around line 20-24: Update the QUERY_KEYS.campaign.ads signature to accept
nullable orgId and projectId, matching the nullable-key convention used by
campaign.list. Remove the non-null assertions from the useCoreQuery call in
useAdList while preserving the existing isValid-enabled behavior and getAdList
invocation.
In `@src/hooks/ads/useUpdateAdStatus.ts`:
- Around line 33-39: Limit concurrent PATCH requests in settleBulkRequests by
adding a concurrency cap and processing inputs in sequential batches, rather
than starting every promise immediately. Apply this shared behavior to
src/hooks/ads/useUpdateAdStatus.ts lines 33-39 for vars.adContentIds and
src/hooks/ads/useUpdateCampaignStatus.ts lines 39-43 for projectIds; verify
whether an existing bulk status endpoint can be used instead.
In `@src/types/workspace/workspace.ts`:
- Around line 61-65: Rename the API types TChangeOwnerRequest and
TChangeOwnerResponse to IChangeOwnerRequest and IChangeOwnerResponse in
src/types/workspace/workspace.ts:61-65, updating all references. Rename the
component props type TTransferOwnerModalProps to ITransferOwnerModalProps in
src/components/workspace/TransferOwnerModal.tsx:12-19 and update its usages.
In `@src/utils/ads/settleBulkRequests.ts`:
- Around line 36-49: 정리 함수의 result.firstError 처리에서 중복된 Error 분기를 제거하세요.
`result.successCount === 0` 블록의 객체 및 message 검사 경로를 유지하고, 이후 Error 인스턴스를 다시 판별하는
도달 불가능한 삼항 조건은 제거해 기존의 일반 실패 메시지 처리만 남기세요.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: 9f71cbd4-33ef-4890-af0a-5c583ee3ad05
⛔ Files ignored due to path filters (2)
src/assets/icon/common/sync.svgis excluded by!**/*.svgand included bysrc/**tests/ai-analysis.spec.tsis excluded by none and included by none
📒 Files selected for processing (73)
src/api/ads/budget.tssrc/api/dashboard/aiAnalysis.tssrc/api/integration/google.tssrc/api/integration/meta.tssrc/api/integration/naver.tssrc/api/workspace/org.tssrc/components/ads/AdDetailContent.tsxsrc/components/ads/AdListTable.tsxsrc/components/ads/AdRow.tsxsrc/components/ads/CampaignPlatformSection.tsxsrc/components/ads/EditPlatformBudgetModal.tsxsrc/components/ads/PlatformBudgetItem.tsxsrc/components/ads/skeleton/AdsSkeleton.tsxsrc/components/common/modal/Modal.tsxsrc/components/common/select/SearchSelect.tsxsrc/components/dashboard/ai-report/components/AiSummaryCard.tsxsrc/components/dashboard/ai-report/components/DashboardAiSummarySection.tsxsrc/components/dashboard/charts/BudgetGaugeChart.tsxsrc/components/integration/NaverSyncModal.tsxsrc/components/integration/PlatformIntegrationCard.tsxsrc/components/landing/GuideTimeline.tsxsrc/components/setting/NotificationSection.tsxsrc/components/setting/PasswordSection.tsxsrc/components/setting/ProfileSection.tsxsrc/components/setting/ProfileSectionSkeleton.tsxsrc/components/setting/WithdrawConfirmModal.tsxsrc/components/sidebar/LogoutConfirmModal.tsxsrc/components/timeline/TimelineBar.tsxsrc/components/timeline/TimelineCreateModal.tsxsrc/components/timeline/TimelineGrid.tsxsrc/components/timeline/TimelinePerformancePanel.tsxsrc/components/timeline/TimelinePeriodSelector.tsxsrc/components/timeline/TimelineStatusLegend.tsxsrc/components/timeline/skeleton/TimelineSkeleton.tsxsrc/components/workspace/InviteMemberModal.tsxsrc/components/workspace/MemberItem.tsxsrc/components/workspace/MemberList.tsxsrc/components/workspace/MemberSearchSelect.tsxsrc/components/workspace/PermissionTable.tsxsrc/components/workspace/TransferOwnerModal.tsxsrc/constants/dashboard/overviewMetricsRange.tssrc/constants/landing/timeline.tssrc/hooks/ads/useAdList.tssrc/hooks/ads/useCreateTrackingUrl.tssrc/hooks/ads/useUpdateAdStatus.tssrc/hooks/ads/useUpdateCampaignStatus.tssrc/hooks/ads/useUpdatePlatformBudget.tssrc/hooks/auth/useDeleteMyAccount.tssrc/hooks/dashboard/useAiAnalysisReport.tssrc/lib/queryKeys.tssrc/pages/ads/list/AdsListPage.tsxsrc/pages/ads/list/CampaignDetail.tsxsrc/pages/dashboard/timeline/Timeline.tsxsrc/pages/integration/PlatformIntegrationsPage.tsxsrc/pages/setting/Setting.tsxsrc/pages/workspace/InviteAcceptPage.tsxsrc/pages/workspace/MemberManagement.tsxsrc/pages/workspace/Workspace.tsxsrc/pages/workspace/WorkspaceSetting.tsxsrc/types/ads/budget.tssrc/types/ads/campaign.tssrc/types/dashboard/aiAnalysis.tssrc/types/dashboard/budget.tssrc/types/integration/platformSync.tssrc/types/workspace/workspace.tssrc/utils/ads/adPlatform.tssrc/utils/ads/budgetEdit.tssrc/utils/ads/formatBudgetInput.tssrc/utils/ads/projectBudget.tssrc/utils/ads/settleBulkRequests.tssrc/utils/dashboard/budget.tssrc/utils/integration/naverSyncSchema.tssrc/utils/integration/platformSync.ts
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🚨 관련 이슈
N/A
✨ 변경사항
✏️ 작업 내용
N/A
😅 미완성 작업
N/A
📢 논의 사항 및 참고 사항
N/A
Summary by CodeRabbit
새 기능
개선 사항