Skip to content

[Bugfix/#397] 알림 Slack/Discord ADMIN에게만 노출 - #400

Merged
jjjsun merged 2 commits into
developfrom
bugfix/#397
Aug 6, 2026
Merged

[Bugfix/#397] 알림 Slack/Discord ADMIN에게만 노출#400
jjjsun merged 2 commits into
developfrom
bugfix/#397

Conversation

@jjjsun

@jjjsun jjjsun commented Aug 5, 2026

Copy link
Copy Markdown
Collaborator

🚨 관련 이슈

Closed #397

✨ 변경사항

  • 🐞 BugFix Something isn't working
  • 💻 CrossBrowsing Browser compatibility
  • 🌏 Deploy Deploy
  • 🎨 Design Markup & styling
  • 📃 Docs Documentation writing and editing (README.md, etc.)
  • ✨ Feature Feature
  • 🔨 Refactor Code refactoring
  • ⚙️ Setting Development environment setup
  • ✅ Test Test related (storybook, jest, etc.)

✏️ 작업 내용

  • 설정 > 알림의 Slack/Discord 연동 UI를 ADMIN에게만 노출
  • MEMBER는 해당 영역 미표시
  • ADMIN이 아닌 경우 Slack/Discord 설정 저장 요청이 나가지 않도록 가드 추가
  • ADMIN만 조작 가능하다는 설명 추가

😅 미완성 작업

N/A

📢 논의 사항 및 참고 사항

  • Slack/Discord는 조직 공용이며 조작 권한은 ADMIN에게만 있습니다. 따라서, ADMIN에게만 보이도록 수정작업 진행하였습니다.
  • 신규 가입자의 알림은
    • 현재: 마스터/이메일/주간 리포트 ON. 나머지 OFF.
    • 신규: 신규: 멤버 알림 기본값 all OFF (8/5 10:00 기준 기본값 전부 OFF로 수정작업 진행하기로 백엔드와 논의완료)
      => (8/6 12:20 기준 기본값 전부 OFF로 수정완료)

💬 리뷰어 가이드 (P-Rules)
P1: 필수 반영 (Critical) - 버그 가능성, 컨벤션 위반. 해결 전 머지 불가.
P2: 적극 권장 (Recommended) - 더 나은 대안 제시. 가급적 반영 권장.
P3: 제안 (Suggestion) - 아이디어 공유. 반영 여부는 드라이버 자율.
P4: 단순 확인/칭찬 (Nit) - 사소한 오타, 칭찬 등 피드백.

@jjjsun
jjjsun requested review from Seojegyeong and YermIm August 5, 2026 14:43
@jjjsun jjjsun self-assigned this Aug 5, 2026
@jjjsun jjjsun added 🎨 Html&css 마크업 & 스타일링 🐞 BugFix Something isn't working labels Aug 5, 2026
@coderabbitai

coderabbitai Bot commented Aug 5, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@jjjsun, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 17 minutes

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 0c822eb9-c7fa-4050-95de-b7c25a008d2f

📥 Commits

Reviewing files that changed from the base of the PR and between 23ba698 and c7a0306.

📒 Files selected for processing (2)
  • src/components/setting/NotificationSection.tsx
  • src/pages/setting/Setting.tsx

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Aug 5, 2026

Copy link
Copy Markdown

📚 Storybook 배포 완료

항목 링크
📖 Storybook https://69a147b60a56365d9e2185ef-gphmvqiabq.chromatic.com/
🔍 Chromatic https://www.chromatic.com/build?appId=69a147b60a56365d9e2185ef&number=561

@YermIm YermIm left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P4: 확인했습니다!

@jjjsun
jjjsun merged commit d427918 into develop Aug 6, 2026
3 checks passed
@jjjsun
jjjsun deleted the bugfix/#397 branch August 6, 2026 01:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🐞 BugFix Something isn't working 🎨 Html&css 마크업 & 스타일링

Projects

None yet

Development

Successfully merging this pull request may close these issues.

🐞 [BugFix] 알림 Slack/Discord를 ADMIN만 노출하도록 수정

2 participants