Skip to content

[Feature/#404] 플랫폼 연동 직후 초기 동기화 - #408

Merged
YermIm merged 4 commits into
developfrom
feature/#404
Aug 6, 2026
Merged

YermIm merged 4 commits into
developfrom
feature/#404

Conversation

@YermIm

@YermIm YermIm commented Aug 6, 2026

Copy link
Copy Markdown
Collaborator

🚨 관련 이슈

close #404

✨ 변경사항

  • 🐞 BugFix Something isn't working
  • 💻 CrossBrowsing Browser compatibility
  • 🌏 Deploy Deploy
  • 🎨 Design Markup & styling
  • 📃 Docs Documentation writing and editing (README.md, etc.)
  • ✨ Feature Feature
  • 🔨 Refactor Code refactoring
  • ⚙️ Setting Development environment setup
  • ✅ Test Test related (storybook, jest, etc.)

✏️ 작업 내용

  • usePlatformSyncMutations 훅 추가 — Meta/Google/Naver sync mutation·toast·connections invalidate 공통화
  • Google OAuth 연동 success 직후 syncGoogle 자동 호출 (useIntegrationOAuthReturn callback)
  • Naver 최초 connect success 직후 sync 모달 자동 오픈 (기본 30일 prefill, reconnect 제외)
  • Meta는 BE OAuth 시 sync → FE initial sync 없음

플랫폼별 연동 직후 동작

  • Meta — BE OAuth 시 sync 처리, FE initial sync 없음
  • Google — OAuth success → 연동 toast → syncGoogle 자동 호출 → sync toast
  • Naver (최초 connect) — connect success → 연동 toast → 연동 모달 닫힘 → sync 모달 자동 오픈 (기본 30일) → 사용자 확인 후 sync
  • Naver (reconnect) — 재연동 toast만, sync 모달/sync API 호출 없음

😅 미완성 작업

N/A

📢 논의 사항 및 참고 사항

💬 리뷰어 가이드 (P-Rules)
P1: 필수 반영 (Critical) - 버그 가능성, 컨벤션 위반. 해결 전 머지 불가.
P2: 적극 권장 (Recommended) - 더 나은 대안 제시. 가급적 반영 권장.
P3: 제안 (Suggestion) - 아이디어 공유. 반영 여부는 드라이버 자율.
P4: 단순 확인/칭찬 (Nit) - 사소한 오타, 칭찬 등 피드백.

Summary by CodeRabbit

  • 새로운 기능

    • Meta, Google, Naver 광고 플랫폼 동기화를 지원합니다.
    • 플랫폼 연결 성공 후 필요한 동기화 절차가 자동으로 이어집니다.
    • Naver 최초 연결 성공 시 동기화 안내 모달이 표시됩니다.
    • 동기화 진행 상태를 확인할 수 있습니다.
  • 개선 사항

    • 동기화 성공 및 실패 결과를 플랫폼별 안내 메시지로 제공합니다.
    • 오류 발생 시 관련 오류 메시지를 더 명확하게 표시합니다.

@YermIm
YermIm requested review from Seojegyeong and jjjsun August 6, 2026 08:44
@YermIm YermIm self-assigned this Aug 6, 2026
@YermIm YermIm added ✨ Feature 기능 개발 🔨 Refactor 코드 리팩토링 labels Aug 6, 2026
@coderabbitai

coderabbitai Bot commented Aug 6, 2026

Copy link
Copy Markdown

Review Change Stack

Warning

Review limit reached

@YermIm, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 54 minutes

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 5926a7f1-2eb6-4221-a476-63093be73305

📥 Commits

Reviewing files that changed from the base of the PR and between 9ef914b and f051f5c.

📒 Files selected for processing (1)
  • src/pages/integration/PlatformIntegrationsPage.tsx
📝 Walkthrough

Walkthrough

Google 및 Naver 연동 성공 콜백을 추가했습니다. 플랫폼별 동기화 mutation을 usePlatformSyncMutations로 통합했습니다. PlatformIntegrationsPage는 새 훅을 사용해 최초 연동 후 동기화와 진행 상태를 처리합니다.

Changes

플랫폼 연동 후 동기화

Layer / File(s) Summary
연동 성공 콜백 계약
src/components/integration/NaverConnectModal.tsx, src/hooks/integration/useIntegrationOAuthReturn.ts
Naver 최초 연결 성공 시 선택적 콜백을 호출합니다. Google OAuth 성공 시 조직 ID와 함께 선택적 콜백을 호출합니다.
플랫폼 동기화 mutation
src/hooks/integration/usePlatformSyncMutations.ts
Meta, Google, Naver 동기화 요청을 제공합니다. 성공 시 연결 정보를 무효화하고 결과별 토스트를 표시합니다. 완료 콜백과 플랫폼별 pending 상태를 반환합니다.
통합 페이지 연결
src/pages/integration/PlatformIntegrationsPage.tsx
기존 플랫폼별 mutation 처리를 새 훅으로 교체합니다. Google OAuth와 Naver 연결 성공 후 동기화를 연결하고 Naver pending 상태를 모달에 반영합니다.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Possibly related issues

Possibly related PRs

Suggested reviewers: jjjsun, seojegyeong

Sequence Diagram(s)

sequenceDiagram
  participant GoogleOAuth
  participant NaverConnectModal
  participant PlatformIntegrationsPage
  participant usePlatformSyncMutations
  GoogleOAuth->>PlatformIntegrationsPage: OAuth 성공 콜백
  PlatformIntegrationsPage->>usePlatformSyncMutations: syncGoogle(orgId)
  NaverConnectModal->>PlatformIntegrationsPage: 최초 connect 성공 콜백
  PlatformIntegrationsPage->>usePlatformSyncMutations: syncNaver(orgId, values)
Loading
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed 제목이 Google·Naver의 플랫폼 연동 직후 초기 동기화라는 주요 변경사항을 간결하게 설명합니다.
Description check ✅ Passed 관련 이슈, 변경 유형, 작업 내용, 미완성 작업 및 플랫폼별 동작을 대부분 충실하게 작성했습니다.
Linked Issues check ✅ Passed Google·Naver 초기 동기화, Meta 제외, 공통 sync 로직 재사용 및 partial success UX 요구사항을 모두 반영했습니다. [#404]
Out of Scope Changes check ✅ Passed 변경된 훅과 페이지 로직은 플랫폼 연동 직후 초기 동기화 목표와 직접 관련되어 범위를 벗어난 변경이 없습니다.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feature/#404

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Aug 6, 2026

Copy link
Copy Markdown

📚 Storybook 배포 완료

항목 링크
📖 Storybook https://69a147b60a56365d9e2185ef-ognufogchd.chromatic.com/
🔍 Chromatic https://www.chromatic.com/build?appId=69a147b60a56365d9e2185ef&number=570

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@src/pages/integration/PlatformIntegrationsPage.tsx`:
- Around line 112-114: Update the onGoogleConnectSuccess callback passed to
useIntegrationOAuthReturn so it sets the syncing provider to Google before
invoking syncGoogle(requestOrgId), ensuring PlatformIntegrationCard displays the
loading state during automatic synchronization. Clear the syncing state through
the existing sync completion/error flow and preserve the current OAuth success
behavior.
🪄 Autofix

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: f524ece8-d81f-4152-af08-c90bc59a90d2

📥 Commits

Reviewing files that changed from the base of the PR and between fb0023d and 9ef914b.

📒 Files selected for processing (4)
  • src/components/integration/NaverConnectModal.tsx
  • src/hooks/integration/useIntegrationOAuthReturn.ts
  • src/hooks/integration/usePlatformSyncMutations.ts
  • src/pages/integration/PlatformIntegrationsPage.tsx

Comment thread src/pages/integration/PlatformIntegrationsPage.tsx

@jjjsun jjjsun left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P4: 확인했습니다! 고생하셨어요!!

@YermIm
YermIm merged commit e4c35ba into develop Aug 6, 2026
3 checks passed
@YermIm
YermIm deleted the feature/#404 branch August 6, 2026 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

✨ Feature 기능 개발 🔨 Refactor 코드 리팩토링

Projects

None yet

Development

Successfully merging this pull request may close these issues.

✨ [Feature] 플랫폼 연동 직후 초기 동기화

2 participants