[Deploy] develop → main 배포 반영 - #340
Merged
Merged
Conversation
📝 WalkthroughWalkthrough알림 설정 조회 API와 쿼리 훅을 추가하고, Changes알림 설정 조회 및 설정 화면 연동
대시보드 지표 기간
Estimated code review effort: 3 (Moderate) | ~20 minutes Sequence Diagram(s)sequenceDiagram
participant Setting
participant useMyNotificationSettings
participant NotificationAPI
participant NotificationSection
Setting->>useMyNotificationSettings: selectedOrgId 기반 조회
useMyNotificationSettings->>NotificationAPI: GET 알림 설정 요청
NotificationAPI-->>useMyNotificationSettings: 설정 데이터 또는 오류
useMyNotificationSettings-->>Setting: 로딩·오류·재시도 상태 반환
Setting->>NotificationSection: 알림 draft/saved 상태 렌더링
Setting->>NotificationAPI: 오류 시 설정 재조회
Possibly related PRs
Suggested labels: Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🧹 Nitpick comments (1)
src/hooks/setting/useMyNotificationSettings.ts (1)
1-1: 📐 Maintainability & Code Quality | 🔵 Trivial | 💤 Low value상대 경로 대신
@/별칭을 사용해주세요.이 경로는 파일 이동 시 깨지기 쉽고, 저장소의 import 규칙과도 다릅니다.
수정 예시
-import { useCoreQuery } from "../customQuery"; +import { useCoreQuery } from "`@/hooks/customQuery`";As per coding guidelines, “Use
@/alias for all imports.”🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@src/hooks/setting/useMyNotificationSettings.ts` at line 1, Update the import in useMyNotificationSettings to use the repository’s `@/` alias instead of the relative ../customQuery path, while preserving the imported useCoreQuery symbol.Source: Coding guidelines
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/pages/setting/Setting.tsx`:
- Around line 219-239: Connect the notification save flow in Setting using
useCoreMutation from customQuery.ts to persist channel and workspace
notification changes through the server. Move setSavedChannel,
setSavedWorkspaceNotif, and the success-toast state behind the mutation’s
successful response, and derive savedAnyNotification only from changes confirmed
as persisted; preserve validation and selectedOrgId guards.
- Around line 291-306: Separate the notification settings initialization in the
useEffect from subsequent refetch handling: reset draftChannel and
draftWorkspaceNotif to server values only on the first successful response after
selectedOrgId changes, while preserving dirty drafts during later
notificationSettings updates. Keep savedChannel and savedWorkspaceNotif
synchronized with the latest server values, and ensure save completion updates
saved state without overwriting unsaved drafts.
---
Nitpick comments:
In `@src/hooks/setting/useMyNotificationSettings.ts`:
- Line 1: Update the import in useMyNotificationSettings to use the repository’s
`@/` alias instead of the relative ../customQuery path, while preserving the
imported useCoreQuery symbol.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: 144cee73-5537-466a-84c0-cb5e11e28ca0
⛔ Files ignored due to path filters (5)
tests/ai-analysis.spec.tsis excluded by none and included by nonetests/fixtures/auth.tsis excluded by none and included by nonetests/login.spec.tsis excluded by none and included by nonetests/navigation.spec.tsis excluded by none and included by nonetsconfig.node.jsonis excluded by none and included by none
📒 Files selected for processing (5)
src/api/notification/notification.tssrc/constants/dashboard/overviewMetricsRange.tssrc/hooks/setting/useMyNotificationSettings.tssrc/lib/queryKeys.tssrc/pages/setting/Setting.tsx
Seojegyeong
added a commit
that referenced
this pull request
Jul 29, 2026
[Deploy] develop → main 배포 반영- #340
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🚨 관련 이슈
N/A
✨ 변경사항
✏️ 작업 내용
N/A
😅 미완성 작업
N/A
📢 논의 사항 및 참고 사항
N/A
Summary by CodeRabbit
새로운 기능
버그 수정