Skip to content

[Bugfix/#336] 플랫폼별 비교 ROAS 랭킹 API 날짜 범위 수정 - #338

Merged
Seojegyeong merged 1 commit into
developfrom
refactor/#336
Jul 28, 2026
Merged

Seojegyeong merged 1 commit into
developfrom
refactor/#336

Conversation

@Seojegyeong

@Seojegyeong Seojegyeong commented Jul 28, 2026

Copy link
Copy Markdown
Collaborator

🚨 관련 이슈

#336

✨ 변경사항

  • 🐞 BugFix Something isn't working
  • 💻 CrossBrowsing Browser compatibility
  • 🌏 Deploy Deploy
  • 🎨 Design Markup & styling
  • 📃 Docs Documentation writing and editing (README.md, etc.)
  • ✨ Feature Feature
  • 🔨 Refactor Code refactoring
  • ⚙️ Setting Development environment setup
  • ✅ Test Test related (storybook, jest, etc.)

✏️ 작업 내용

  • OVERVIEW_DAILY_METRICS_RANGE 날짜 범위 수정
    • startDate: 2026-03-23 → 2026-06-15
    • endDate: 2026-07-07 → 2026-07-15

😅 미완성 작업

N/A

📢 논의 사항 및 참고 사항

N/A

💬 리뷰어 가이드 (P-Rules)
P1: 필수 반영 (Critical) - 버그 가능성, 컨벤션 위반. 해결 전 머지 불가.
P2: 적극 권장 (Recommended) - 더 나은 대안 제시. 가급적 반영 권장.
P3: 제안 (Suggestion) - 아이디어 공유. 반영 여부는 드라이버 자율.
P4: 단순 확인/칭찬 (Nit) - 사소한 오타, 칭찬 등 피드백.

백엔드 DB Mock Data 기간 업데이트에 따라 OVERVIEW_DAILY_METRICS_RANGE를
2026-03-23 ~ 2026-07-07에서 2026-06-15 ~ 2026-07-15로 수정
@Seojegyeong Seojegyeong linked an issue Jul 28, 2026 that may be closed by this pull request
2 tasks
@Seojegyeong Seojegyeong self-assigned this Jul 28, 2026
@Seojegyeong
Seojegyeong requested review from YermIm and jjjsun July 28, 2026 08:00
@coderabbitai

coderabbitai Bot commented Jul 28, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@Seojegyeong, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 13 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 95f7e454-6fe8-4258-9689-40f923b0a679

📥 Commits

Reviewing files that changed from the base of the PR and between 3eaf490 and 5ed508a.

📒 Files selected for processing (1)
  • src/constants/dashboard/overviewMetricsRange.ts
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch refactor/#336

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@Seojegyeong Seojegyeong added 🔨 Refactor 코드 리팩토링 🐞 BugFix Something isn't working labels Jul 28, 2026
@github-actions

Copy link
Copy Markdown

📚 Storybook 배포 완료

항목 링크
📖 Storybook https://69a147b60a56365d9e2185ef-fiqgpxylji.chromatic.com/
🔍 Chromatic https://www.chromatic.com/build?appId=69a147b60a56365d9e2185ef&number=464

@Seojegyeong
Seojegyeong merged commit 4ef7009 into develop Jul 28, 2026
3 checks passed
@Seojegyeong
Seojegyeong deleted the refactor/#336 branch July 28, 2026 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🐞 BugFix Something isn't working 🔨 Refactor 코드 리팩토링

Projects

None yet

Development

Successfully merging this pull request may close these issues.

♻️ [Refactor] 플랫폼 비교 API 요청 날짜 범위 수정(2)

2 participants