Skip to content

[Feature/#330] Playwright E2E 테스트 - 로그인·네비게이션·AI 분석 시나리오 추가 - #337

Merged
Seojegyeong merged 5 commits into
developfrom
feature/#330
Jul 28, 2026
Merged

[Feature/#330] Playwright E2E 테스트 - 로그인·네비게이션·AI 분석 시나리오 추가#337
Seojegyeong merged 5 commits into
developfrom
feature/#330

Conversation

@Seojegyeong

@Seojegyeong Seojegyeong commented Jul 28, 2026

Copy link
Copy Markdown
Collaborator

🚨 관련 이슈

#330

✨ 변경사항

  • 🐞 BugFix Something isn't working
  • 💻 CrossBrowsing Browser compatibility
  • 🌏 Deploy Deploy
  • 🎨 Design Markup & styling
  • 📃 Docs Documentation writing and editing (README.md, etc.)
  • ✨ Feature Feature
  • 🔨 Refactor Code refactoring
  • ⚙️ Setting Development environment setup
  • ✅ Test Test related (storybook, jest, etc.)

✏️ 작업 내용

  • tests/fixtures/auth.ts 공통 auth fixture 추출
    • test.extend()로 dashboardPage fixture 정의 — 로그인 → 대시보드 진입까지 자동 처리
    • loginAndReachDashboard, waitForDashboardReady, expandSidebarIfCollapsed 헬퍼 함수 분리
  • login.spec.ts, navigation.spec.ts를 auth fixture 기반으로 리팩터
  • tests/ai-analysis.spec.ts AI 분석 E2E 시나리오 추가 (3개 케이스)
    • 카드 접힌 상태 초기 렌더 확인
    • 펼치기 클릭 후 로딩 상태 표시 확인
    • 분석 결과 도착 시 핵심 섹션 3곳 렌더 확인
  • page.route() URL 함수 매처로 AI API 모킹 (glob 패턴 대신 사용)
  • tsconfig.node.json에서 deprecated baseUrl 옵션 제거

😅 미완성 작업

N/A

📢 논의 사항 및 참고 사항

AI 분석 테스트는 page.route()로 API를 모킹하는 방식으로 구현했습니다.
실제 LLM 호출은 10~30초 이상 소요되고 외부 서비스 가용성에 의존하므로
E2E에서는 응답을 고정해 빠르고 안정적인 테스트를 보장하는 것이 적절하다고 판단했습니다.

💬 리뷰어 가이드 (P-Rules)
P1: 필수 반영 (Critical) - 버그 가능성, 컨벤션 위반. 해결 전 머지 불가.
P2: 적극 권장 (Recommended) - 더 나은 대안 제시. 가급적 반영 권장.
P3: 제안 (Suggestion) - 아이디어 공유. 반영 여부는 드라이버 자율.
P4: 단순 확인/칭찬 (Nit) - 사소한 오타, 칭찬 등 피드백.

@Seojegyeong
Seojegyeong requested review from YermIm and jjjsun July 28, 2026 07:51
@Seojegyeong Seojegyeong self-assigned this Jul 28, 2026
@Seojegyeong Seojegyeong added the ✅ Test test 관련(storybook, jest...) label Jul 28, 2026
@coderabbitai

coderabbitai Bot commented Jul 28, 2026

Copy link
Copy Markdown

Important

Review skipped

Review was skipped due to path filters

⛔ Files ignored due to path filters (5)
  • tests/ai-analysis.spec.ts is excluded by none and included by none
  • tests/fixtures/auth.ts is excluded by none and included by none
  • tests/login.spec.ts is excluded by none and included by none
  • tests/navigation.spec.ts is excluded by none and included by none
  • tsconfig.node.json is excluded by none and included by none

CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including **/dist/** will override the default block on the dist directory, by removing the pattern from both the lists.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 1e18d476-adad-484d-84d5-1485b84e718d

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feature/#330

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

Copy link
Copy Markdown

📚 Storybook 배포 완료

항목 링크
📖 Storybook https://69a147b60a56365d9e2185ef-ipkwnrzkpc.chromatic.com/
🔍 Chromatic https://www.chromatic.com/build?appId=69a147b60a56365d9e2185ef&number=463

@Seojegyeong
Seojegyeong merged commit 9ed4445 into develop Jul 28, 2026
3 checks passed
@Seojegyeong
Seojegyeong deleted the feature/#330 branch July 28, 2026 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

✅ Test test 관련(storybook, jest...)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

✨ [Feature] Playwright E2E - 로그인·대시보드·AI 분석 핵심 플로우 시나리오 작성

2 participants