Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove CGO dependency from daemon_darwin.go #32

Closed
wants to merge 1 commit into from

Conversation

priyawadhwa
Copy link

@priyawadhwa priyawadhwa commented Oct 23, 2020

This should fix the darwin on linux cross compilation issue.

From the golang docs around os.Executable:

Executable returns the path name for the executable that started the current process. There is no guarantee that the path is still pointing to the correct executable. If a symlink was used to start the process, depending on the operating system, the result might be the symlink or the path it pointed to. If a stable result is needed, path/filepath.EvalSymlinks might help.

Executable returns an absolute path unless an error occurred.

Fixes #31

@priyawadhwa
Copy link
Author

closing in favor of #28

@gkristic-vc
Copy link

Thanks @priyawadhwa. You are right. I'll follow up in the other PR (that we kind of missed/ignored for a while, it seems 🤫)

@priyawadhwa priyawadhwa deleted the darwin branch October 26, 2020 22:18
@gkristic-vc
Copy link

@priyawadhwa In case you didn't notice: the related PR was merged. Thanks once again for taking the time to submit this.

@priyawadhwa
Copy link
Author

@gkristic thank you for letting me know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use os.Executable for daemon_darwin.go
2 participants