Use the standard library Executable function instead #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gkristic-vc
reviewed
Oct 23, 2020
There was a problem hiding this comment.
os.Executable was added with 1.8. This code is older than that; hence the built-in heavy lifting. The only thing I think we're losing here is the filepath.Clean. But other than that it looks like a nice cleanup to me. @efepapa Want to double check?
|
By the way... thanks @GameXG. And apologies for our "delay" getting back to you. |
|
Looks good 👍 |
|
@bashcraftvc You may be interested in following up here and merging whenever you feel good with it. It's a nice cleanup. |
|
Merged after chatting with @efepapa . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#27