Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use os.Executable for daemon_darwin.go #31

Open
priyawadhwa opened this issue Oct 23, 2020 · 0 comments
Open

Use os.Executable for daemon_darwin.go #31

priyawadhwa opened this issue Oct 23, 2020 · 0 comments

Comments

@priyawadhwa
Copy link

Currently, we can't cross compile darwin on linux because it uses CGO. I think we could remove CGO entirely from that file and replace the current GetExecutablePath() function with:

func GetExecutablePath() (string, error) {
	return os.Executable()
}

If I'm missing something here please let me know, but I tested locally and it seems to be working. Happy to submit a PR if this is a suitable fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant