Add support for indent objects

[mikew]

As defined at michaeljsmith/vim-indent-object.

Supports ai, ii, and aI with c, d, and v operators.

Refs #1096.

[mikew]

Actually, looks like I broke some logic when I refractored before final submission. The tests aren't specific enough

[mikew]

Hmmm, that failing test wasn't modified by this PR and passed the first time. I'm guessing a maintainer can retry the build.

I do have some questions though:

1. I made a class IndentObjectMatch extends BaseMovement in actions.ts but I'm not sure the use of it. I based it off of MoveTagMatch with some logic removed.
2. TextEditor.getLineMaxColumn errors when dealing with line 0 when it seems like there's nothing stopping it from working. I've worked around this by using TextEditor.readLineAt(endLineNumber).length
3. I'm not sure how to implement the d operator properly. As currently implemented, dii will leave you with a blank line, when really that line should be gone too. I couldn't figure out how to get rid of it without also removing the first character of the next line.

[jpoon]

Restarted. Not the best person to review though.

[mikew]

Appreciated. Though I'm only just now noticing the existing TextObjectMovement class. I can easily refactor all logic into that style.

[johnfn]

Wow, impressive work! Thanks for the contribution.

Would you mind adding a little blurb in the README to explain what's going on here/how to use these guys?

And yeah if you want to refactor to the TextObjectMovement class too, that would be awesome. It's not necessary for the merge though, so just let me know.

[mikew]

Already done days ago, just never pushed. Working on the README now but it seems it's changed a lot in master.

[johnfn]

Yeah, we had a PR a few days ago that totally rewrote it. :) Should be stable-ish now.

[mikew]

I merged master and updated the README. I decided against examples since it seemed to add a lot and instead went with comparing it to cit/ci{/ci[/ciB

[johnfn]

Looks good to me. It's kind of funny since I added the custom af command to VSCodeVim to do (nearly) the exact same thing. Eh, what are you going to do?

Thanks again for the awesome work. :)

[mikew]

Glad to help. And I was just thinking it would be cool if the count prefix could mean "look n levels up". As it stands, canBePrefixedWithCount should be false. Missed that one.