Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix logo src so logo displays inside VSCode #1572

Merged
merged 2 commits into from
Apr 25, 2017

Conversation

cobbweb
Copy link
Contributor

@cobbweb cobbweb commented Apr 25, 2017

The relative URL that was being used only works when viewing the README
from GitHub, and leaves a big blank space if you open VSCodeVim's page
inside VSCodeVim.

This uses a full URL, which should fix the issue. This is how the Chrome
Debugger plugin loads their logo.

The relative URL that was being used only works when viewing the README
from GitHub, and leaves a big blank space if you open VSCodeVim's page
inside VSCodeVim.

This uses a full URL, which should fix the issue. This is how the Chrome
Debugger plugin loads their logo.
@jpoon
Copy link
Member

jpoon commented Apr 25, 2017

Wasn't relative file path working previously? What changed?

Edit: I see, it's because we moved it to HTML.

@jpoon
Copy link
Member

jpoon commented Apr 25, 2017

@cobbweb what is rawgit and why should we use it over directly linking to GH?

@cobbweb
Copy link
Contributor Author

cobbweb commented Apr 25, 2017

rawgit provide a free CDN wrapper around files in GitHub repos. I only used it because that's how the Chrome Debugger plugin reference theirs.

IIRC correctly, rawgit's main feature is that it serves JS files with proper headers, and maybe doesn't provide any value for us here. We can just link directly to: https://raw.githubusercontent.com/VSCodeVim/Vim/master/images/icon.png

Let me know if you want it changed.

@jpoon
Copy link
Member

jpoon commented Apr 25, 2017

Yeah, let's go with raw.githubusercontent.com. Don't want to rely on an external dependency if we don't have to. rawgit sounds like an awesome project, but don't know how long a free project/hosting will last.

@jpoon
Copy link
Member

jpoon commented Apr 25, 2017

Whoa, that's crazy. I have commit rights to your fork 😮

@jpoon jpoon merged commit 2b5fafb into VSCodeVim:master Apr 25, 2017
@jpoon
Copy link
Member

jpoon commented Apr 25, 2017

Thanks @cobbweb.

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants