Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gq incorrectly handles triple-slash doc-comments #1449

Closed
rnewman opened this issue Mar 30, 2017 · 3 comments
Closed

gq incorrectly handles triple-slash doc-comments #1449

rnewman opened this issue Mar 30, 2017 · 3 comments
Labels

Comments

@rnewman
Copy link

rnewman commented Mar 30, 2017

Steps

Type a line like the following, in Rust:

/// One two three four five six seven eight nine ten. One two three four five six seven eight nine ten. One two three four five six seven eight nine ten.

Visually select the entire line: 0v$

Reformat line: gq.

Expected:

With 100-column wrap:

/// One two three four five six seven eight nine ten. One two three four five six seven eight nine
/// ten. One two three four five six seven eight nine ten.

Actual:

With 100-column wrap:

// / One two three four five six seven eight nine ten. One two three four five six seven eight nine
// ten. One two three four five six seven eight nine ten.

Technical details:

  • VSCode Version: 1.11.0-insider
  • VsCodeVim Version: 0.6.11
  • OS: macOS 10.11.6.
@johnfn johnfn added the kind/bug label Apr 2, 2017
@johnfn
Copy link
Member

johnfn commented Apr 2, 2017

This might be an incredibly easy bug for anyone who wants to contribute to pick up.

(or it could be incredibly hard...)

@jpoon jpoon closed this as completed in 933fd87 Apr 25, 2017
cobbweb pushed a commit to cobbweb/Vim that referenced this issue May 3, 2017
@jonhoo
Copy link

jonhoo commented May 15, 2017

Hmm, I'm not sure this is actually fixed? The initial problem is, but now the first of the resulting wrapped lines is indented one space too few:

    /// Mark this node as sharded by a value that stems from the given column of the given source awdkjd

after Vgq turns into

   /// Mark this node as sharded by a value that stems from the given
    /// column of the given source awdkjd

@Chillee
Copy link
Member

Chillee commented May 15, 2017

Yeah I realized I fucked it up in #1684. I fixed the bug in a pr, but there's a couple more gq related bugs I want to fix (plus it's finals week for me, so I haven't had too much time).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants