Skip to content

Conversation

@sebastienlagarde
Copy link
Contributor

@sebastienlagarde sebastienlagarde commented Oct 12, 2021

Purpose of this PR


Testing status

Describe what manual/automated tests were performed for this PR


Comments to reviewers

Notes for the reviewers you have assigned.

pmavridis and others added 30 commits May 26, 2021 19:23
* Fix AxF debug output in certain configurations.

* Update comment
* Fix white flash

* changelog

Co-authored-by: sebastienlagarde <[email protected]>
* Show info box when ray tracing is enabled.

* Changelog

* Move below MSAA

Co-authored-by: sebastienlagarde <[email protected]>
…phics Compositor enabled (#4593)

Co-authored-by: sebastienlagarde <[email protected]>
* Reconstruct jittered projection matrix far plane (for Infinite )

* Changelog

Co-authored-by: sebastienlagarde <[email protected]>
* Fix overdraw in custom pass utils blur function

* Updated changelog

Co-authored-by: sebastienlagarde <[email protected]>
* Fix

* changelog

* Force sync compilation for TAA

Co-authored-by: CifaCia <[email protected]>
Co-authored-by: sebastienlagarde <[email protected]>
…side is updated. (case 1335737, related to 1314040) (#4691)

Co-authored-by: sebastienlagarde <[email protected]>
…ing only the RTSSS Data (case 1332904). (#4626)

* Fixed the ray traced sub subsurface scattering debug mode not displaying only the RTSSS Data (case 1332904).

* Add test scene

Co-authored-by: Remi Chapelain <[email protected]>
Co-authored-by: Sebastien Lagarde <[email protected]>
…e refraction and probe refraction (#4653)

* Delete the second transmittance mul

* Changelog

Co-authored-by: Sebastien Lagarde <[email protected]>
#4636)

* Initialize the shading normal to a non-zero value for anisotropy

* Changelog

Co-authored-by: sebastienlagarde <[email protected]>
* Fix VfX lit particle aov output color space

* Update comment

Co-authored-by: sebastienlagarde <[email protected]>
* Fixed issue with transparent unlit.

* Updated changelog.

* Reverted accidental change to default mtl.

Co-authored-by: sebastienlagarde <[email protected]>
* Fix

* changelog

Co-authored-by: sebastienlagarde <[email protected]>
…cal volumetric fog volume (#4728)

* Fixed nullref when deleting the 3D mask of a density volume (case 1339330)

* Updated changelog

Co-authored-by: sebastienlagarde <[email protected]>
adrien-de-tocqueville and others added 8 commits October 4, 2021 18:58
* Fix shadow mask fade and optimize.

* changelog
#5912)

* Fix contact shadows not being bound in debug and good default shadow

* changelog

* Rename

* Handle more edge cases where shadows are not drawn to atlas (disabled scene view lighting)

Co-authored-by: John Parsaie <[email protected]>
Co-authored-by: sebastienlagarde <[email protected]>
…degrade greatly when manipulating them in editor. (#5901)
@github-actions
Copy link

Hi! This comment will help you figure out which jobs to run before merging your PR. The suggestions are dynamic based on what files you have changed.
Link to Yamato: https://unity-ci.cds.internal.unity3d.com/project/902/
Search for your PR branch using the search bar at the top, then add the following segment(s) to the end of the URL (you may need multiple tabs depending on how many packages you change)

HDRP
/jobDefinition/.yamato%2Fall-hdrp.yml%23HDRP_trunk
With changes to HDRP packages, you should also run
/jobDefinition/.yamato%252Fall-lightmapper.yml%2523PR_LightMapper_trunk

SRP Core
You could run ABV on your branch before merging your PR, but it will start A LOT of jobs. Please be responsible about it and run it only when you feel the PR is ready:
/jobDefinition/.yamato%252F_abv.yml%2523all_project_ci_trunk
Be aware that any modifications to the Core package impacts everyone in the Graphics repo so please discuss the PR with your lead.

Depending on the scope of your PR, you may need to run more jobs than what has been suggested. Please speak to your lead or a Graphics SDET (#devs-graphics-automation) if you are unsure.

@sebastienlagarde sebastienlagarde marked this pull request as ready for review October 15, 2021 10:55
@sebastienlagarde sebastienlagarde merged commit 6e68b35 into master Oct 15, 2021
sebastienlagarde added a commit that referenced this pull request Oct 15, 2021
sebastienlagarde added a commit that referenced this pull request Oct 16, 2021
* [HDRP] fix screenshots after cache server reset

* Bugfix 1359282: Emissive decal silhouette issue #5532

* Force scalarization of shadow index data off (#6007)

* [HDRP] Merge Hd/bugfix #5999

* Fix PBR Accumulation for 10.6 (#5991)

* Fix PBR Accumulation for 10.6

* Add ChangeLog

* Update CHANGELOG.md

* Fix shadow mask fade and optimize it at same time #5911

* Revert: Fixed tooltip not showing on labels in ShaderGraphs #5877

* Update CHANGELOG.md

* update reference screenhsots

Co-authored-by: Jarkko Lempiäinen <[email protected]>
Co-authored-by: FrancescoC-unity <[email protected]>
Co-authored-by: skhiat <[email protected]>
sebastienlagarde added a commit that referenced this pull request Oct 18, 2021
sebastienlagarde added a commit that referenced this pull request Oct 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.